[GitHub] [mina-sshd] fherbreteau commented on pull request #404: Add support for Proxy Protocol V2

2023-09-01 Thread via GitHub
fherbreteau commented on PR #404: URL: https://github.com/apache/mina-sshd/pull/404#issuecomment-1703608365 Indentation fixed. Commit squashed with new commit message. btw I've reused your proposal as it fits the intent of the MR. -- This is an automated message from the Apache Git

[GitHub] [mina-sshd] fherbreteau commented on a diff in pull request #404: Add support for Proxy Protocol V2

2023-09-01 Thread via GitHub
fherbreteau commented on code in PR #404: URL: https://github.com/apache/mina-sshd/pull/404#discussion_r1313668685 ## sshd-contrib/pom.xml: ## @@ -80,6 +80,16 @@ test-jar test + + org.mockito +

[GitHub] [mina-sshd] fherbreteau commented on a diff in pull request #404: Add support for Proxy Protocol V2

2023-09-01 Thread via GitHub
fherbreteau commented on code in PR #404: URL: https://github.com/apache/mina-sshd/pull/404#discussion_r1313667435 ## sshd-common/src/main/java/org/apache/sshd/common/util/buffer/Buffer.java: ## @@ -292,6 +292,10 @@ public short getShort() { return v; } +

[GitHub] [mina-sshd] dependabot[bot] commented on pull request #400: Bump org.codehaus.plexus:plexus-archiver from 4.2.6 to 4.8.0

2023-09-01 Thread via GitHub
dependabot[bot] commented on PR #400: URL: https://github.com/apache/mina-sshd/pull/400#issuecomment-1703282548 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version,

[GitHub] [mina-sshd] tomaswolf closed pull request #400: Bump org.codehaus.plexus:plexus-archiver from 4.2.6 to 4.8.0

2023-09-01 Thread via GitHub
tomaswolf closed pull request #400: Bump org.codehaus.plexus:plexus-archiver from 4.2.6 to 4.8.0 URL: https://github.com/apache/mina-sshd/pull/400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [mina-sshd] tomaswolf commented on pull request #400: Bump org.codehaus.plexus:plexus-archiver from 4.2.6 to 4.8.0

2023-09-01 Thread via GitHub
tomaswolf commented on PR #400: URL: https://github.com/apache/mina-sshd/pull/400#issuecomment-1703282502 Done as part of commit 9cc8be8, which also bumped the Apache parent POM and thus a lot of other versions of build-time dependencies. -- This is an automated message from the Apache

[GitHub] [mina-sshd] tomaswolf commented on a diff in pull request #404: Add support for Proxy Protocol V2

2023-09-01 Thread via GitHub
tomaswolf commented on code in PR #404: URL: https://github.com/apache/mina-sshd/pull/404#discussion_r1313454310 ## sshd-contrib/pom.xml: ## @@ -80,6 +80,16 @@ test-jar test + + org.mockito +

[GitHub] [mina-sshd] tomaswolf opened a new pull request, #413: GH-410: Ensure EOF gets sent before CLOSE when Channel closes

2023-09-01 Thread via GitHub
tomaswolf opened a new pull request, #413: URL: https://github.com/apache/mina-sshd/pull/413 When a channel using a ChannelAsyncOutputStream, do not only wait until all pending data has been written but also wait for the EOF having been sent before proceeding with closing the channel.

[GitHub] [mina-sshd] tomaswolf merged pull request #411: Use Apache parent POM 30

2023-09-01 Thread via GitHub
tomaswolf merged PR #411: URL: https://github.com/apache/mina-sshd/pull/411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: