[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16387669#comment-16387669
]
masc commented on SSHD-786:
---
thanks.. we could only see this on productive systems with specific clients and
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380791#comment-16380791
]
masc commented on SSHD-786:
---
are there maven coordinates for nightlies or your current patch? as I just
removed
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380768#comment-16380768
]
masc commented on SSHD-786:
---
we haven't tested excessively on linux (just yet), but I can confirm 1.7.0 is
stable
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296936#comment-16296936
]
masc commented on SSHD-786:
---
interesting. the behaviour seems to occur only when latency gets bad. and
today's
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16296936#comment-16296936
]
masc edited comment on SSHD-786 at 12/19/17 3:13 PM:
-
interesting. the behaviour seems
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16294877#comment-16294877
]
masc commented on SSHD-786:
---
I would like to, but as the issue is quite sporadic and only replicable on our
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16290657#comment-16290657
]
masc commented on SSHD-786:
---
delegating such errors to a listener would be beneficial in general, yes.
I don't see
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289725#comment-16289725
]
masc commented on SSHD-786:
---
but since we cannot really pin this down, I would agree to your PR. maybe it
gives
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289712#comment-16289712
]
masc commented on SSHD-786:
---
and btw not calling {{onFailed}} will most certainly not prevent an infinite
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289698#comment-16289698
]
masc commented on SSHD-786:
---
I have been taking a closer look and setting the host to {{0.0.0.0}} doesn't
seem to
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289480#comment-16289480
]
masc commented on SSHD-786:
---
I'm not so sure about it. I'd rather expect this call to fail again when
retried
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16289085#comment-16289085
]
masc commented on SSHD-786:
---
but doesn't sshd end up in the same inconsistent state when the exception
occurs on
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285916#comment-16285916
]
masc commented on SSHD-786:
---
and thanks for the recommendations, the ipv6 address also caught my eye,
especially
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285916#comment-16285916
]
masc edited comment on SSHD-786 at 12/11/17 1:43 PM:
-
and thanks for the
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285916#comment-16285916
]
masc edited comment on SSHD-786 at 12/11/17 1:43 PM:
-
and thanks for the
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285883#comment-16285883
]
masc commented on SSHD-786:
---
maybe it would be a good solution to clean shutdown the server on this fatal
error
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285875#comment-16285875
]
masc commented on SSHD-786:
---
In no way should sshd keep running in an inconsistent non-functional state,
which
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16285866#comment-16285866
]
masc commented on SSHD-786:
---
I don't see how a single retry would be a feasible solution to this problem.
Failure
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
masc updated SSHD-786:
--
Comment: was deleted
(was: I see the real stack trace is swallowed when this error is logged.
{code}
protected
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277133#comment-16277133
]
masc commented on SSHD-786:
---
I see the real stack trace is swallowed when this error is logged.
{code}
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277112#comment-16277112
]
masc edited comment on SSHD-786 at 12/4/17 5:21 PM:
maybe it's worth to check against
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277112#comment-16277112
]
masc edited comment on SSHD-786 at 12/4/17 5:21 PM:
maybe it's worth to check against
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16277112#comment-16277112
]
masc commented on SSHD-786:
---
maybe it's worth to check against {3.0.0} first. I believe currently
{sshd-core}
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276567#comment-16276567
]
masc commented on SSHD-786:
---
it has been observed in other places too, for reference
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276562#comment-16276562
]
masc commented on SSHD-786:
---
the problem is also not the exception itself, but {{sshd-core}} not being able
to
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276561#comment-16276561
]
masc edited comment on SSHD-786 at 12/4/17 9:59 AM:
maybe. however this process hosts
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16276561#comment-16276561
]
masc commented on SSHD-786:
---
maybe. however this process hosts other tcp services which are and never have
been
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
masc updated SSHD-786:
--
Affects Version/s: 1.2.0
1.3.0
> Clients can't authenticate after unexpected exception in
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268935#comment-16268935
]
masc commented on SSHD-743:
---
Thanks! I verified the fix and it seems to work well, stress tested on both
Windows
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16268924#comment-16268924
]
masc commented on SSHD-786:
---
Verified on Windows against master / 1.7.0-SNAPSHOT. The issue cannot be
replicated
[
https://issues.apache.org/jira/browse/SSHD-786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
masc updated SSHD-786:
--
Description:
{code}
2017-11-28 15:26:54,808 11566202 sshd-SshServer[434a2a10]-nio2-thread-4
masc created SSHD-786:
-
Summary: Clients can't authenticate after unexpected exception in
Nio2Acceptor
Key: SSHD-786
URL: https://issues.apache.org/jira/browse/SSHD-786
Project: MINA SSHD
Issue Type:
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254055#comment-16254055
]
masc commented on SSHD-743:
---
Thinking about it, you're right.
The latter issue actually does not relate, as it
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254043#comment-16254043
]
masc commented on SSHD-743:
---
I'm not 100% it's originating from the c'tor code, but it may be a possibility.
>
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16254029#comment-16254029
]
masc commented on SSHD-743:
---
No it's not. This issue is about network io related exceptions leaking from
threads,
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16251291#comment-16251291
]
masc commented on SSHD-743:
---
btw there's more exception leaks, this time observed in {{Nio2Session}} c'tor,
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249423#comment-16249423
]
masc commented on SSHD-743:
---
ok. I can't further comment on this without digging deeper, but from my current
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16249423#comment-16249423
]
masc edited comment on SSHD-743 at 11/13/17 11:35 AM:
--
ok. I can't further comment on
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16248560#comment-16248560
]
masc commented on SSHD-743:
---
what is the reason for starting another write while handling an actual write
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246108#comment-16246108
]
masc commented on SSHD-743:
---
so possibly the best way to fix this without swallowing exceptions would be to
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246092#comment-16246092
]
masc edited comment on SSHD-743 at 11/9/17 5:22 PM:
actually I don't think it makes
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246092#comment-16246092
]
masc commented on SSHD-743:
---
actually I don't think it makes sense at all to start writing when the writing
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246080#comment-16246080
]
masc commented on SSHD-743:
---
plus, I believe the cases you're trying to avoid would be valid exceptions
during
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16246078#comment-16246078
]
masc commented on SSHD-743:
---
that's true for most cases, but in this specific case, where a write is
attempted
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245747#comment-16245747
]
masc edited comment on SSHD-743 at 11/9/17 2:40 PM:
as I see it, {{finishWrite}} is ok
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16245747#comment-16245747
]
masc commented on SSHD-743:
---
as I see it, {finishWrite} is ok and should actually throw. it's just, that it
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235795#comment-16235795
]
masc commented on SSHD-743:
---
even though, going with the above implementation, this would merely prevent the
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235791#comment-16235791
]
masc commented on SSHD-743:
---
about the {{isOpen}} check, as an exception would be valid in this case for
other
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235781#comment-16235781
]
masc edited comment on SSHD-743 at 11/2/17 2:04 PM:
I believe {{finishWrite}} should be
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235781#comment-16235781
]
masc edited comment on SSHD-743 at 11/2/17 2:04 PM:
I believe {{finishWrite}} should be
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235781#comment-16235781
]
masc commented on SSHD-743:
---
I believe {{finsihWrite}} should be allowed to throw at all times.
t's only fatal
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
masc updated SSHD-743:
--
Environment: (was: Windows)
> Nio2Session sporadically leaks exceptions from nio2 threads
>
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
masc updated SSHD-743:
--
Affects Version/s: 1.6.0
> Nio2Session sporadically leaks exceptions from nio2 threads
>
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235634#comment-16235634
]
masc edited comment on SSHD-743 at 11/2/17 12:19 PM:
-
the issue seems to be
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16235634#comment-16235634
]
masc commented on SSHD-743:
---
the issue seems to be {Nio2Session.handleWriteCycleFailure} calling into
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
masc updated SSHD-743:
--
Fix Version/s: (was: 1.6.0)
> Nio2Session sporadically leaks exceptions from nio2 threads
>
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
masc reopened SSHD-743:
---
re-opening, as the issue also occurs with 1.6.0
> Nio2Session sporadically leaks exceptions from nio2 threads
>
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16196822#comment-16196822
]
masc commented on SSHD-743:
---
this seems to be fixed in `sshd-1.6.0`, at least I cannot replicate the issue
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
masc resolved SSHD-743.
---
Resolution: Fixed
Fix Version/s: 1.6.0
cannot be replicated with 1.6.0
> Nio2Session sporadically leaks
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981468#comment-15981468
]
masc edited comment on SSHD-743 at 4/24/17 4:43 PM:
* The issue occurs since `1.3.0` but
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981468#comment-15981468
]
masc edited comment on SSHD-743 at 4/24/17 4:39 PM:
* The issue occurs since `1.3.0` but
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981475#comment-15981475
]
masc commented on SSHD-743:
---
Correction: we set the idle timeout on the ssh client side, not the host.
>
[
https://issues.apache.org/jira/browse/SSHD-743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981468#comment-15981468
]
masc commented on SSHD-743:
---
* The issue occurs since `1.3.0` but `1.4.0` was tested as well and didn't make
a
63 matches
Mail list logo
