Thx, this issue is quite critical, as the data send it invalid :-( The better fix is to use putRawBytes instead of putBytes (my bad). I've enhanced the junit tests so that this problem is better captured. I will recut a release candidate asap.
So i'm cancelling this release. On Fri, Nov 20, 2009 at 06:39, Glenn McGregor <g...@alcatel-lucent.com> wrote: > On 11/19/2009 8:57 AM, Guillaume Nodet wrote: > > I've uploaded a new release of SSHD that a few bugs / enhancements. > > The release is available at > http://people.apache.org/~gnodet/staging/sshd-0.3.0/ > > The source and binary distributions are available at: > > http://people.apache.org/~gnodet/staging/sshd-0.3.0/org/apache/sshd/apache-sshd/0.3.0/ > > The binary distribution includes a very simple demo which is far from > perfect but that's a start at least ... > > The release page is available at: > http://cwiki.apache.org/SSHD/sshd-030.html > > Please review and vote > [ ] +1 Release SSHD 0.3.0 > [XXX ] -1 Do not release > > -- > Cheers, > Guillaume Nodet > ------------------------ > Blog: http://gnodet.blogspot.com/ > ------------------------ > Open Source SOA > http://fusesource.com > > There's a bug in the flush method in ChannelOutputStream. An extra 4 bytes > containing a length are written to the stream. > > A less than totally aesthetic fix is: > > if (total > length) { > + buffer.wpos( buffer.wpos() - 4 ); // !!! back up the > write position to avoid including 2 copies of the length > buffer.putBytes(buf.array(), pos - (total - length), > total - length); > bufferLength = total - length; > } > > BR > > Glenn McGregor > > -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ Open Source SOA http://fusesource.com
