elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-123546
Pushed in 2.2.X
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1554469397
Will do this week-end!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1548571855
I think we can cut it ASAP. It's a matter of 3/4 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1541786919
yes, I followed John's advice and used the new pattern (ie develop a custom
SSLFilter inheriting the base SSLFilter to pass a new attribute).
We may discuss this pattern though, because
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1541304843
Ok, I pushed the modified code with the working tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1540100131
Hi,
I confirm the first branch (_ssl_endpoint_algorithm_) works. It mimics
MINA_2.1.X, using a PEER attribute.
--
This is an automated message from the Apache Git Service.
To respond
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1539456424
Also tested something: using the **sniHostNames** instead of doing a
_peer.getHostString()_, changes nothing...
--
This is an automated message from the Apache Git Service.
To respond to
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1539042180
Note that MINA 2.2.X don't have anymore a **PEER_ADDRESS** attribute, so we
have to go through the creation of a dedicated **SslFilter** class, which
extends the default **SslFilter** class.
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1539039335
On the test, we use a custom SSLFilter which sets the peer:
```
protected SSLEngine createEngine(IoSession session,
InetSocketAddress addr) {
//Add your SNI
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1539017831
FTR, here is a part of the logs I get when running the test with Java8:
```
javax.net.ssl|FINE|0F|CLIENT|2023-05-08 22:21:32.416
CEST|SSLExtensions.java:173|Ignore unavailable
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1538929098
Actually, all the handshakes are passing, which make the *shouldFailXXX*
tests failing.
Here is the modified test class for MINA 2.2.X:
```
package org.apache.mina.filter.ssl;
elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1538838101
Hmmm, the patch has been merged, but the tests are failing: the positive
tests are OK, but the negative ones aren't.
Also the TLS protocol is not anymore supported by Java 8, I had to
12 matches
Mail list logo
