[GitHub] [mina-sshd] lgoldstein commented on a diff in pull request #255: [SSHD-1303] AbstractClientChannel: use null stream for redirected stderr

[GitBox]

lgoldstein commented on code in PR #255:
URL: https://github.com/apache/mina-sshd/pull/255#discussion_r1001218334


##########
sshd-core/src/main/java/org/apache/sshd/client/channel/AbstractClientChannel.java:
##########
@@ -474,4 +494,48 @@ public Integer getExitStatus() {
     public String getExitSignal() {
         return exitSignalHolder.get();
     }
+
+    private enum NullIoInputStream implements IoInputStream {

Review Comment:
   Recommend making this a *public*  class in same package as `IoInputStream` 
or a member of it. Might come useful in the future.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org