lgoldstein commented on pull request #128:
URL: https://github.com/apache/mina-sshd/pull/128#issuecomment-623534996
Merged - thanks for (yet another) contribution - please close the PR
This is an automated message from the Ap
lgoldstein commented on pull request #128:
URL: https://github.com/apache/mina-sshd/pull/128#issuecomment-623471442
>> But I won't insist; if you prefer String, we can also drop this.
Great - I re-opened SSHD-709 and would rather do it a system wide change
>> feel free to chan
lgoldstein commented on pull request #128:
URL: https://github.com/apache/mina-sshd/pull/128#issuecomment-623136813
>> have the passphrase as a char[] instead of as a String
I am not sure why many think that it is more secure than a string - but
regardless, I would prefer to have it
lgoldstein commented on pull request #128:
URL: https://github.com/apache/mina-sshd/pull/128#issuecomment-623135921
>> Build fails because of some checkstyle rules, like having 6 private
methods but checkstyle allowing only 5. I'm not going to spend any time
fighting against checkstyle. Fe
lgoldstein commented on pull request #128:
URL: https://github.com/apache/mina-sshd/pull/128#issuecomment-623135705
There are quite a few public API(s) whose argument is defined as
`SecureByteArrayOutputStream` - I understand the rationale behind this class,
but I don't quite understand wh