tomaswolf commented on PR #362: URL: https://github.com/apache/mina-sshd/pull/362#issuecomment-1516999345
It would be extremely helpful to have meaningful commit messages. Just "More unix like" is _not_ helpful. If someone looks at this code a few months or years from now he or she will have no idea what this is about from the git history. There's not even any link to any issue, PR, or mailing list message. In this case I do not expect the commit message to give a full explanation, but brief descriptions should be possible. At the very least there must be a meaningful summary line so that `git log --oneline` gives a result that correctly summarizes the scope and topic. Absent a JIRA or Github issue, a link back to this PR might also helpful. Something like ``` RootedFileSystem: more Unix-like path handling Clean up and fix path checks to be more like in Unix. Add unit tests for Unix, OSX, and Windows via JimFs. See also [1]. [1] https://github.com/apache/mina-sshd/pull/362 ``` should be the minimum for the first commit. And likewise for the second commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
