Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Jeff Genender
Gents, Can we please change the topic of this email to a dev discussion... the [VOTE] in it is probably not appropriate since [VOTE] indicates a real vote. Thanks! Jeff On May 5, 2010, at 10:43 AM, Sai Pullabhotla wrote: > Okay, I see the fix for the dates, but they are still incorrect when >

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
Okay, I see the fix for the dates, but they are still incorrect when the client interprets its. Couple of things - I believe time should be on a 24 hour clock basis - so the format need to be changed to HH instead of hh. The listing is not compatible with UNIX style listing. So files older than 6

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Which dates ? I've fixed the "Jan 01 ..." thing if that's why you're referring to. But using filezilla, there are still things that we don't support, but i've been able to download directories recursively without problems. On Wed, May 5, 2010 at 17:49, Sai Pullabhotla wrote: > How about the dates

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
Oh, by the way, it works fine for me with just putting (sending) the path just once in the buffer. Tried with native sftp client on Ubuntu Linux as well as Putty's SFTP command line client, which is what FileZilla uses internally. I wonder why that does not work for you. Regards, Sai Pullabhotla

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
How about the dates on the files? Regards, Sai Pullabhotla On Wed, May 5, 2010 at 10:13 AM, Guillaume Nodet wrote: > Fixed, let me know if you find any other easily fixed issues. > > On Wed, May 5, 2010 at 16:41, Sai Pullabhotla > wrote: > >> I just noticed that the code checked in just repl

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Fixed, let me know if you find any other easily fixed issues. On Wed, May 5, 2010 at 16:41, Sai Pullabhotla wrote: > I just noticed that the code checked in just replaces "\" with "/". I > think for best compliance on all operating systems and file systems, > it should replace File.separatorChar

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Haven't seen any such system, but i can easily change that, it will be cleaner. On Wed, May 5, 2010 at 16:41, Sai Pullabhotla wrote: > I just noticed that the code checked in just replaces "\" with "/". I > think for best compliance on all operating systems and file systems, > it should replace F

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
I just noticed that the code checked in just replaces "\" with "/". I think for best compliance on all operating systems and file systems, it should replace File.separatorChar with "/". Not sure if there are any file systems that use a separator other than "/" and "\". Regards, Sai Pullabhotla

[CANCEL] [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Btw, I also cancel this vote. I'll upload a new candidate once everyone is happy ;-) On Wed, May 5, 2010 at 11:52, Guillaume Nodet wrote: > I've uploaded a RC for SSHD 0.4.0 at > https://repository.apache.org/content/repositories/orgapachemina-008/ > > The release notes are available at > h

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
I've committed the changes. Could you give a try ? On Wed, May 5, 2010 at 16:20, Guillaume Nodet wrote: > Removing the second string works with FileZilla but fails with the sftp > command line utility. > > > On Wed, May 5, 2010 at 16:13, Guillaume Nodet wrote: > >> Yeah, that's what I'm trying

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Removing the second string works with FileZilla but fails with the sftp command line utility. On Wed, May 5, 2010 at 16:13, Guillaume Nodet wrote: > Yeah, that's what I'm trying. > Let me try with removing the double name though. > > > On Wed, May 5, 2010 at 15:50, Sai Pullabhotla < > sai.pullab

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Yeah, that's what I'm trying. Let me try with removing the double name though. On Wed, May 5, 2010 at 15:50, Sai Pullabhotla wrote: > How about something like this: > >protected void sendAbsoluteName(int id, File file) throws IOException { >Buffer buffer = new Buffer(); >buffe

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
How about something like this: protected void sendAbsoluteName(int id, File file) throws IOException { Buffer buffer = new Buffer(); buffer.putByte((byte) SSH_FXP_NAME); buffer.putInt(id); buffer.putInt(1); String path = file.getPath(); if(File.s

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
I removed the second call to place the path in the buffer and seems to be working fine. Regards, Sai Pullabhotla

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
On Wed, May 5, 2010 at 15:33, Sai Pullabhotla wrote: > I think I got it to work a little better by changing the code in > SftpSubsystem.sendAbsoluteName to as follows: > > line 743: > >buffer.putString("/" + file.getPath().replace('\\', '/')); > > Let my try something like that. > In or

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
I think I got it to work a little better by changing the code in SftpSubsystem.sendAbsoluteName to as follows: line 743: buffer.putString("/" + file.getPath().replace('\\', '/')); In order to make it work correctly on *NIX systems, we might need a check to determine whether or not we sho

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
Okay, I got the fix and was able to see the directory listing using FileZilla. However, a couple of issues: 1. Date/time on the files returned by the list are incorrect. Looks like SSHD is always sending "Jan 01 00:00" for the date times. 2. I could not download or upload a file. Below is the trac

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Committed at rev 941273. Could you give it a try asap please ? I'll wait for your input before recutting the release. On Wed, May 5, 2010 at 15:02, Guillaume Nodet wrote: > Argh, I committed to my git repo and forgot to push the change. > > > On Wed, May 5, 2010 at 14:53, Sai Pullabhotla < > s

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Argh, I committed to my git repo and forgot to push the change. On Wed, May 5, 2010 at 14:53, Sai Pullabhotla wrote: > Is this SFTP fix checked into trunk or 0.4 tag? I do not see any > changes to the SVN. > > Regards, > Sai Pullabhotla > > > > > > On Wed, May 5, 2010 at 4:52 AM, Guillaume Nodet

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
Is this SFTP fix checked into trunk or 0.4 tag? I do not see any changes to the SVN. Regards, Sai Pullabhotla On Wed, May 5, 2010 at 4:52 AM, Guillaume Nodet wrote: > I've uploaded a RC for SSHD 0.4.0 at >  https://repository.apache.org/content/repositories/orgapachemina-008/ > > The release

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Emmanuel Lecharny
On 5/5/10 11:52 AM, Guillaume Nodet wrote: I've uploaded a RC for SSHD 0.4.0 at https://repository.apache.org/content/repositories/orgapachemina-008/ The release notes are available at https://cwiki.apache.org/SSHD/sshd-040.html Please review and vote. +1 -- Regards, Cordialement,

[VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
I've uploaded a RC for SSHD 0.4.0 at https://repository.apache.org/content/repositories/orgapachemina-008/ The release notes are available at https://cwiki.apache.org/SSHD/sshd-040.html Please review and vote. -- Cheers, Guillaume Nodet Blog: http://gnodet.blogspot.