Do we need all those @Override ?

2008-06-05 Thread Emmanuel Lecharny
i guys, while browsing MINA's code, I see @Override used everywhere. I know it can be helpful when overriding an existing method, but do you think we need to keep them ? wdyt ? -- -- cordialement, regards, Emmanuel Lécharny www.iktek.com directory.apache.org

Re: Do we need all those @Override ?

2008-06-05 Thread Mike Heath
Emmanuel Lecharny wrote: i guys, while browsing MINA's code, I see @Override used everywhere. I know it can be helpful when overriding an existing method, but do you think we need to keep them ? wdyt ? Yes. They're very helpful when refactoring. -Mike

Re: Do we need all those @Override ?

2008-06-05 Thread Jeff Genender
I would keep them because they really help when there are changes in super classes during a compile. Jeff Emmanuel Lecharny wrote: i guys, while browsing MINA's code, I see @Override used everywhere. I know it can be helpful when overriding an existing method, but do you think we need to

Re: Do we need all those @Override ?

2008-06-05 Thread Alex Karasulu
Hey Mike, Jeff, Not denying these claims but just curious. Can you guys educate me as to how it works, or helps in these cases. I never bothered to investigate this @Override tag. Thanks, Alex On Thu, Jun 5, 2008 at 6:28 PM, Jeff Genender [EMAIL PROTECTED] wrote: I would keep them because

Re: Do we need all those @Override ?

2008-06-05 Thread Emmanuel Lecharny
Jeff Genender wrote: I would keep them because they really help when there are changes in super classes during a compile. Ok, pretty clear reasons why we should keep them. Thanks Mike and Jeff ! -- -- cordialement, regards, Emmanuel Lécharny www.iktek.com directory.apache.org

Re: Do we need all those @Override ?

2008-06-05 Thread Emmanuel Lecharny
Alex Karasulu wrote: Hey Mike, Jeff, Not denying these claims but just curious. Can you guys educate me as to how it works, or helps in these cases. I never bothered to investigate this @Override tag. Basically (and I'm not a user of this tag), it's helpfull when you want to override a

Re: Do we need all those @Override ?

2008-06-05 Thread Jeff Genender
Yep...thats basically correct. Its a protection for if you change a base method. Normally w/o the annotation, you would orphan any subclasses by changing a super class signature. With the @Override, the compiler throws an error and says you are overriding a function that doesn't exist. Its