Re: mina-sshd git commit: [SSHD-805] Return a clone of the RFC8268 modulu number bytes to avoid inadvertent modification of the shared instance

2018-03-05 Thread elijah baley
> +public static byte[] readOakleyGroup(String name) { > The method was private, but making it public would need just a bit of javadoc explaining the input/output. I don't really see the need, since we have the getP16() and similar methods that are already public though... >> In general in a

Re: mina-sshd git commit: [SSHD-805] Return a clone of the RFC8268 modulu number bytes to avoid inadvertent modification of the shared instance

2018-03-05 Thread Guillaume Nodet
2018-03-05 14:18 GMT+01:00 : > Repository: mina-sshd > Updated Branches: > refs/heads/master f38e14df3 -> 2d43f6fe2 > > > [SSHD-805] Return a clone of the RFC8268 modulu number bytes to avoid > inadvertent modification of the shared instance > > > Project: http://git-wip-us.apache.org/repos/asf/