Hi Edouard,
just a few things about your last commit :
- int step = ((Integer) getSession().getAttribute(HANDSHAKE_STEP))
- .intValue();
- writeRequest(nextFilter, request, step);
+ writeRequest(nextFilter, request, ((Integer) getSession().getAttribute(
+ HANDSHAKE_STEP)).intValue());
When debugging, the second form is really painful, as you have to way to
get the integer value before calling the writeRequest method. Better
keep the two lines. The compiler will optimize the code anyway. And I
don't think we need to call the intValue() at all, java 5 will do some
autoBoxing.
- if (adr != null) {
+ if (adr != null && !adr.isUnresolved()) {
As we are following Sun rules :
http://java.sun.com/docs/codeconv/html/CodeConventions.doc9.html#331, so
this line should be
if ((adr != null) && !adr.isUnresolved())
As you can see, nothing serious.
Thanks !
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
