Re: Moving new nbxml in trunk

2010-05-05 Thread Bernd Fondermann
Niklas Gustavsson wrote: On Tue, May 4, 2010 at 5:34 PM, Bernd Fondermann bf_...@brainlounge.de wrote: BTW, that's common in real life XMPP streams: arbitrary whitespaces. Some clients send spaces as keep-alives. The problem struck me right after sending the last email (after which I had

[CANCEL] [VOTE] Release SSHD 0.4.0

2010-05-05 Thread Guillaume Nodet
Cancelling this vote. I've fixed the SFTP issue and will upload a new candidate asap. On Tue, May 4, 2010 at 15:19, Guillaume Nodet gno...@apache.org wrote: I've uploaded a RC for SSHD 0.4.0 at https://repository.apache.org/content/repositories/orgapachemina-003/ The release notes are

[VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
I've uploaded a RC for SSHD 0.4.0 at https://repository.apache.org/content/repositories/orgapachemina-008/ The release notes are available at https://cwiki.apache.org/SSHD/sshd-040.html Please review and vote. -- Cheers, Guillaume Nodet Blog:

Re: Moving new nbxml in trunk

2010-05-05 Thread Niklas Gustavsson
On Wed, May 5, 2010 at 10:53 AM, Bernd Fondermann bf_...@brainlounge.de wrote: Probably the test coverage is not sufficient. That's a given for any code :-) As noted, we surely need more integration tests. Did you actually try to connect a real client to a real server? Yes, I usually verify

[jira] Created: (VYSPER-202) Make Vysper report the correct version on Version-IQ request

2010-05-05 Thread Bernd Fondermann (JIRA)
Make Vysper report the correct version on Version-IQ request Key: VYSPER-202 URL: https://issues.apache.org/jira/browse/VYSPER-202 Project: VYSPER Issue Type: Bug

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Emmanuel Lecharny
On 5/5/10 11:52 AM, Guillaume Nodet wrote: I've uploaded a RC for SSHD 0.4.0 at https://repository.apache.org/content/repositories/orgapachemina-008/ The release notes are available at https://cwiki.apache.org/SSHD/sshd-040.html Please review and vote. +1 -- Regards,

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Committed at rev 941273. Could you give it a try asap please ? I'll wait for your input before recutting the release. On Wed, May 5, 2010 at 15:02, Guillaume Nodet gno...@gmail.com wrote: Argh, I committed to my git repo and forgot to push the change. On Wed, May 5, 2010 at 14:53, Sai

[jira] Commented: (VYSPER-202) Make Vysper report the correct version on Version-IQ request

2010-05-05 Thread Niklas Gustavsson (JIRA)
[ https://issues.apache.org/jira/browse/VYSPER-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12864329#action_12864329 ] Niklas Gustavsson commented on VYSPER-202: -- How about we read this value from a

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
I removed the second call to place the path in the buffer and seems to be working fine. Regards, Sai Pullabhotla

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
How about something like this: protected void sendAbsoluteName(int id, File file) throws IOException { Buffer buffer = new Buffer(); buffer.putByte((byte) SSH_FXP_NAME); buffer.putInt(id); buffer.putInt(1); String path = file.getPath();

[jira] Commented: (VYSPER-202) Make Vysper report the correct version on Version-IQ request

2010-05-05 Thread Bernd Fondermann (JIRA)
[ https://issues.apache.org/jira/browse/VYSPER-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12864335#action_12864335 ] Bernd Fondermann commented on VYSPER-202: - +1, that's exactly what i missed to ask.

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Yeah, that's what I'm trying. Let me try with removing the double name though. On Wed, May 5, 2010 at 15:50, Sai Pullabhotla sai.pullabho...@jmethods.comwrote: How about something like this: protected void sendAbsoluteName(int id, File file) throws IOException { Buffer buffer = new

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
I've committed the changes. Could you give a try ? On Wed, May 5, 2010 at 16:20, Guillaume Nodet gno...@gmail.com wrote: Removing the second string works with FileZilla but fails with the sftp command line utility. On Wed, May 5, 2010 at 16:13, Guillaume Nodet gno...@gmail.com wrote:

[CANCEL] [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Btw, I also cancel this vote. I'll upload a new candidate once everyone is happy ;-) On Wed, May 5, 2010 at 11:52, Guillaume Nodet gno...@gmail.com wrote: I've uploaded a RC for SSHD 0.4.0 at https://repository.apache.org/content/repositories/orgapachemina-008/ The release notes are

[jira] Commented: (VYSPER-202) Make Vysper report the correct version on Version-IQ request

2010-05-05 Thread Niklas Gustavsson (JIRA)
[ https://issues.apache.org/jira/browse/VYSPER-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12864346#action_12864346 ] Niklas Gustavsson commented on VYSPER-202: -- If you take care of reading for the

[jira] Commented: (VYSPER-202) Make Vysper report the correct version on Version-IQ request

2010-05-05 Thread Bernd Fondermann (JIRA)
[ https://issues.apache.org/jira/browse/VYSPER-202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12864348#action_12864348 ] Bernd Fondermann commented on VYSPER-202: - deal. Make Vysper report the correct

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
I just noticed that the code checked in just replaces \ with /. I think for best compliance on all operating systems and file systems, it should replace File.separatorChar with /. Not sure if there are any file systems that use a separator other than / and \. Regards, Sai Pullabhotla On Wed,

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Haven't seen any such system, but i can easily change that, it will be cleaner. On Wed, May 5, 2010 at 16:41, Sai Pullabhotla sai.pullabho...@jmethods.comwrote: I just noticed that the code checked in just replaces \ with /. I think for best compliance on all operating systems and file

Re: Moving new nbxml in trunk

2010-05-05 Thread Niklas Gustavsson
On Wed, May 5, 2010 at 4:25 PM, Bernd Fondermann bf_...@brainlounge.de wrote: Bernd Fondermann wrote: Niklas Gustavsson wrote: :-D Anyways, could you please verify the problem you had with MUC and default namespaces now? Yes, I can verify that the problem has come back. (Is that the right

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
How about the dates on the files? Regards, Sai Pullabhotla On Wed, May 5, 2010 at 10:13 AM, Guillaume Nodet gno...@gmail.com wrote: Fixed, let me know if you find any other easily fixed issues. On Wed, May 5, 2010 at 16:41, Sai Pullabhotla sai.pullabho...@jmethods.comwrote: I just

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
Oh, by the way, it works fine for me with just putting (sending) the path just once in the buffer. Tried with native sftp client on Ubuntu Linux as well as Putty's SFTP command line client, which is what FileZilla uses internally. I wonder why that does not work for you. Regards, Sai Pullabhotla

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Guillaume Nodet
Which dates ? I've fixed the Jan 01 ... thing if that's why you're referring to. But using filezilla, there are still things that we don't support, but i've been able to download directories recursively without problems. On Wed, May 5, 2010 at 17:49, Sai Pullabhotla

Re: [VOTE] Release SSHD 0.4.0 (2nd try)

2010-05-05 Thread Sai Pullabhotla
Okay, I see the fix for the dates, but they are still incorrect when the client interprets its. Couple of things - I believe time should be on a 24 hour clock basis - so the format need to be changed to HH instead of hh. The listing is not compatible with UNIX style listing. So files older than

SFTP problems

2010-05-05 Thread Guillaume Nodet
Thanks for the pointer. The SFTP subsystem is now using that code. Any more issues ? On Wed, May 5, 2010 at 18:43, Sai Pullabhotla sai.pullabho...@jmethods.comwrote: Okay, I see the fix for the dates, but they are still incorrect when the client interprets its. Couple of things - I believe