[jira] [Commented] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506428#comment-17506428
]
Gary D. Gregory commented on FTPSERVER-506:
---
Hi [~elecharny]
Yes, flipping the committer bit would simplify things.
> Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
>
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina-ftpserver] garydgregory commented on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
garydgregory commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1067086711
> Hi @garydgregor,
>
> sure enough, but I reversed the {{SslConfiguration}} interface to what it
was in 1.1.2, so I can't seer how 1.1.4v breaks ther binary compatibility.
>
> Sorry if that sounds dumb, I'm a bit overloaded atm...
Hi @elecharny
1.1.4 is ok 1.2.0 is broken, please see my explanation in Jira.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506323#comment-17506323
]
Emmanuel Lécharny commented on FTPSERVER-506:
-
[~ggregory]Is making you a MINA committer an option ? That would probably make
things easier...
> Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
>
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506322#comment-17506322
]
Emmanuel Lécharny commented on FTPSERVER-506:
-
[~ggregory] yes, please. I have had a look at it last week, but haven't move
forward for lack of time.
> Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
>
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506314#comment-17506314
]
Gary D. Gregory commented on FTPSERVER-506:
---
Hi [~elecharny]
Do you want a PR to add JApiCmp to the build?
Also, a PR to enable GitHub Actions builds?
> Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
>
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506312#comment-17506312
]
Emmanuel Lécharny commented on FTPSERVER-506:
-
Ok get it now :-)
Sorry, the last days have been quite difficult to deal with... I was only able
to push the releases and update the site yesterday evening around midnight, and
today is quite worse...
Anyway, we are probably good to go for a new release of both branches because
of some critical issues which has been found and fixed yesterday...
Thanks for the heads up !
> Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
>
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Updated] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated FTPSERVER-506:
--
Affects Version/s: (was: 1.1.4)
> Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
>
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506300#comment-17506300
]
Gary D. Gregory commented on FTPSERVER-506:
---
Yes, indeed, you are missing something ;)
It is good that 1.1.4 is back to being compatible with 1.1.2 :)
1.2.0 now breaks binary compatibility, it is implemented in exactly the
opposite of what it should be:
* The method "String getEnabledProtocol()" existed in 1.1.2 and can stay as is.
* If you add a new method to an existing interface and it's not a default
method, you break both source and binary compatibility.
* In 1.2.0, the EXISTING method "String getEnabledProtocol()" was changed to a
default method (not necesssary for this ticket) and a NEW method "String[]
getEnabledProtocols();" was added but NOT as a default method.
* The PR [https://github.com/apache/mina-ftpserver/pull/12] shows how to get
your cake and eat it too: Add a new method to an interface AND keep the binary
compatibility.
For reference:
* 1.1.2
[https://github.com/apache/mina-ftpserver/blob/ftpserver-parent-1.1.2/core/src/main/java/org/apache/ftpserver/ssl/SslConfiguration.java]
* 1.2.0
[https://github.com/apache/mina-ftpserver/blob/1.2.0/core/src/main/java/org/apache/ftpserver/ssl/SslConfiguration.java]
It is trivial to avoid these issues by using Maven plugins for JApiCmp or
RevApi, see Apache Commons for example usage of JApiCmp.
> Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
>
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.1.4, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
[GitHub] [mina-ftpserver] elecharny commented on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
elecharny commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066965809
Hi @garydgregor,
sure enough, but I reversed the {{SslConfiguration}} interface to what it
was in 1.1.2, so I can't seer how 1.1.4v breaks ther binary compatibility.
Sorry if that sounds dumb, I'm a bit overloaded atm...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina-ftpserver] garydgregory edited a comment on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
garydgregory edited a comment on pull request #12: URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066906102 Hello @elecharny , The code you quote is completely irrelevant. What matters is that a public interface breaks binary compatibility. Since user can implement the public interface, those implementations no longer complie! The fix is simple and provides both binary and source compatibility. I've seen this in Apache Commons Net and Apache Commons VFS. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina-ftpserver] garydgregory commented on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
garydgregory commented on pull request #12: URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066906102 Hello @elecharny , The code you quote is completely irrelevant. What matters is that a public interface breaks binary compatibility. Since user can implement the public interface, those implementations no longer complie! The fix is simple and provides both binary and source compatibility. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506266#comment-17506266
]
Emmanuel Lécharny commented on FTPSERVER-506:
-
Hi Gary,
The 1.1.4 {{SslConfiguration}} interface has been reverted to what it was in
1.1.2. The {{DefaultSslConfiguration}} implementation hasn't been changed
except that it now defaults to {{TLSv1.2}} instead of {{TLS}}.
To me, 1.1.4 should be binary compatible with 1.1.2.
Am I missing something ?
> Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
>
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.1.4, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina-ftpserver] elecharny commented on pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
elecharny commented on pull request #12:
URL: https://github.com/apache/mina-ftpserver/pull/12#issuecomment-1066857244
Hi Gary,
I'm nor sure this is a needed change. The implementation already returns an
array containing "TLSv1.2":
```
public class DefaultSslConfiguration implements SslConfiguration {
...
private String[] enabledProtocols = new String[] {"TLSv1.2"};
...
/**
* @see SslConfiguration#getEnabledProtocols()
*/
public String[] getEnabledProtocols() {
return enabledProtocols;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Comment Edited] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506236#comment-17506236
]
Gary D. Gregory edited comment on FTPSERVER-506 at 3/14/22, 1:40 PM:
-
Hi All:
Version 1.1.4 and 1.2.0 still break binary compatibility: The method
{{SslConfiguration#getEnabledProtocols()}} must be a {{default}} method, it
still is not. It can be implemented by simply creating an array of one element
where the one element is returned by {{getEnabledProtocol()}}. Here is a PR for
the 1.2.X branch: https://github.com/apache/mina-ftpserver/pull/12
was (Author: garydgregory):
Hi All:
Version 1.2.0 still breaks binary compatibility: The method
{{SslConfiguration#getEnabledProtocols()}} must be a {{default}} method, it
still is not. It can be implemented by simply creating an array of one element
where the one element is returned by {{getEnabledProtocol()}}. Here is a PR for
the 1.2.X branch: https://github.com/apache/mina-ftpserver/pull/12
> Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
>
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.1.4, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Updated] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated FTPSERVER-506:
--
Affects Version/s: 1.1.4
Summary: Binary compatibility is broken in ftpserver-core since
1.1.3, 1.2.0 vs 1.1.2 (was: Binary compatibility is broken in ftpserver-core
1.1.3, 1.2.0 vs 1.1.2)
> Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2
>
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.1.4, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Comment Edited] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506236#comment-17506236
]
Gary D. Gregory edited comment on FTPSERVER-506 at 3/14/22, 1:38 PM:
-
Hi All:
Version 1.2.0 still breaks binary compatibility: The method
{{SslConfiguration#getEnabledProtocols()}} must be a {{default}} method, it
still is not. It can be implemented by simply creating an array of one element
where the one element is returned by {{getEnabledProtocol()}}. Here is a PR for
the 1.2.X branch: https://github.com/apache/mina-ftpserver/pull/12
was (Author: garydgregory):
Hi All:
Version 1.2.0 still breaks binary compatibility: The method
{{SslConfiguration#getEnabledProtocols()}} must be a {{default}} method, it
still is not. It can be implemented by simply creating an array of one element
where the one element is returned by {{getEnabledProtocol()}}
> Binary compatibility is broken in ftpserver-core 1.1.3, 1.2.0 vs 1.1.2
> --
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina-ftpserver] garydgregory opened a new pull request #12: [FTPSERVER-506] Binary compatibility is broken in ftpserver-core 1.1.3,
garydgregory opened a new pull request #12: URL: https://github.com/apache/mina-ftpserver/pull/12 1.2.0 vs 1.1.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Updated] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated FTPSERVER-506:
--
Affects Version/s: 1.2.0
1.1.3
> Binary compatibility is broken in ftpserver-core 1.1.3, 1.2.0 vs 1.1.2
> --
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Affects Versions: 1.1.3, 1.2.0
>Reporter: Gary D. Gregory
>Priority: Major
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Commented] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17506236#comment-17506236
]
Gary D. Gregory commented on FTPSERVER-506:
---
Hi All:
Version 1.2.0 still breaks binary compatibility: The method
{{SslConfiguration#getEnabledProtocols()}} must be a {{default}} method, it
still is not. It can be implemented by simply creating an array of one element
where the one element is returned by {{getEnabledProtocol()}}
> Binary compatibility is broken in ftpserver-core 1.1.3, 1.2.0 vs 1.1.2
> --
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Reporter: Gary D. Gregory
>Priority: Major
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
[jira] [Updated] (FTPSERVER-506) Binary compatibility is broken in ftpserver-core 1.1.3, 1.2.0 vs 1.1.2
[
https://issues.apache.org/jira/browse/FTPSERVER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gary D. Gregory updated FTPSERVER-506:
--
Summary: Binary compatibility is broken in ftpserver-core 1.1.3, 1.2.0 vs
1.1.2 (was: Binary compatibility is broken in ftpserver-core 1.1.3 vs 1.1.2)
> Binary compatibility is broken in ftpserver-core 1.1.3, 1.2.0 vs 1.1.2
> --
>
> Key: FTPSERVER-506
> URL: https://issues.apache.org/jira/browse/FTPSERVER-506
> Project: FtpServer
> Issue Type: Bug
> Components: Core
>Reporter: Gary D. Gregory
>Priority: Major
>
> Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we
> get compile errors:
> {noformat}
> [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @
> commons-net ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 63 source files to
> /home/runner/work/commons-net/commons-net/target/test-classes
> [INFO] -
> Error: COMPILATION ERROR :
> [INFO] -
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> [INFO] 2 errors
> [INFO] -
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 20.310 s
> [INFO] Finished at: 2022-03-04T02:17:14Z
> [INFO]
>
> Error: Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile
> (default-testCompile) on project commons-net: Compilation failure:
> Compilation failure:
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8]
> org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract
> and does not override abstract method getEnabledProtocols() in
> org.apache.ftpserver.ssl.SslConfiguration
> Error:
> /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5]
> method does not override or implement a method from a supertype
> Error: -> [Help 1]
> Error:
> Error: To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> Error: Re-run Maven using the -X switch to enable full debug logging.
> Error:
> Error: For more information about the errors and possible solutions, please
> read the following articles:
> Error: [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> Error: Process completed with exit code 1.
> {noformat}
> See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429:
> https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true
> Please don't break BC! That should be rule #1 IMO.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org
