[GitHub] [mina-sshd] tomaswolf opened a new pull request, #303: GH-298: Start service in AbstractServerSession

[GitBox]

tomaswolf opened a new pull request, #303:
URL: https://github.com/apache/mina-sshd/pull/303

   Services need to be started. In particular, the connection service starts 
its heartbeat, if configured, when started. It was already noticed in commit 
e74e2041 that the server-side did not start services, but at that time the 
effect was not recognized because tests were too unstable back then. A test for 
server-side heartbeats was also missing.
   
   Fixes #298.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

[GitHub] [mina-sshd] tomaswolf commented on issue #298: Server side heartbeat not working

[GitBox]

tomaswolf commented on issue #298:
URL: https://github.com/apache/mina-sshd/issues/298#issuecomment-1365428807

   Indeed; you're right. It looks like this never worked, and was not caught 
because there was no test for server-side heartbeats.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org