[GitHub] [mina-sshd] Ingo13F commented on issue #309: Allow for the use of HTTP or SOCKS proxies

2023-01-11 Thread GitBox


Ingo13F commented on issue #309:
URL: https://github.com/apache/mina-sshd/issues/309#issuecomment-1378550899

   Ah, yes sure. That's more of a wording issue then. I concur: The code from 
jGit for proxy handling should somehow make its way into MINA SSHD and all is 
good. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org



[GitHub] [mina-sshd] Ingo13F commented on issue #309: Allow for the use of HTTP or SOCKS proxies

2023-01-11 Thread GitBox


Ingo13F commented on issue #309:
URL: https://github.com/apache/mina-sshd/issues/309#issuecomment-1378490095

   If I see this correctly this would be accomplished by subclassing SshClient 
and overwriting the connect method as well as implementing the ProxyConnectors.
   In my opinion, this is not code that the user of a library should write. 
Especially subclassing the client implementation to change its behavior doesn't 
sound right to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org