[GitHub] [mina] jon-valliere commented on pull request #37: write direct buffer only once in APR
jon-valliere commented on PR #37: URL: https://github.com/apache/mina/pull/37#issuecomment-1374624355 I take it back, since the `position()` is used when writing, it makes sense not to move the pointer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
[GitHub] [mina] jon-valliere commented on pull request #37: write direct buffer only once in APR
jon-valliere commented on PR #37: URL: https://github.com/apache/mina/pull/37#issuecomment-1374621868 I spent the last 10 minutes trying to find the source code for `sendb`. The only thing I can find is the JNI definition for the function. Usually when a function takes in a `ByteBuffer` as an argument, it always moves the pointer forward as data is either read or written. Can you point me to the code which shows that is not happening? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
