[
https://issues.apache.org/jira/browse/FTPSERVER-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12649511#action_12649511
]
Sai Pullabhotla commented on FTPSERVER-222:
-------------------------------------------
Sorry, I did not even look at the test packages. Did not configure
them as source folders in my eclipse. I left the following TODO's in
the DefaultFtplet class for you to consider:
1. TODO remove unncessary throws clause from onXXXStart and onXXXEnd methods.
2. TODO consider splitting the onLogin method into two - onLoginStart
and onLoginEnd, fire these two methods on the PASS command.
I think we can ignore #1, but #2 makes sense so these methods are
consistent with the rest.
Regarding test cases, I'm not sure what you are looking, if you could
provide me some details, I will see what I can do.
Sai Pullabhotla
Phone: (402) 408-5753
Fax: (402) 408-6861
www.jMethods.com
On Thu, Nov 20, 2008 at 3:56 PM, Niklas Gustavsson (JIRA)
> Enhance the Ftplet.afterCommand method to include the result of the command
> that was executed
> ---------------------------------------------------------------------------------------------
>
> Key: FTPSERVER-222
> URL: https://issues.apache.org/jira/browse/FTPSERVER-222
> Project: FtpServer
> Issue Type: Improvement
> Components: Ftplets
> Reporter: Sai Pullabhotla
> Assignee: Niklas Gustavsson
> Fix For: 1.0-M4
>
> Attachments: ftpserver_patch.txt
>
>
> The aftterCommand method in the Ftplet interface is a great way to listen for
> events from the FtpServer, however, this call back method does not tell
> anything about the result of the command execution.
> Change the signature of this method to include the result of the command.
> More information on this is available at http://www.mail-archive.com/[EMAIL
> PROTECTED]/msg00407.html.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
