Re: FTP Server - MD5 and MMD5 command replies when a file name or path contains spaces

2010-01-29 Thread Niklas Gustavsson
On Thu, Jan 28, 2010 at 5:17 PM, Sai Pullabhotla wrote: > Well, I guess I kind of screwed it up by not updating the test case. I > did see some emails from Hudson that the builds have failed. I checked > in the fix for the test cases. Hope it is all good now. That's what we got Hudson for :-) I'v

Re: FTP Server - MD5 and MMD5 command replies when a file name or path contains spaces

2010-01-28 Thread Sai Pullabhotla
Well, I guess I kind of screwed it up by not updating the test case. I did see some emails from Hudson that the builds have failed. I checked in the fix for the test cases. Hope it is all good now. Regards, Sai Pullabhotla On Thu, Jan 21, 2010 at 8:45 AM, Niklas Gustavsson wrote: > On Thu, J

Re: FTP Server - MD5 and MMD5 command replies when a file name or path contains spaces

2010-01-21 Thread Niklas Gustavsson
On Thu, Jan 21, 2010 at 3:36 PM, Sai Pullabhotla wrote: > I'm sure you can fix it in case if I screw > something up :). I don't think you will, but sure :-) /niklas

Re: FTP Server - MD5 and MMD5 command replies when a file name or path contains spaces

2010-01-21 Thread Sai Pullabhotla
I will give it a shot. I always used the Merge option in Eclipse. But, I'm a little hesitant to do it on someone else's repository. I will give it a shot anyway. I'm sure you can fix it in case if I screw something up :). Regards, Sai Pullabhotla On Thu, Jan 21, 2010 at 8:15 AM, Niklas Gustav

Re: FTP Server - MD5 and MMD5 command replies when a file name or path contains spaces

2010-01-21 Thread Niklas Gustavsson
On Thu, Jan 21, 2010 at 3:02 PM, Sai Pullabhotla wrote: > Sure, not a problem. Is it okay if I check it into trunk? Would you be > able to merge it into appropriate branches? Or would you rather prefer > patch attached to the JIRA issue? Give it a try to get it into both branches. Here's how I do

Re: FTP Server - MD5 and MMD5 command replies when a file name or path contains spaces

2010-01-21 Thread Sai Pullabhotla
Sure, not a problem. Is it okay if I check it into trunk? Would you be able to merge it into appropriate branches? Or would you rather prefer patch attached to the JIRA issue? Regards, Sai Pullabhotla On Thu, Jan 21, 2010 at 2:53 AM, Niklas Gustavsson wrote: > On Wed, Jan 20, 2010 at 4:16 PM

Re: FTP Server - MD5 and MMD5 command replies when a file name or path contains spaces

2010-01-21 Thread Niklas Gustavsson
On Wed, Jan 20, 2010 at 4:16 PM, Sai Pullabhotla wrote: > I wonder if the file name in the 251 reply should be enclosed in > double quotes. This is based on the examples in the RFC. The RFC does > not explicitly say anything about double quotes. I agree. Could you open a JIRA for this? And feel f

FTP Server - MD5 and MMD5 command replies when a file name or path contains spaces

2010-01-20 Thread Sai Pullabhotla
It appears that we may have an issue with the replies we send for MD5 and MMD5 commands when the file name or path has one or more white spaces. According to the RFC posted on the FtpServer web site (http://mina.apache.org/ftpserver/draft-twine-ftpmd5-00.html), I think the reply should enclose the