Re: git commit: fixed sonar violations

2013-07-25 Thread Jeff MAURY
There is still one line of commented code in CoapDecoder Jeff — Sent from Mailbox for iPhone On Thu, Jul 25, 2013 at 3:00 PM, null apali...@apache.org wrote: Updated Branches: refs/heads/trunk 51dd5213d - 52009f32f fixed sonar violations Project:

Re: git commit: fixed sonar violations

2013-07-25 Thread Ashish
Thanks Jeff ! There are more commented line. Need to touch-base with Julien to check if some of them need to be enabled for debugging. Some of them can be worthy debug statements. On Thu, Jul 25, 2013 at 8:07 PM, Jeff MAURY jeffma...@gmail.com wrote: There is still one line of commented code

Re: git commit: fixed sonar violations

2013-07-25 Thread Julien Vermillard
hmm it's some decoder debug statement commented during performance testing. I think we can remove them since the code is working and I don't think we need to enable them again. -- Julien Vermillard http://people.apache.org/~jvermillard/ On Thu, Jul 25, 2013 at 4:41 PM, Ashish

Re: git commit: fixed sonar violations

2013-07-25 Thread Ashish
Ok, got it. The following are commented and might be useful while debugging decoding LOG.debug(version : {}, version); LOG.debug(type : {}, type); LOG.debug(code : {}, code); LOG.debug(id : {}, id); If you feel they are not needed, shall remove them. On Thu, Jul 25, 2013 at 8:22 PM, Julien