Re: Re : svn commit: r766111 - /mina/trunk/core/src/main/java/org/apache/mina/filter/logging/LoggingFilter.java

2009-04-20 Thread Julien Vermillard
://tedorg.free.fr/en/main.php - Message d'origine De : Niklas Gustavsson nik...@protocol7.com À : dev@mina.apache.org Envoyé le : Vendredi, 17 Avril 2009, 21h04mn 33s Objet : Re: svn commit: r766111 - /mina/trunk/core/src/main/java/org/apache/mina/filter/logging/LoggingFilter.java

Re: Re : svn commit: r766111 - /mina/trunk/core/src/main/java/org/apache/mina/filter/logging/LoggingFilter.java

2009-04-20 Thread Niklas Gustavsson
On Mon, Apr 20, 2009 at 9:00 AM, Julien Vermillard jvermill...@archean.fr wrote: Agreeing with Edouard it's more like a bug fix, but if it's a problem we can do the deprecation move. It certainly somewhat academic and I don't think there at lot of users of these methods. I would be fine with

Re: Re : svn commit: r766111 - /mina/trunk/core/src/main/java/org/apache/mina/filter/logging/LoggingFilter.java

2009-04-19 Thread Ashish
I would favor Ashish proposal - ie, deprecating the old method, but keep the fix too. It's Sai proposal :-) Hey, are you back from your vacation??? - ashish

Re: svn commit: r766111 - /mina/trunk/core/src/main/java/org/apache/mina/filter/logging/LoggingFilter.java

2009-04-17 Thread Niklas Gustavsson
On Fri, Apr 17, 2009 at 8:24 PM, edeolive...@apache.org wrote: -    public LogLevel getExceptionCaughtLoglevel() { +    public LogLevel getExceptionCaughtLogLevel() { This breaks the API, something we promised not to do after M4. Are we still okay with this change? /niklas

Re: svn commit: r766111 - /mina/trunk/core/src/main/java/org/apache/mina/filter/logging/LoggingFilter.java

2009-04-17 Thread Sai Pullabhotla
Can we deprecate the old method and add the new one to keep up the promise? Sai Pullabhotla Phone: (402) 408-5753 Fax: (402) 408-6861 www.jMethods.com On Fri, Apr 17, 2009 at 2:04 PM, Niklas Gustavsson nik...@protocol7.comwrote: On Fri, Apr 17, 2009 at 8:24 PM, edeolive...@apache.org wrote:

Re : svn commit: r766111 - /mina/trunk/core/src/main/java/org/apache/mina/filter/logging/LoggingFilter.java

2009-04-17 Thread Edouard De Oliveira
/trunk/core/src/main/java/org/apache/mina/filter/logging/LoggingFilter.java On Fri, Apr 17, 2009 at 8:24 PM,  edeolive...@apache.org wrote: -    public LogLevel getExceptionCaughtLoglevel() { +    public LogLevel getExceptionCaughtLogLevel() { This breaks the API, something we promised not to do

Re: Re : svn commit: r766111 - /mina/trunk/core/src/main/java/org/apache/mina/filter/logging/LoggingFilter.java

2009-04-17 Thread Emmanuel Lecharny
- Message d'origine De : Niklas Gustavsson nik...@protocol7.com À : dev@mina.apache.org Envoyé le : Vendredi, 17 Avril 2009, 21h04mn 33s Objet : Re: svn commit: r766111 - /mina/trunk/core/src/main/java/org/apache/mina/filter/logging/LoggingFilter.java On Fri, Apr 17, 2009 at 8:24 PM