Re: LabelBot New Design in Production

2018-11-08 Thread Hagay Lupesko
Thanks for this useful contribution Harsh! +1 to an updated issue template and +1 to Marco's idea as well Anything that helps the community triage and make it easier for folks that file issues is greatly appreciated Hagay On Thu, Nov 8, 2018 at 4:05 PM Marco de Abreu wrote: > Great job,

Re: MKLDNN dynamically linked

2018-11-08 Thread Hagay Lupesko
+1 Kellen made a good call about watching out for the license. Not an issue for MKL-DNN though, which I believe has an Apache 2 license. On Thu, Nov 8, 2018 at 3:51 PM Zhao, Patric wrote: > +1 for static link :) > > Feel free to let us know if anything we can help. > > > -Original

Re: Up-streaming MXNet HIP Port

2018-11-08 Thread Karnam, Srihari
Dear team, Please review this and feedback: https://cwiki.apache.org/confluence/display/MXNET/Upstreaming+of+Mxnet+HIP+port Regards From: Pedro Larroy Sent: Wednesday, October 24, 2018 5:38 PM To: dev@mxnet.incubator.apache.org Subject: Re: Up-streaming

Re: Map OpenCV assertions to mxnet::Error

2018-11-08 Thread Anirudh
Hi Lieven, Thanks a lot for this proposal and welcome to the community ! Apologies for the delay in the reply. I think it is a nice proposal and opencv exceptions are good point to start from. Would you be able to add the proposal to a new cwiki or add the proposal to the existing cwiki that you

Re: Run Sphinx checks on MXNet CI

2018-11-08 Thread Aaron Markham
Hi Anirudh, Once the existing errors in docs building are cleaned up, I'm all for having CI bubble up a build break when docs are broken by a PR. That way we're keeping things up to date and not letting a minor bug turn into a serious issue for the entire API documentation. One break causes a

Re: LabelBot New Design in Production

2018-11-08 Thread Marco de Abreu
Great job, Harsh! That's a very good idea, Naveen. Harsh, Qing and I have been thinking about the bot "welcoming" the user when they create an issue or pull request by creating a comment as soon as the thread gets created. This message could contain basic instructions like these commands,

Re: LabelBot New Design in Production

2018-11-08 Thread Naveen Swamy
Great job!, this is very helpful to triage issues!, users when creating a new Issue could themselves tag the issues. May be we should add that to the issue template? On Thu, Nov 8, 2018 at 3:54 PM Harsh Patel wrote: > Hey all, > The upgraded label bot has been pushed into production. Current >

LabelBot New Design in Production

2018-11-08 Thread Harsh Patel
Hey all, The upgraded label bot has been pushed into production. Current functionality includes add, delete, and update. (i.e. @mxnet-label-bot add ['label'] @mxnet-label-bot remove ['label'] @mxnet-label-bot update ['label']) Users should feel free to leave suggestions and any potential issues.

RE: MKLDNN dynamically linked

2018-11-08 Thread Zhao, Patric
+1 for static link :) Feel free to let us know if anything we can help. > -Original Message- > From: kellen sunderland [mailto:kellen.sunderl...@gmail.com] > Sent: Friday, November 9, 2018 7:30 AM > To: dev@mxnet.incubator.apache.org > Cc: d...@mxnet.apache.org > Subject: Re: MKLDNN

Catch divide-by-zero floating number exception in backend

2018-11-08 Thread Lin Yuan
Dear MXNet Community, I recently found the NaN errors sometimes could be due to some divide-by-zero float number bugs in engine backend. However, by default, such an exception will not be thrown. I added a signal trap to catch this error (https://github.com/apache/incubator-mxnet/pull/13190) and

Re: MKLDNN dynamically linked

2018-11-08 Thread kellen sunderland
I think we should bias towards static linking. It should make using mxnet easier in a lot of cases for users. As long as the license permits static linking (i.e. is non-gpl) I'd +1 static linking for portability and ease of use. The only caveat would be in cases where the package size would

Re: MKLDNN dynamically linked

2018-11-08 Thread Sheng Zha
+1. Ideally, MKLDNN can be statically linked. mxnet-mkl relies on Make for building it so help is wanted on mxnet. -sz On 2018/11/08 21:28:50, Alex Zai wrote: > Currently in mxnet-mkl the libmxnet.so is dynamically linked to to > libmkldnn.so.0. This is known to cause some issues if the wrong

Re: [VOTE] Separating PMC and Committership

2018-11-08 Thread Qing Lan
+1 (non-binding) On 11/8/18, 2:41 PM, "kellen sunderland" wrote: +1 (non-binding) On Thu, Nov 8, 2018 at 10:37 AM Thomas DELTEIL wrote: > +1 (non-binding) > > Le jeu. 8 nov. 2018 à 10:04, Carin Meier a écrit : > > > Reminder - Vote ends tomorrow-

Re: [VOTE] Separating PMC and Committership

2018-11-08 Thread kellen sunderland
+1 (non-binding) On Thu, Nov 8, 2018 at 10:37 AM Thomas DELTEIL wrote: > +1 (non-binding) > > Le jeu. 8 nov. 2018 à 10:04, Carin Meier a écrit : > > > Reminder - Vote ends tomorrow- Friday Nov 9th at 6:00 am EST > > > > On Mon, Nov 5, 2018 at 11:29 AM Carin Meier > wrote: > > > > > This is a

MKLDNN dynamically linked

2018-11-08 Thread Alex Zai
Currently in mxnet-mkl the libmxnet.so is dynamically linked to to libmkldnn.so.0. This is known to cause some issues if the wrong version of mkldnn is linked. Can we static link this file instead? Alex

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-08 Thread Naveen Swamy
Anton, I don't think we need to add the Mac OS tests for 1.3.1 branch since travis CI is timing out and creates blockers, it also did not exist for v1.3.0. On Thu, Nov 8, 2018 at 10:04 AM Anton Chernov wrote: > A PR to fix the tests: > > Remove test for non existing index copy operator

Run Sphinx checks on MXNet CI

2018-11-08 Thread Anirudh Acharya
Hi, Recently there was a barrage of issues related to documentation that was raised here - https://github.com/apache/incubator-mxnet/issues/created_by/aaronmarkham All the issues are related to Sphinx errors and warnings. These errors often lead to broken documentation. Ideally such errors should

Re: [VOTE] Separating PMC and Committership

2018-11-08 Thread Thomas DELTEIL
+1 (non-binding) Le jeu. 8 nov. 2018 à 10:04, Carin Meier a écrit : > Reminder - Vote ends tomorrow- Friday Nov 9th at 6:00 am EST > > On Mon, Nov 5, 2018 at 11:29 AM Carin Meier wrote: > > > This is a procedural vote on whether to separate the committer and PPMC > > levels in the project.

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-08 Thread Anton Chernov
Thank you everyone for your support and suggestions. All proposed PR's have been merged. We will tag the release candidate and start the vote on Friday, the 9th of November 2018. Unfortunately after the merges the tests started to fail:

Re: Requesting access for SLACK

2018-11-08 Thread Hagay Lupesko
Invite sent Gaurav! On Wed, Nov 7, 2018 at 1:33 PM Gaurav Gireesh wrote: > Hi! > I would like to request access to the Slack channel for MXNet. > > Thanks and regards, > Gaurav Gireesh >

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-08 Thread Anton Chernov
A PR to fix the tests: Remove test for non existing index copy operator (v1.3.x) https://github.com/apache/incubator-mxnet/pull/13180 Best Anton чт, 8 нояб. 2018 г. в 10:05, Anton Chernov : > An addition has been made to include MacOS tests for the v1.3.x branch: > > [MXNET-908] Enable

Re: [VOTE] Separating PMC and Committership

2018-11-08 Thread Carin Meier
Reminder - Vote ends tomorrow- Friday Nov 9th at 6:00 am EST On Mon, Nov 5, 2018 at 11:29 AM Carin Meier wrote: > This is a procedural vote on whether to separate the committer and PPMC > levels in the project. The current state is that a user is considered as > both a committer and a PPMC

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-08 Thread Anton Chernov
An addition has been made to include MacOS tests for the v1.3.x branch: [MXNET-908] Enable minimal OSX Travis build (v1.3.x) https://github.com/apache/incubator-mxnet/pull/13179 It includes following PR's for master: [MXNET-908] Enable minimal OSX Travis build