Re: [Announce] Runtime feature detection

2019-02-12 Thread Lin Yuan
Thanks, Pedro for contributing this long awaiting feature. I can immediately use it for Horovod project now. Bravo! Lin On Tue, Feb 12, 2019 at 2:42 AM Pedro Larroy wrote: > An update on this topic, Sheng just merged the refinements to the > feature detection so it's now a single API call. (

Re: [Announce] Runtime feature detection

2019-02-12 Thread Pedro Larroy
An update on this topic, Sheng just merged the refinements to the feature detection so it's now a single API call. ( https://github.com/apache/incubator-mxnet/pull/13964 ). Thank you Sheng for the reviews. Please use this functionality to check for capabilities of MXNet at runtime such as Cuda,

Re: [Announce] Runtime feature detection

2019-01-25 Thread Sheng Zha
Hi Pedro, Happy to help, though I was waiting for PR comments to be addressed. Currently the PR is close to complete, with some open comments to be resolved. -sz > On Jan 25, 2019, at 9:27 AM, Pedro Larroy > wrote: > > That's Great! There's a PR that we should merge first which >

Re: [Announce] Runtime feature detection

2019-01-25 Thread Pedro Larroy
That's Great! There's a PR that we should merge first which internalizes the enum inside the library as per Sheng's suggestion. https://github.com/apache/incubator-mxnet/pull/13964 @Sheng could we merge the PR? so we can build on top of this feature? It's badly needed for tests suites etc.

Re: [Announce] Runtime feature detection

2019-01-25 Thread Iblis Lin
Hi, I added the Julia binding for it. PR is here: https://github.com/apache/incubator-mxnet/pull/13992 Iblis Lin 林峻頤 On 1/23/19 12:39 AM, Pedro Larroy wrote: > Hi > > I'm pleased to announce that runtime feature detection has been merged > in master, thanks to Aaron for the merge and the many

Re: [Announce] Runtime feature detection

2019-01-24 Thread Iblis Lin
well, in case of MXNet, it's mixed with MD and RST. The docs under dir `docs/` is written in MD. (MD is supported via sphinx plugin.) For the function docstring in Python, it's written in RST. The docstring will be rendered via a sphinx feature -- "autodoc". You can check this as an example:

Re: [Announce] Runtime feature detection

2019-01-23 Thread Pedro Larroy
I'm still refining the feature given some late feedback and that it will be public API. I guess with the help of Aaron we will get some nice documentation in, as it's not showing up in the master python API docs. I thought it would be taken automatically from the Python doc. Is this a correct

Re: [Announce] Runtime feature detection

2019-01-22 Thread Skalicky, Sam
This is awesome!!! Great stuff Pedro! Is this added to any of the documentation yet? Sam > On Jan 22, 2019, at 8:39 AM, Pedro Larroy > wrote: > > Hi > > I'm pleased to announce that runtime feature detection has been merged > in master, thanks to Aaron for the merge and the many

[Announce] Runtime feature detection

2019-01-22 Thread Pedro Larroy
Hi I'm pleased to announce that runtime feature detection has been merged in master, thanks to Aaron for the merge and the many reviewers who gave feedback on the PR. ( https://github.com/apache/incubator-mxnet/pull/13549 ) As the functionality matures and is exposed through other bindings,