Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-12 Thread Anton Chernov
Unfortunately, merging the following PR Set correct update on kvstore flag in dist_device_sync mode (v1.3.x) https://github.com/apache/incubator-mxnet/pull/13121 Broke `dist-kvstore tests CPU` test stage:

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-10 Thread Anton Chernov
Due to various problems we had to postpone the tagging and vote for the release till Monday, the 12th of November 2018. Following change has been updated and waiting to be merged: Disable flaky test test_operator.test_dropout (v1.3.x) https://github.com/apache/incubator-mxnet/pull/13200 Indeed

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-09 Thread Anton Chernov
I created the following PR to disable the test: Disable flaky test test_operator.test_dropout (v1.3.x) https://github.com/apache/incubator-mxnet/pull/13200 The second failure I suppose is related to: distributed kvstore bug in MXNet https://github.com/apache/incubator-mxnet/issues/12713 Which

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-09 Thread Anton Chernov
In case the tests for MACOS will time out as well we can disable them and keep at least the build stage as in: Disable travis tests https://github.com/apache/incubator-mxnet/pull/13137 Best Anton пт, 9 нояб. 2018 г. в 11:17, Anton Chernov : > > Hi Naveen, > > I believe that the timeout is not

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-09 Thread Anton Chernov
Hi Naveen, I believe that the timeout is not an issue for the branch. And I see great benefit in having tests for MACOS on the release branch. The travis build is not blocking anyway, so I don't see any risk in adding it. * test_dropout Currently, there is a problem with test_dropout that fails

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-08 Thread Naveen Swamy
Anton, I don't think we need to add the Mac OS tests for 1.3.1 branch since travis CI is timing out and creates blockers, it also did not exist for v1.3.0. On Thu, Nov 8, 2018 at 10:04 AM Anton Chernov wrote: > A PR to fix the tests: > > Remove test for non existing index copy operator

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-08 Thread Anton Chernov
Thank you everyone for your support and suggestions. All proposed PR's have been merged. We will tag the release candidate and start the vote on Friday, the 9th of November 2018. Unfortunately after the merges the tests started to fail:

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-08 Thread Anton Chernov
A PR to fix the tests: Remove test for non existing index copy operator (v1.3.x) https://github.com/apache/incubator-mxnet/pull/13180 Best Anton чт, 8 нояб. 2018 г. в 10:05, Anton Chernov : > An addition has been made to include MacOS tests for the v1.3.x branch: > > [MXNET-908] Enable

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-08 Thread Anton Chernov
An addition has been made to include MacOS tests for the v1.3.x branch: [MXNET-908] Enable minimal OSX Travis build (v1.3.x) https://github.com/apache/incubator-mxnet/pull/13179 It includes following PR's for master: [MXNET-908] Enable minimal OSX Travis build

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-07 Thread Anton Chernov
Yes, you are right about the versions wording, thanks for clarification. A performance improvement can be considered a bugfix as well. I see no big risks in including PR's by Haibin and Lin into the patch release. @Haibin, if you can reopen the PR's they should be good to go for the relase,

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-07 Thread Sheng Zha
Hi Anton, I hear your concern about a simultaneous 1.4.0 release and it certainly is a valid one. Regarding the release, let’s agree on the language first. According to semver.org, 1.3.1 release is considered patch release, which is for backward compatible bug fixes, while 1.4.0 release is

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-07 Thread Anton Chernov
; Anton >> >>>>>> >> >>>>>> вт, 6 нояб. 2018 г. в 16:06, Anton Chernov : >> >>>>>> >> >>>>>>> Hi Haibin, >> >>>>>>> >> >>>>>>> I have a few comments regarding the pro

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-07 Thread Anton Chernov
gt;>>>>>> https://github.com/apache/incubator-mxnet/pull/13056 > >>>>>>> > >>>>>>> There is no doubt that this change brings value, but I don't see > >> it > >>>> as a > >>>>>>> critical bug f

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Sheng Zha
;>>>>> sample_like operators >>>>>>> https://github.com/apache/incubator-mxnet/pull/13034 >>>>>>> >>>>>>> Even if it's related to performance, this is an addition of >>>>> functionality >>

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Lin Yuan
> > > > >> > > > > >> > > > > >> вт, 6 нояб. 2018 г. в 15:55, Anton Chernov : > > > > >> > > > > >>> Hi Patric, > > > > >>> > > > > >>> This change was listed in t

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Aaron Markham
> for v1.3.1 patch release' section [1]. > > > >>> > > > >>> You are right, I also think that this is not a critical hotfix > change > > > >>> that should be included into the 1.3.1 patch release. > > > >>> > > > >&g

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Lai Wei
are right, I also think that this is not a critical hotfix change > > >>> that should be included into the 1.3.1 patch release. > > >>> > > >>> Thus I'm not making any further efforts to bring it in. > > >>> > > >>> Be

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Haibin Lin
t;> Best > >>> Anton > >>> > >>> [1] > >>> > https://cwiki.apache.org/confluence/display/MXNET/Project+Proposals+for+next+MXNet+Release#PR_candidates > >>> > >>> > >>> вт, 6 нояб. 2018 г. в 1:14, Zhao, Patric : > &g

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Naveen Swamy
t; Thanks for looking into the MKL-DNN PR. >>>> >>>> As my understanding of cwiki ( >>>> https://cwiki.apache.org/confluence/display/MXNET/Project+Proposals+for+next+MXNet+Release >>>> ), >>>> these features will go into 1.4 rather than patc

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Anton Chernov
-DNN PR. >>> >>> As my understanding of cwiki ( >>> https://cwiki.apache.org/confluence/display/MXNET/Project+Proposals+for+next+MXNet+Release >>> ), >>> these features will go into 1.4 rather than patch release of 1.3.1. >>> >>> Feel free

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Anton Chernov
1. >> >> Feel free to correct me :) >> >> Thanks, >> >> --Patric >> >> > -Original Message----- >> > From: Anton Chernov [mailto:mecher...@gmail.com] >> > Sent: Tuesday, November 6, 2018 3:11 AM >> > To: d...@mxnet.apache.o

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-06 Thread Anton Chernov
on Chernov [mailto:mecher...@gmail.com] > > Sent: Tuesday, November 6, 2018 3:11 AM > > To: d...@mxnet.apache.org > > Subject: Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch > > release > > > > It seems that there is a problem porting following changes t

RE: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-05 Thread Zhao, Patric
> -Original Message- > From: Anton Chernov [mailto:mecher...@gmail.com] > Sent: Tuesday, November 6, 2018 3:11 AM > To: d...@mxnet.apache.org > Subject: Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch > release > > It seems that there is a problem p

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-05 Thread Haibin Lin
Hi Anton, Thanks for driving the patch release. Besides the MKL improvements, I suggest we include two changes for *performance improvement* for NLP tasks below: CUDNN support for LSTM with projection & clipping: - https://github.com/apache/incubator-mxnet/pull/13056 - It is used in state of the

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-05 Thread Anton Chernov
It seems that there is a problem porting following changes to the v1.3.x release branch: Implement mkldnn convolution fusion and quantization https://github.com/apache/incubator-mxnet/pull/12530 MKL-DNN Quantization Examples and README https://github.com/apache/incubator-mxnet/pull/12808 The

Re: [Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-05 Thread Anton Chernov
As part of: Implement mkldnn convolution fusion and quantization https://github.com/apache/incubator-mxnet/pull/12530 I propose to add the examples and documentation PR as well: MKL-DNN Quantization Examples and README https://github.com/apache/incubator-mxnet/pull/12808 Best regards, Anton

[Announce] Upcoming Apache MXNet (incubating) 1.3.1 patch release

2018-11-05 Thread Anton Chernov
Dear MXNet community, I will be the release manager for the upcoming 1.3.1 patch release. Naveen will be co-managing the release and providing help from the committers side. The following dates have been set: Code Freeze: 31st October 2018 Release published: 13th November 2018 Release notes