Re: Updating MXNet's Cub

2018-11-24 Thread Hagay Lupesko
Thanks for getting this done Frank! On Fri, Nov 23, 2018 at 11:28 PM frankfliu2...@gmail.com < frankfliu2...@gmail.com> wrote: > I created a PR to address this issue: > https://github.com/apache/incubator-mxnet/pull/13322 > > Simply change cub submodule's URL will impact every developer. The >

Re: Updating MXNet's Cub

2018-11-23 Thread frankfliu2000
I created a PR to address this issue: https://github.com/apache/incubator-mxnet/pull/13322 Simply change cub submodule's URL will impact every developer. The recommended command: "git submodule update" won't work. Developer has to run "git submodule sync" first. To minimize the impact, I

Re: Updating MXNet's Cub

2018-11-23 Thread frankfliu2000
I create a PR: https://github.com/apache/incubator-mxnet/pull/13322 to address this issue. Updating CUB submodule URL will impact every developer. The recommended command: "git submodule update" won't work. Developer has to run "git submodule sync" first. To reduce impact for developer, I

Re: Updating MXNet's Cub

2018-08-28 Thread Lin Yuan
+1 On Tue, Aug 28, 2018 at 12:39 AM Hagay Lupesko wrote: > Thanks for the feedback Chris. Will follow up. > > On Fri, Aug 24, 2018 at 10:53 AM Chris Olivier > wrote: > > > +1 for pointing to NVidia's repo for the newer Cub and subsequent > versions. > > > > On Fri, Aug 24, 2018 at 10:01 AM

Re: Updating MXNet's Cub

2018-08-28 Thread Hagay Lupesko
Thanks for the feedback Chris. Will follow up. On Fri, Aug 24, 2018 at 10:53 AM Chris Olivier wrote: > +1 for pointing to NVidia's repo for the newer Cub and subsequent versions. > > On Fri, Aug 24, 2018 at 10:01 AM Hagay Lupesko wrote: > > > Hi all, > > > > > > One of MXNet’s submodule

Re: Updating MXNet's Cub

2018-08-24 Thread Chris Olivier
+1 for pointing to NVidia's repo for the newer Cub and subsequent versions. On Fri, Aug 24, 2018 at 10:01 AM Hagay Lupesko wrote: > Hi all, > > > One of MXNet’s submodule dependencies is a snapshot of Nvidia Cub ( > https://github.com/dmlc/cub) – the snapshot is of an older version of Cub >

Updating MXNet's Cub

2018-08-24 Thread Hagay Lupesko
Hi all, One of MXNet’s submodule dependencies is a snapshot of Nvidia Cub ( https://github.com/dmlc/cub) – the snapshot is of an older version of Cub (1.7), while the latest Nvidia Cub release is 1.8. Note that dmlc/cub has no customizations of the source Cub repo. I’d like to suggest to