Re: Module maintainers proposal

2018-01-10 Thread Mu Li
Hi Isabel, My apologies that not saying that clearly. The purpose of this proposal is encouraging more contributors to help review and merge PRs. And also hope to shorten the time for a PR to be merged. After assigning maintainers to modules, then PR contributors can easily contact the

Release plan - MXNET 1.0.1

2018-01-10 Thread Haibin Lin
I am starting the process to prepare for MXNET 1.0.1 release. I have drafted release notes (*https://cwiki.apache.org/confluence/display/MXNET/Apache+MXNet+%28incubating%29+1.0.1+Release+Notes *)

Re: Switch PR validation to PR-merge

2018-01-10 Thread Marco de Abreu
Thanks for your opinions. Could a committer please contact a mentor in order to create an Apache Infra ticket to change the protected master branch from PR-head to PR-merge? -Marco On Wed, Jan 10, 2018 at 9:26 PM, kellen sunderland < kellen.sunderl...@gmail.com> wrote: > +1 > > On Wed, Jan 10,

Re: CI: nvml: Driver/library version mismatch

2018-01-10 Thread Marco de Abreu
Small update to give you some background: We have been able to get the CI back to a stable state - thanks to Pedro and Kellen! Reason for this issue was a required security update related to the Spectre-vulnerability

Re: Switch PR validation to PR-merge

2018-01-10 Thread kellen sunderland
+1 On Wed, Jan 10, 2018 at 6:51 PM, Gautam wrote: > +1 > > On Jan 10, 2018 1:25 AM, "Marco de Abreu" > wrote: > > > Hello, > > > > TLDR: We wish to change how PRs are validated, turning off PR-head which > > tests PRs in their current branch,

please merge PRs that fixes C++ unit tests and CMake build

2018-01-10 Thread Pedro Larroy
Hi Can a committer please unblock the following PRs? We would like to have C++ tests and CMake builds back in working state. This is also creating build failures when you run CLion for development. This one is blocking more PRs: https://github.com/dmlc/mshadow/pull/317

Re: Switch PR validation to PR-merge

2018-01-10 Thread Gautam
+1 On Jan 10, 2018 1:25 AM, "Marco de Abreu" wrote: > Hello, > > TLDR: We wish to change how PRs are validated, turning off PR-head which > tests PRs in their current branch, and turning on PR-merge, which tests PRs > rebased on the current master branch. We

CI: nvml: Driver/library version mismatch

2018-01-10 Thread Marco de Abreu
Hello, recently, Nvidia released a new version of their cuda and gpu drivers for Ubuntu16.04. This updated has been applied automatically while the slaves were running, which caused the nvidia-docker-daemon to disconnect. Due to the update requiring a restart, the daemon was not able to reconnect

Re: Switch PR validation to PR-merge

2018-01-10 Thread Li, Mu
LGTM. The main reason that I switched the default option PR-merge to PR-head is because we were adding a bunch of new test cases at that time and the whole system was not very stable. Testing PR-head is easier to locate the errors in that PR. Then there is an additional PR-merge test after

Re: Module maintainers proposal

2018-01-10 Thread Pedro Larroy
Hi all. Great initiative with maintainers, I hope to see more maintainers for different modules. I'm happy to volunteer as well to help. My main concern is that PRs take a long time for code to get merged, even when changes are trivial. I would like to see lower turn around times for simple PRs,

Switch PR validation to PR-merge

2018-01-10 Thread Marco de Abreu
Hello, TLDR: We wish to change how PRs are validated, turning off PR-head which tests PRs in their current branch, and turning on PR-merge, which tests PRs rebased on the current master branch. We believe this will catch more potential errors that would otherwise get merged into master, and it