Re: Fix slicing for 0.12

2017-10-24 Thread Sunderland, Kellen
Fyi we hit a bug in both numpy and mxnet, thus 8383 is a little more complicated than we thought. Details will eventually be in the ticket, but there won't be a fix for that one tonight. On Oct 24, 2017 6:20 PM, Pedro Larroy wrote: We could also get this one

Re: Fix slicing for 0.12

2017-10-24 Thread Chris Olivier
Hours... On Tue, Oct 24, 2017 at 9:19 AM, Pedro Larroy wrote: > We could also get this one in: > > https://github.com/apache/incubator-mxnet/issues/8383 > > We are working on a fix with Kellen. > > How much time until the time window closes? > > Pedro. > > On Tue,

Re: Fix slicing for 0.12

2017-10-24 Thread Pedro Larroy
We could also get this one in: https://github.com/apache/incubator-mxnet/issues/8383 We are working on a fix with Kellen. How much time until the time window closes? Pedro. On Tue, Oct 24, 2017 at 4:50 PM, Chris Olivier wrote: > Does anyone else want to make the case

Re: Fix slicing for 0.12

2017-10-24 Thread Chris Olivier
This is assuming, however, it passes CI soon, etc so that it can be merged On Tue, Oct 24, 2017 at 6:36 AM Chris Olivier wrote: > I think we are having an rc1, in which case I will > Put this one in as well unless anyone else has objections > > On Tue, Oct 24, 2017 at

Re: Fix slicing for 0.12

2017-10-24 Thread Chris Olivier
I think we are having an rc1, in which case I will Put this one in as well unless anyone else has objections On Tue, Oct 24, 2017 at 6:31 AM Pedro Larroy wrote: > Hi > > Can we get this PR in for 0.12? > > https://github.com/apache/incubator-mxnet/pull/8400 > >

Fix slicing for 0.12

2017-10-24 Thread Pedro Larroy
Hi Can we get this PR in for 0.12? https://github.com/apache/incubator-mxnet/pull/8400 It's a critical fix with undefined behaviour, which shows itself specially in ARM platforms. -- Pedro.