Re: MXNet - Gluon - Audio

2018-11-20 Thread Sheng Zha
Hi Gaurav, The performance concerns is not just around librosa, but also the way to integrate it. librosa as a python library requires holding GIL when calling it, which makes it hard for asynchronous data preprocessing during training. Also, the API design hasn't been verified on the more

Re: MXNet - Gluon - Audio

2018-11-20 Thread Gaurav Gireesh
Hi All! Following up on this PR: https://github.com/apache/incubator-mxnet/pull/13241 I would need some comments or feedback regarding the API design : https://cwiki.apache.org/confluence/display/MXNET/Gluon+-+Audio The comments on the PR were mostly around *librosa *and its performance being a

Re: MXNet - Gluon - Audio

2018-11-15 Thread Gaurav Gireesh
Hi Lai! Thank you for your comments! Below are the answers to your comments/queries: 1) That's a good suggestion. However, I have added an example in the Pull request related to this: https://github.com/apache/incubator-mxnet/pull/13241/commits/eabb68256d8fd603a0075eafcd8947d92e7df27f . I would be

Re: MXNet - Gluon - Audio

2018-11-13 Thread Lai Wei
Hi Gaurav, Thanks for starting this. I see the PR is out , left some initial reviews, good work! In addition to Sandeep's queries, I have the following: 1. Can we include some simple classic audio dataset for users to directly import and try

Re: MXNet - Gluon - Audio

2018-11-13 Thread sandeep krishnamurthy
Thanks, Gaurav for starting this initiative. The design document is detailed and gives all the information. Starting to add this in "Contrib" is a good idea while we expect a few rough edges and cleanups to follow. I had the following queries: 1. Is there any analysis comparing LibROSA with other