Dockerhub outage had a temporary affect on CI

2018-08-25 Thread kellen sunderland
Hey all, If you noticed an issue using the CI yesterday it seems it was caused by a short-term, planned Docker Hub outage: https://status.docker.com/pages/history/533c6539221ae15e3f31 If you re-trigger your builds today they should go through properly. -Kellen

Re: clang-tidy and static code analysis

2018-08-25 Thread Marco de Abreu
Great idea, thanks a lot Kellen. I had a look at the results and I really like that they are clearly actionable and reveal issues that somebody wouldn't have caught on the first sight. My personal favorite is the branch anomaly detection which finds execution paths that would result in a function

Re: clang-tidy and static code analysis

2018-08-25 Thread Philip Cho
+1 as well. As a related idea, let's also consider adding sanitizer tests, which detects leaks and memory errors at runtime. Overhead is a lot lower than other methods such as valgrind. For an example, see the sanitizer tests in XGBoost: https://github.com/dmlc/xgboost/pull/3557 https://github.com

Re: clang-tidy and static code analysis

2018-08-25 Thread Hagay Lupesko
I really like this proposal. It will help improve the quality of MXNet native code, and maintain a uniform high bar. An extra 5 mins of build time seems reasonable. +1 On Sat, Aug 25, 2018, 07:02 kellen sunderland wrote: > Hello all, > > Inspired by Vanadana, cclaus and the project members who

clang-tidy and static code analysis

2018-08-25 Thread kellen sunderland
Hello all, Inspired by Vanadana, cclaus and the project members who setup the very solid linting tools already in place for MXNet, I'm propose we enable clang-tidy-6.0 in our CI (PR here: https://github.com/apache/incubator-mxnet/pull/12282). clang-tidy is getting to be quite a high-quality, free