Ah, I see the problem. The real problem is, we shouldn't use diamond include
instead of quotes include for project header, which is cheating cpplint to
consider them as system header. Diamond include should only be used for system
header, including OS header, STL header and host-installed
opinions vary. there’s arguments the other way, too, such as an ideal
precompiled header compiler would work best with invariant headers first as
well as template matching order in some cases
On Tue, Jan 8, 2019 at 2:44 PM Pedro Larroy
wrote:
> Hi MXNet community
>
> cpplint seems to complain
Hi Pedro,
Interesting topic. Google style does have guidance for this:
https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
According to it, the order is,
dir2/foo2.h.
A blank line
C system files.
C++ system files.
A blank line
Other libraries' .h files.
Your project's
Hi all,
I added a section F in the document that explained the current static-linked
dependencies we used for official release. As there are a few licenses are
under BSD3 and GPL, we need to handle them in our next release. Please take a
look and leave any concerns you may have.
Thanks,
Qing
Congratulation Roshani!
On Tue, Jan 8, 2019 at 8:53 AM Qing Lan wrote:
> Congrats Roshani! Great to have you here!
>
> -Qing
>
> >
> >
> > Congrats Roshani. Well deserved.
> >
> >> On Tue, Jan 8, 2019, 8:29 AM Marco de Abreu wrote:
> >>
> >> Great to have you on board, Roshani!
> >>
> >>
Congrats Roshani! Great to have you here!
-Qing
>
>
> Congrats Roshani. Well deserved.
>
>> On Tue, Jan 8, 2019, 8:29 AM Marco de Abreu >
>> Great to have you on board, Roshani!
>>
>> -Marco
>>
>> Am Di., 8. Jan. 2019, 15:18 hat Carin Meier
>> geschrieben:
>>
>>> Please join me in
Congrats Roshani. Well deserved.
On Tue, Jan 8, 2019, 8:29 AM Marco de Abreu Great to have you on board, Roshani!
>
> -Marco
>
> Am Di., 8. Jan. 2019, 15:18 hat Carin Meier
> geschrieben:
>
> > Please join me in welcoming Roshani Nagmote as a new committer.
> >
> > She has been active in the
Great to have you on board, Roshani!
-Marco
Am Di., 8. Jan. 2019, 15:18 hat Carin Meier
geschrieben:
> Please join me in welcoming Roshani Nagmote as a new committer.
>
> She has been active in the project for quite some time. She has managed the
> 1.3.0 release as well as being involved
Dear MXNet community,
I would like to invite you to the regular Apache MXNet (Incubating) User
Group meeting on the 8th of January 2019 [1].
As usually, the meeting will have remote VC, powered by Amazon Chime.
Join the meeting:
https://chime.aws/4899512091
Meeting ID: 4899 51 2091
Best
Anton
