Re: [DISCUSS] - Revisions to Committer Criteria

2018-10-29 Thread Jason Dai
Given the recent discussions around code review, I think it makes sense to call out the importance of code review contributions for the committer criteria. Thanks, -Jason On Mon, Oct 29, 2018 at 11:12 AM Naveen Swamy wrote: > I added clarifying sections to explicitly call out committers/PMC >

Re: [Discussion] Recognise Reviewers, Besides Committers and PMC

2018-10-25 Thread Jason Dai
In general I don’t think it’s a good idea to add more hierarchy for the project or community. And a relatively easy way to address the issue of lack of reviewers is to bring in more committers, and focus on one’s code review contributions (instead of code contributions) when voting someone to

Re: [Discussion] Separating PMC and Committership

2018-10-19 Thread Jason Dai
I think in general it's always a good idea to reduce barriers to entry into the project. Therefore I think separating committer and PMC roles is a good idea, as it helps encourage and recognize contributors by giving them commit early; and then it allows the new committers to spend some more time

Re: Which merge option to use on the Import Julia binding PR?

2018-09-27 Thread Jason Dai
+1 to rebase and merge to preserve and track the contributions. Thanks, -Jason On Thu, Sep 27, 2018 at 12:27 PM Aaron Markham wrote: > +1 to rebase and merge to retain the efforts of all of the contributors. If > there's some git maintenance that can trim it down from 700+ commits then > maybe