Re: [Announcement] New Committer - Junru Shao

2019-09-08 Thread Qin, Zhennan
Congratulations, Junru! Zhennan On Sun, 2019-09-08 at 03:14 +, Sheng Zha wrote: Hi all, Please join me in welcoming Junru Shao as a new committer of Apache MXNet (incubating)! Junru made a number of contributions to this project such as cond and while_loop control-flow operators,

Re: Making new operators and AMP lists

2019-05-30 Thread Qin, Zhennan
How about change the below line in amp.py:164 wrap_list = fp32_ops if fp32_ops is not None else lists.symbol.FP32_FUNCS to be plist = ctypes.POINTER(ctypes.c_char_p)() size = ctypes.c_uint() check_call(_LIB.MXListAllOpNames(ctypes.byref(size),

RE: Order of includes in cpplint

2019-01-08 Thread Qin, Zhennan
as system headers are being included before other library headers which might be using a system header like without including it themselves. Pedro. On Wed, Jan 9, 2019 at 2:12 AM Qin, Zhennan wrote: > > Hi Pedro, > > Interesting topic. Google style does have guidance for thi

RE: Order of includes in cpplint

2019-01-08 Thread Qin, Zhennan
Hi Pedro, Interesting topic. Google style does have guidance for this: https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes According to it, the order is, dir2/foo2.h. A blank line C system files. C++ system files. A blank line Other libraries' .h files. Your project's

RE: Time out for Travis CI

2018-09-29 Thread Qin, Zhennan
test running time? > > > or just disable the Travis CI? > > > > > > > > > On Fri, Sep 28, 2018 at 9:17 PM Qin, Zhennan > > > > > > wrote: > > > > > > > > Hi Kellen, > > > > > > > > Thanks for

RE: Time out for Travis CI

2018-09-28 Thread Qin, Zhennan
. Unfortunately the timeouts are global and we're not able to increase them. I'm hoping that adding artifact caching will speed up future builds to the point that test runs and builds can be executed in under the global limit (which is ~50 minutes). -Kellen On Fri, Sep 28, 2018 at 4:05 PM Qin, Zhennan

Time out for Travis CI

2018-09-28 Thread Qin, Zhennan
Hi MXNet devs, I'm struggled with new Travis CI for a while, it always run time out for this PR: https://github.com/apache/incubator-mxnet/pull/12530 Most of the time, Jenkins CI can pass, while Travis can't be finished within 50 minutes. For this PR, it shouldn't affect much on the build time