Re: [DISCUSS] Process to remove deprecated operators

2019-03-01 Thread Naveen Swamy
It might be a good idea to issue those deprecation messages right away if have replacement operators already, so users get enough time to migrate to the new operators. On Thu, Feb 28, 2019 at 2:45 PM Anirudh Acharya wrote: > Hi Lin, > > This is a good idea. Here is an issue - >

Re: [DISCUSS] Process to remove deprecated operators

2019-02-28 Thread Anirudh Acharya
Hi Lin, This is a good idea. Here is an issue - https://github.com/apache/incubator-mxnet/issues/9686 that is already attempting to collate all the breaking changes that might be necessary for v2.0. We could start by adding things to that issue. I think eventually we will need a separate branch

Re: [DISCUSS] Process to remove deprecated operators

2019-02-28 Thread Wen-Yang Chu
Hi, I have raised an issue: mx.nd.Crop does not support FP16 and decpreciated but no direct alternative with central crop I use this operator to implement Unet and I found other people too on the Internent. It is very inconvenient to remove this specific operator withoit clear alternative for

Re: [DISCUSS] Process to remove deprecated operators

2019-02-28 Thread Chaitanya Bapat
This sounds good. Going further, if we can maintain a list of deprecated operators - we can create a "Good for first contribution" issue to improve log messaging of Deprecated operators. If it makes sense, I can go ahead and create that. Hope this helps. On Thu, 28 Feb 2019 at 01:54, Lin Yuan

Re: [DISCUSS] Process to remove deprecated operators

2019-02-27 Thread Lin Yuan
Agreed. When we deprecate an operator, we should add in the log message something like "This operator X is deprecate and will be removed in the next release. Please use operator Y instead." Lin On Wed, Feb 27, 2019 at 10:23 PM Junru Shao wrote: > Hi Lin, > > I would love to share some immature

Re: [DISCUSS] Process to remove deprecated operators

2019-02-27 Thread Junru Shao
Hi Lin, I would love to share some immature ideas about deprecating operators. Not only adopting semantic versioning, but also should we provide enough informative error message for customers to understand how to replace deprecated operators with new ones. Thanks, Junru On Wed, Feb 27, 2019 at

Re: [DISCUSS] Process to remove deprecated operators

2019-02-27 Thread Lin Yuan
Sheng, Thanks for your quick response. If that's the case, we will wait till 2.0 release to remove the deprecated operators from code. Best, Lin On Wed, Feb 27, 2019 at 9:06 PM Sheng Zha wrote: > MXNet follows semantic versioning so we will be able to delete them in the > next major release.

Re: [DISCUSS] Process to remove deprecated operators

2019-02-27 Thread Sheng Zha
MXNet follows semantic versioning so we will be able to delete them in the next major release. -sz On Wed, Feb 27, 2019 at 8:53 PM Lin Yuan wrote: > Dear Community, > > In MXNet there are many legacy operators such as this > < >

[DISCUSS] Process to remove deprecated operators

2019-02-27 Thread Lin Yuan
Dear Community, In MXNet there are many legacy operators such as this that has been marked DEPRECATE for several releases. However, these operators still exist in