Re: [Discussion] MXNet CMake build - raise minimal required version

2018-11-22 Thread Chris Olivier
yes that flag can be removed. profiler should always be. built in On Thu, Nov 22, 2018 at 7:44 AM Anton Chernov wrote: > You can find relevant information regarding the profiling flag here: > > https://github.com/apache/incubator-mxnet/issues/11563 > > > чт, 22 нояб. 2018 г. в 16:06, Chris Olivi

Re: [Discussion] MXNet CMake build - raise minimal required version

2018-11-22 Thread Pedro Larroy
Thanks Anton for putting this together and your efforts here. I think it's crucial that we maintain and bring the CMake system forward. I have spent a lot of time dealing with CMake issues on different platforms, we really increase developer productivity and platform support by having a streamlined

Re: [Discussion] MXNet CMake build - raise minimal required version

2018-11-22 Thread Anton Chernov
You can find relevant information regarding the profiling flag here: https://github.com/apache/incubator-mxnet/issues/11563 чт, 22 нояб. 2018 г. в 16:06, Chris Olivier : > what is meant by: > > > *Profiling* > The profiler is always on even for production release builds, because MXNet > can not

Re: [Discussion] MXNet CMake build - raise minimal required version

2018-11-22 Thread Chris Olivier
what is meant by: *Profiling* The profiler is always on even for production release builds, because MXNet can not be build without it [2]. ? you mean it is always built or it is turned on (ie recording and saving profiling information)? I am not aware of it being turned on by default. profil

Re: [Discussion] MXNet CMake build - raise minimal required version

2018-11-22 Thread Chris Olivier
i have not seen any proof that any crashes are due to llvm openmp usage. On Thu, Nov 22, 2018 at 2:35 AM Anton Chernov wrote: > Dear MXNet community, > > I propose to raise the minimal required cmake version that is needed to > build MXNet to 3.10 which was tagged on March 16 2018 [1]. > > The e

[Discussion] MXNet CMake build - raise minimal required version

2018-11-22 Thread Anton Chernov
Dear MXNet community, I propose to raise the minimal required cmake version that is needed to build MXNet to 3.10 which was tagged on March 16 2018 [1]. The effort of repairing cmake scripts in general is targeting to deprecate make and maintain only 1 build system. *Need* The build system is t