Re: [QUESTION] mxnet/Tuple vs nnvm/Tuple

2019-04-16 Thread Lin Yuan
Jun, Thanks! I was also leaning towards your suggestion. I have updated nnvm::Tuple to mxnet::Tuple for a few remaining places in MXNet. Best, Lin On Tue, Apr 16, 2019 at 11:35 AM Jun Wu wrote: > include/mxnet/tuple.h was first copied from nnvm in this PR >

Re: [QUESTION] mxnet/Tuple vs nnvm/Tuple

2019-04-16 Thread Jun Wu
include/mxnet/tuple.h was first copied from nnvm in this PR so that we can make changes on it to support zero-dim and zero-size tensors without affecting TVM project. That PR has changed most of the places where nnvm::Tuple and nnvm::TShape wer

[QUESTION] mxnet/Tuple vs nnvm/Tuple

2019-04-15 Thread Lin Yuan
Dear Community, Currently in MXNet there are two Tuple template class defined in mxnet/tuple.h and nnvm/tuple.h respectively. These two templates are higly similar and most part are duplicated except for a couple of functions. However, they were used mixedly in current codebase and causing conflic