Re: CMake issues

+1 to pushing to the branch. We can revisit a patch release if there are critical bugs. On Tue, May 22, 2018 at 1:51 PM, Anirudh wrote: > I think pushing the fixes back to the release branch should be sufficient. > I am not sure why we need to maintain a different patches

Re: CMake issues

I think pushing the fixes back to the release branch should be sufficient. I am not sure why we need to maintain a different patches branch. I agree that if there are a bunch of important fixes that didn't go into the release, then we need to do a patch release for the same. On Tue, May 22, 2018

Re: CMake issues

1.2.1 patch release with this bug fix (+ others if applicable) will be very useful for the users. On Tue, May 22, 2018 at 1:08 PM, Rahul Huilgol wrote: > Maybe we could do that now, after the code for the release has been voted > on. We could maintain a patches branch

Re: CMake issues

Maybe we could do that now, after the code for the release has been voted on. We could maintain a patches branch for a release. This would also be helpful for users who are using a particular release version but hesitate to switch to the latest release when it's out because of the many changes.

Re: CMake issues

Thats an interesting suggestion. I understand the benefits, but this will complicate things if we want to do another quick release like the previous one (for eg. if there is a license issue because of which the release is cancelled). Anirudh On Thu, May 17, 2018 at 9:23 PM, Naveen Swamy

Re: CMake issues

why don't we cherry-pick and push it to the branch as well ? next time a release is cut from that branch we'll have everything working. On Thu, May 17, 2018 at 9:21 PM, Anirudh wrote: > Correction : This fix went into master but not 1.2 release. > > On Thu, May 17, 2018

Re: CMake issues

Correction : This fix went into master but not 1.2 release. On Thu, May 17, 2018 at 9:21 PM, Anirudh wrote: > Hi Xinyu, > > Thank you! This fix didnt went into master but not 1.2 release. > > Anirudh > > On Thu, May 17, 2018 at 5:23 PM, Chen, Xinyu1

Re: CMake issues

Hi Xinyu, Thank you! This fix didnt went into master but not 1.2 release. Anirudh On Thu, May 17, 2018 at 5:23 PM, Chen, Xinyu1 wrote: > Hi all, > > Regarding to the following knowing issues listed below RC3: > > > * CMake build ignores the USE_MKLDNN flag and

CMake issues

Hi all, Regarding to the following knowing issues listed below RC3: * CMake build ignores the USE_MKLDNN flag and doesn't build with MKLDNN support even with -DUSE_MKLDNN=1. To workaround the issue please see: #10801. I think this