Re: CODEOWNERS file being removed

2017-11-29 Thread Chris Olivier
ok On Wed, Nov 29, 2017 at 1:42 PM, Tianqi Chen wrote: > Codeowner feature is used to automatically trigger the review request for > the people. All the committers are already listed as global owners, which > is consistent with Apache's policy > > Tianqi > > On Wed,

Re: CODEOWNERS file being removed

2017-11-29 Thread Chris Olivier
If you can push back on Justin, I can keep it. Just not looking forward to going through all of this again just to have it bounced back. On Wed, Nov 29, 2017 at 1:37 PM, Hen wrote: > Was there more discussion than Justin's question about it on general@? > > My memory of

Re: CODEOWNERS file being removed

2017-11-29 Thread Tianqi Chen
Codeowner feature is used to automatically trigger the review request for the people. All the committers are already listed as global owners, which is consistent with Apache's policy Tianqi On Wed, Nov 29, 2017 at 1:37 PM, Hen wrote: > Was there more discussion than Justin's

Re: CODEOWNERS file being removed

2017-11-29 Thread Hen
Was there more discussion than Justin's question about it on general@? My memory of CODEOWNERS was that it was related to some code review tool, but looking at the history of dev@ I only see: "Can't have changes merged into it until changes to files that have a designated code owner

CODEOWNERS file being removed

2017-11-29 Thread Chris Olivier
Per suggestion from Apache, we are removing CODEOWNERS file from root of mxnet. If there are any objections, please voice them: Here are the contents of rht file: # Owners of Apache MXNet # Global owners *@apache/mxnet-committers # Owners of language bindings R-package/*