Re: Merging Clojure PR

2018-07-01 Thread Naveen Swamy
Congratulations Carin!, awesome effort. Thank you all for coming together to get Clojure into MXNet, love the collaborative spirit here. On another note, Aaron Markham has graciously offered to give some love to Clojure on the MXNet website, he would be collaborating with Carin to add some

Re: Merging Clojure PR

2018-07-01 Thread Marco de Abreu
Thanks for the fast review on a Sunday! Waiting for tests to pass now. I'll merge it as soon as the PR is ready and will give an update here. -Marco On Sun, Jul 1, 2018 at 1:04 PM Carin Meier wrote: > Reviewed and approved. Thanks for putting it together :) > > On Sun, Jul 1, 2018 at 6:55 AM,

Re: Merging Clojure PR

2018-07-01 Thread Carin Meier
Reviewed and approved. Thanks for putting it together :) On Sun, Jul 1, 2018 at 6:55 AM, Marco de Abreu < marco.g.ab...@googlemail.com.invalid> wrote: > PR is available at https://github.com/apache/incubator-mxnet/pull/11512. > So > far, it's looking good. None the less, please review :) > >

Re: Merging Clojure PR

2018-07-01 Thread Marco de Abreu
PR is available at https://github.com/apache/incubator-mxnet/pull/11512. So far, it's looking good. None the less, please review :) -Marco On Sun, Jul 1, 2018 at 12:46 PM Carin Meier wrote: > Yay on the merge! and Oh No! on the RAT. I'm up now too and taking a look > too. > > On Sun, Jul 1,

Re: Merging Clojure PR

2018-07-01 Thread Carin Meier
Yay on the merge! and Oh No! on the RAT. I'm up now too and taking a look too. On Sun, Jul 1, 2018 at 5:56 AM, Marco de Abreu < marco.g.ab...@googlemail.com.invalid> wrote: > Congratulations! Unfortunately was the last CI run of that PR stale and did > not include the latest updates to our

Re: Merging Clojure PR

2018-07-01 Thread Marco de Abreu
Congratulations! Unfortunately was the last CI run of that PR stale and did not include the latest updates to our pipeline. We just added the rat license check which apparently did not run on your PR send is now failing on master as well as blocking all pull request builds. I will try to add the

Re: Merging Clojure PR

2018-07-01 Thread Pedro Larroy
Congrats on the PR being merged. On Fri, Jun 29, 2018 at 3:02 PM Carin Meier wrote: > Thanks for reviewing for the PR. I answered the questions there and am > happy to discuss it further if you would like. > > - Carin > > > On Fri, Jun 29, 2018 at 3:02 AM, YiZhi Liu wrote: > > > Thanks Carin

Re: Merging Clojure PR

2018-06-29 Thread Carin Meier
Thanks for reviewing for the PR. I answered the questions there and am happy to discuss it further if you would like. - Carin On Fri, Jun 29, 2018 at 3:02 AM, YiZhi Liu wrote: > Thanks Carin for the great contribution. I just left several questions > in the PR, would you mind to take a look?

Re: Merging Clojure PR

2018-06-29 Thread YiZhi Liu
Thanks Carin for the great contribution. I just left several questions in the PR, would you mind to take a look? Sorry for the late review. On Thu, Jun 28, 2018 at 12:14 PM Hagay Lupesko wrote: > > Thanks for your contribution Carin! > Unfortunately i can't do a proper review for Clojure, but

Re: Merging Clojure PR

2018-06-28 Thread Hagay Lupesko
Thanks for your contribution Carin! Unfortunately i can't do a proper review for Clojure, but it's great to see the contribution and see how it develops and grows... On Thu, Jun 28, 2018 at 11:11 AM Carin Meier wrote: > Thanks everyone for your feedback and efforts with the Clojure package PR.

Re: Merging Clojure PR

2018-06-28 Thread Carin Meier
Thanks everyone for your feedback and efforts with the Clojure package PR. I'm delighted to join the MXNet community and work with you all and am excited to invite the Clojure community to grow with it :) Thanks, Carin On Thu, Jun 28, 2018 at 1:38 PM, Pedro Larroy wrote: > Yes, great work

Re: Merging Clojure PR

2018-06-28 Thread Pedro Larroy
Yes, great work Carin! I even saw your book on Clojure autographed. Pedro. On Wed, Jun 27, 2018 at 7:24 PM Naveen Swamy wrote: > Hi All, > > Carin (https://github.com/gigasquid) has done a worked on a Clojure MXNet > package for the Clojure community, Thank you Carin. > > I would like to merge