Re: Question about notification on nightly test failures

2019-01-19 Thread Pedro Larroy
Looks fine to me. On Wed, Jan 16, 2019 at 11:44 PM Carin Meier wrote: > > The Clojure package now has turned the examples into integration tests that > we would like to have CI run. It takes about 15 min for them to complete. > > We have a PR in progress > https://github.com/apache/incubator-mxne

Re: Question about notification on nightly test failures

2019-01-16 Thread Carin Meier
The Clojure package now has turned the examples into integration tests that we would like to have CI run. It takes about 15 min for them to complete. We have a PR in progress https://github.com/apache/incubator-mxnet/pull/13624 I would like to propose that we run these as part of the regular CI u

Re: Question about notification on nightly test failures

2019-01-15 Thread Pedro Larroy
Why don't we enable a slack notifier? I think it would be useful to interact with notifications from slack directly, including the label bot for example. Pedro. On Sun, Jan 13, 2019 at 1:55 AM Carin Meier wrote: > > Thanks for the explanation Marco :) > > - Carin > > On Sat, Jan 12, 2019 at 7:4

Re: Question about notification on nightly test failures

2019-01-12 Thread Carin Meier
Thanks for the explanation Marco :) - Carin On Sat, Jan 12, 2019 at 7:43 PM Marco de Abreu wrote: > Hi Carin, > > thanks for thinking about adding nightly tests to clojure, I'm sure this > will be of big benefit! > > You're right, the email system is in place but we basically disabled the > ser

Re: Question about notification on nightly test failures

2019-01-12 Thread Marco de Abreu
Hi Carin, thanks for thinking about adding nightly tests to clojure, I'm sure this will be of big benefit! You're right, the email system is in place but we basically disabled the service December 2017 because it was flooding the inboxes of everybody. We've been thinking about various notificati

Question about notification on nightly test failures

2019-01-12 Thread Carin Meier
The Clojure package is thinking of adding some nightly tests and I'd like to understand how the notification works in case of failure. The code in the nightly Jenkins file https://github.com/apache/incubator-mxnet/blob/master/tests/nightly/Jenkinsfile#L135 seems to indicate that the failure is ema