Re: Regarding 1.2.1 Release

2018-07-03 Thread Anirudh
Hi Sergio and MXNet community, I wanted to summarize the reasons for requesting a new RC of 1.2.1: The warning message “save_params is deprecated , please use save_parameters instead” was confusing because the new API ‘save_parameters’ which deprecated ‘save_params’ could be used in 2 contexts

Re: Regarding 1.2.1 Release

2018-07-02 Thread Sergio Fernández
Besides that I can't agree with the arguments about the warning at 1.2.1-RC1-incubating, but I guess I haven't much to say. Remember that "if it didn't happen on a mailing list, it didn't happen". On Mon, Jul 2, 2018, 17:37 Anirudh wrote: > Hi all, > > After an offline discussion, the current

Regarding 1.2.1 Release

2018-07-02 Thread Anirudh
Hi all, After an offline discussion, the current decision is to block the 1.2.1 release, improve the warning message for save_params usage here: https://github.com/apache/incubator-mxnet/pull/11532 , cut a new RC and then restart the voting process. Anirudh