Re: Regarding 1.2.1 patch release
https://github.com/apache/incubator-mxnet/pull/11049 > is > > > not > > > > > critical > > > > > > > and > > > > > > > will show up in mxnet.io docs in master when it is > > > merged. I > > > > would > > > > > > be > > > > > > > little hesitant about https://github.com/apache/ > > > > > > > incubator-mxnet/pull/11095 > > > > > > > since it lacks test currently. We can consider > > > > > > > https://github.com/apache/incubator-mxnet/pull/11047 > if > > > it is > > > > > merged > > > > > > > in > > > > > > > time. > > > > > > > > > > > > > > Anirudh > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Thu, Jun 7, 2018 at 2:27 PM, Naveen Swamy < > > > mnnav...@gmail.com > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > Hi Anirudh, > > > > > > > > > > > > > > > > I would like to get the fixes that was made to > publish > > > to Maven > > > > > > into > > > > > > > 1.2.1 > > > > > > > > -- currently in PR https://github.com/apache/ > > > > > > > incubator-mxnet/pull/11147/ > > > > > > > > > > > > > > > > Also additionally, I would like to get the fix for > > > > > > > > https://github.com/apache/ > incubator-mxnet/issues/10436 - > > > > > currently > > > > > > > another > > > > > > > > contributor Andrew is working on it. > > > > > > > > > > > > > > > > -Naveen > > > > > > > > > > > > > > > > On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A < > > > tao.a...@intel.com> > > > > > > > wrote: > > > > > > > > > > > > > > > > > Thanks for bringing this up, Da! > > > > > > > > > > > > > > > > > > It would be great if we can have these fixes into > > > 1.2.1 patch > > > > > > > release, > > > > > > > > > especially for https://github.com/apache/ > > > > > > > incubator-mxnet/pull/10651, it > > > > > > > > > has fixed > > > > > https://github.com/apache/incubator-mxnet/issues/11028 > > > > > > . > > > > > > > > > > > > > > > > > > What I want to add are: > > > > > > > > > 1. https://github.com/apache/ > > > incubator-mxnet/pull/10810 > > > > which > > > > > > > fixed > > > > > > > > > https://github.com/apache/ > incubator-mxnet/issues/10809 > > > . > > > > > > > > > 2. https://github.com/apache/ > > > incubator-mxnet/pull/10613 for > > > > > doc > > > > > > > > > improvement. > > > > > > > > > > > > > > > > > > I don't quite understand the criteria for choosing > > > patch PRs > > > > > and > > > > > > > what's > > > > > > > > > the timeline of 1.2.1 patch release. If it's > possible, > > > I also > > > > > > want > > > > > > > to > > > > > > > > have > > > > > > > > > below PRs. But it depends the progress of review > and > > > merging. > > > > > > > > > 1. bug fix: > > > > > https://github.com/apache/incubator-mxnet/pull/11095 > > > > > > > (under > > > > > > > > > review) > > > > > > > > > 2. perf improvement: https://github.com/apache/ > > >
Re: Regarding 1.2.1 patch release
o Maven > > > > > into > > > > > > 1.2.1 > > > > > > > -- currently in PR https://github.com/apache/ > > > > > > incubator-mxnet/pull/11147/ > > > > > > > > > > > > > > Also additionally, I would like to get the fix for > > > > > > > https://github.com/apache/incubator-mxnet/issues/10436 - > > > > currently > > > > > > another > > > > > > > contributor Andrew is working on it. > > > > > > > > > > > > > > -Naveen > > > > > > > > > > > > > > On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A < > > tao.a...@intel.com> > > > > > > wrote: > > > > > > > > > > > > > > > Thanks for bringing this up, Da! > > > > > > > > > > > > > > > > It would be great if we can have these fixes into > > 1.2.1 patch > > > > > > release, > > > > > > > > especially for https://github.com/apache/ > > > > > > incubator-mxnet/pull/10651, it > > > > > > > > has fixed > > > > https://github.com/apache/incubator-mxnet/issues/11028 > > > > > . > > > > > > > > > > > > > > > > What I want to add are: > > > > > > > > 1. https://github.com/apache/ > > incubator-mxnet/pull/10810 > > > which > > > > > > fixed > > > > > > > > https://github.com/apache/incubator-mxnet/issues/10809 > > . > > > > > > > > 2. https://github.com/apache/ > > incubator-mxnet/pull/10613 for > > > > doc > > > > > > > > improvement. > > > > > > > > > > > > > > > > I don't quite understand the criteria for choosing > > patch PRs > > > > and > > > > > > what's > > > > > > > > the timeline of 1.2.1 patch release. If it's possible, > > I also > > > > > want > > > > > > to > > > > > > > have > > > > > > > > below PRs. But it depends the progress of review and > > merging. > > > > > > > > 1. bug fix: > > > > https://github.com/apache/incubator-mxnet/pull/11095 > > > > > > (under > > > > > > > > review) > > > > > > > > 2. perf improvement: https://github.com/apache/ > > > > > > > incubator-mxnet/pull/11047 > > > > > > > > (approved) > > > > > > > > 3. doc improvement: https://github.com/apache/ > > > > > > incubator-mxnet/pull/11049 > > > > > > > > (under review) > > > > > > > > > > > > > > > > BR, > > > > > > > > -tao > > > > > > > > > > > > > > > > -Original Message- > > > > > > > > From: Zheng, Da [mailto:dzz...@amazon.com] > > > > > > > > Sent: Thursday, June 7, 2018 8:55 AM > > > > > > > > To: dev@mxnet.incubator.apache.org > > > > > > > > Cc: Emani, Ashok ; Lv, Tao A < > > > > > > tao.a...@intel.com > > > > > > > >; > > > > > > > > Zhao, Patric ; Zai, Alexander < > > > > > > alex...@amazon.com > > > > > > > > > > > > > > > > Subject: Re: Regarding 1.2.1 patch release > > > > > > > > > > > > > > > > Hello Anirudh, > > > > > > > > > > > > > > > > Could you merge the bugs below? Each of the bug fixes > > below > > > > come > > > > > > with a > > > > > > > > set of tests and many of them are critical for Gluon. > > > > > > > > MKLDNN: > > > > > > > > https://github.com/apache/incubator-mxnet/pull/10979 > > > > > > > > https://github.com/apache/incubator-mxnet/pull/10731 > > > > > > > > https://github.com/apache/incubator-mxnet/pull/10706 > > > > > > > > https://github.com/apache/incubator-mxnet/pull/10651 > > > > > > > > https://github.com/apache/incubator-mxnet/pull/10624 > > > > > > > > https://github.com/apache/incubator-mxnet/pull/10619 > > > > > > > > https://github.com/apache/incubator-mxnet/pull/10616 > > > > > > > > > > > > > > > > Others: > > > > > > > > https://github.com/apache/incubator-mxnet/pull/10918 > > > > > > > > > > > > > > > > @Ashok @Tao @Patric @Alex, do you have other important > > MKLDNN > > > > bug > > > > > > fixes > > > > > > > > that should be merged? > > > > > > > > > > > > > > > > Best, > > > > > > > > Da > > > > > > > > > > > > > > > > On 6/6/18, 5:23 PM, "Anirudh" > > > > > > > > anirudh2...@gmail.com>> wrote: > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > I wanted to bring up some MKLDNN fixes that went > > into > > > > master > > > > > > but not > > > > > > > > into > > > > > > > > 1.2. > > > > > > > > Should these changes be going to the patch release > > ? We > > > had > > > > > > kept some > > > > > > > > changes from going into 1.2 branch since we were > > waiting > > > > for > > > > > > the test > > > > > > > > suite > > > > > > > > for MKLDNN. > > > > > > > > Is this test suite planned for the next major or > > minor > > > > > > release? Also, > > > > > > > > are > > > > > > > > there any critical MKLDNN bug fixes which are in > > master > > > and > > > > > > well > > > > > > > > tested and > > > > > > > > can go into the patch release ? > > > > > > > > > > > > > > > > Anirudh > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Jun 6, 2018 at 1:48 PM, Anirudh < > > > > > anirudh2...@gmail.com > > > > > > > > > > > > > > anirudh2...@gmail.com>> wrote: > > > > > > > > > > > > > > > > > Hi all, > > > > > > > > > > > > > > > > > > As you may be aware, 1.2 has an undocumented > > backwards > > > > > > incompatible > > > > > > > > change > > > > > > > > > relating to saving and loading params. Please > > see: > > > > > > > > https://github.com/ > > > > > > > > > apache/incubator-mxnet/issues/11091. > > > > > > > > > > > > > > > > > > More details about the fix will be tracked here: > > > > > > > > https://issues.apache. > > > > > > > > > org/jira/browse/MXNET-518 > > > > > > > > > > > > > > > > > > The above fix will go as part of the 1.2.1 patch > > > release > > > > > > which will > > > > > > > > be > > > > > > > > > coming out soon. > > > > > > > > > > > > > > > > > > In addition to this, we will also be including: > > > > > > > https://github.com/ > > > > > > > > > apache/incubator-mxnet/pull/11142 > > > > > > > > > > > > > > > > > > I request the community to point out other bug > > fixes > > > that > > > > > are > > > > > > > > critical and > > > > > > > > > should go as part of 1.2.1 patch release. > > > > > > > > > > > > > > > > > > Anirudh > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- Yizhi Liu DMLC member Amazon Web Services Vancouver, Canada
Re: Regarding 1.2.1 patch release
> > > > https://github.com/apache/incubator-mxnet/pull/10619 > > > > > https://github.com/apache/incubator-mxnet/pull/10616 > > > > > https://github.com/apache/incubator-mxnet/pull/10918 > > > > > https://github.com/apache/incubator-mxnet/pull/10613 > > > > > > > > > > I am a little concerned about the below two PRs since they > don't > > > have > > > > > enough tests: > > > > > https://github.com/apache/incubator-mxnet/pull/10706 > > > > > https://github.com/apache/incubator-mxnet/pull/10810 > > > > > > > > > > <https://github.com/apache/incubator-mxnet/pull/10810> > > > > > Can you please talk about the test coverage of these two > PRs. > > > > > > > > > > Hi Tao, > > > > > > > > > > To answer your question about the criteria for choosing > PRs for > > > patch > > > > > release: I think we haven't done patch release many times > before > > > and > > > > we > > > > > don't have a clear set of criteria on what can go into the > patch > > > > > release. > > > > > The main intention of doing patch release is to fix the > > > undocumented > > > > > backwards incompatible change from 1.1. Along with this > critical > > > > fixes > > > > > should also be pushed out. AFAIK, The "critical" here is > not > > > clearly > > > > > defined by the community yet and we should use our best > judgement > > > > here. > > > > > According to me, everything which has potential to impact > a > > large > > > > > number > > > > > of MXNet users can be considered critical. > > > > > > > > > > The timeline for the patch release is "as soon as > possible". > > > > > https://github.com/apache/incubator-mxnet/pull/11049 is > not > > > critical > > > > > and > > > > > will show up in mxnet.io docs in master when it is > merged. I > > would > > > > be > > > > > little hesitant about https://github.com/apache/ > > > > > incubator-mxnet/pull/11095 > > > > > since it lacks test currently. We can consider > > > > > https://github.com/apache/incubator-mxnet/pull/11047 if > it is > > > merged > > > > > in > > > > > time. > > > > > > > > > > Anirudh > > > > > > > > > > > > > > > > > > > > On Thu, Jun 7, 2018 at 2:27 PM, Naveen Swamy < > mnnav...@gmail.com > > > > > > > > wrote: > > > > > > > > > > > Hi Anirudh, > > > > > > > > > > > > I would like to get the fixes that was made to publish > to Maven > > > > into > > > > > 1.2.1 > > > > > > -- currently in PR https://github.com/apache/ > > > > > incubator-mxnet/pull/11147/ > > > > > > > > > > > > Also additionally, I would like to get the fix for > > > > > > https://github.com/apache/incubator-mxnet/issues/10436 - > > > currently > > > > > another > > > > > > contributor Andrew is working on it. > > > > > > > > > > > > -Naveen > > > > > > > > > > > > On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A < > tao.a...@intel.com> > > > > > wrote: > > > > > > > > > > > > > Thanks for bringing this up, Da! > > > > > > > > > > > > > > It would be great if we can have these fixes into > 1.2.1 patch > > > > > release, > > > > > > > especially for https://github.com/apache/ > > > > > incubator-mxnet/pull/10651, it > > > > > > > has fixed > > > https://github.com/apache/incub
Re: Regarding 1.2.1 patch release
t;https://github.com/apache/incubator-mxnet/pull/10810> > > > > Can you please talk about the test coverage of these two PRs. > > > > > > > > Hi Tao, > > > > > > > > To answer your question about the criteria for choosing PRs for > > patch > > > > release: I think we haven't done patch release many times before > > and > > > we > > > > don't have a clear set of criteria on what can go into the patch > > > > release. > > > > The main intention of doing patch release is to fix the > > undocumented > > > > backwards incompatible change from 1.1. Along with this critical > > > fixes > > > > should also be pushed out. AFAIK, The "critical" here is not > > clearly > > > > defined by the community yet and we should use our best judgement > > > here. > > > > According to me, everything which has potential to impact a > large > > > > number > > > > of MXNet users can be considered critical. > > > > > > > > The timeline for the patch release is "as soon as possible". > > > > https://github.com/apache/incubator-mxnet/pull/11049 is not > > critical > > > > and > > > > will show up in mxnet.io docs in master when it is merged. I > would > > > be > > > > little hesitant about https://github.com/apache/ > > > > incubator-mxnet/pull/11095 > > > > since it lacks test currently. We can consider > > > > https://github.com/apache/incubator-mxnet/pull/11047 if it is > > merged > > > > in > > > > time. > > > > > > > > Anirudh > > > > > > > > > > > > > > > > On Thu, Jun 7, 2018 at 2:27 PM, Naveen Swamy > > > > > wrote: > > > > > > > > > Hi Anirudh, > > > > > > > > > > I would like to get the fixes that was made to publish to Maven > > > into > > > > 1.2.1 > > > > > -- currently in PR https://github.com/apache/ > > > > incubator-mxnet/pull/11147/ > > > > > > > > > > Also additionally, I would like to get the fix for > > > > > https://github.com/apache/incubator-mxnet/issues/10436 - > > currently > > > > another > > > > > contributor Andrew is working on it. > > > > > > > > > > -Naveen > > > > > > > > > > On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A > > > > wrote: > > > > > > > > > > > Thanks for bringing this up, Da! > > > > > > > > > > > > It would be great if we can have these fixes into 1.2.1 patch > > > > release, > > > > > > especially for https://github.com/apache/ > > > > incubator-mxnet/pull/10651, it > > > > > > has fixed > > https://github.com/apache/incubator-mxnet/issues/11028 > > > . > > > > > > > > > > > > What I want to add are: > > > > > > 1. https://github.com/apache/incubator-mxnet/pull/10810 > which > > > > fixed > > > > > > https://github.com/apache/incubator-mxnet/issues/10809 . > > > > > > 2. https://github.com/apache/incubator-mxnet/pull/10613 for > > doc > > > > > > improvement. > > > > > > > > > > > > I don't quite understand the criteria for choosing patch PRs > > and > > > > what's > > > > > > the timeline of 1.2.1 patch release. If it's possible, I also > > > want > > > > to > > > > > have > > > > > > below PRs. But it depends the progress of review and merging. > > > > > > 1. bug fix: > > https://github.com/apache/incubator-mxnet/pull/11095 > > > > (under > > > > > > review) > > > > > > 2. perf improvement: https://github.com/a
Re: Regarding 1.2.1 patch release
s > > > > should also be pushed out. AFAIK, The "critical" here is not > > clearly > > > > defined by the community yet and we should use our best judgement > > > here. > > > > According to me, everything which has potential to impact a > large > > > > number > > > > of MXNet users can be considered critical. > > > > > > > > The timeline for the patch release is "as soon as possible". > > > > https://github.com/apache/incubator-mxnet/pull/11049 is not > > critical > > > > and > > > > will show up in mxnet.io docs in master when it is merged. I > would > > > be > > > > little hesitant about https://github.com/apache/ > > > > incubator-mxnet/pull/11095 > > > > since it lacks test currently. We can consider > > > > https://github.com/apache/incubator-mxnet/pull/11047 if it is > > merged > > > > in > > > > time. > > > > > > > > Anirudh > > > > > > > > > > > > > > > > On Thu, Jun 7, 2018 at 2:27 PM, Naveen Swamy > > > > > wrote: > > > > > > > > > Hi Anirudh, > > > > > > > > > > I would like to get the fixes that was made to publish to Maven > > > into > > > > 1.2.1 > > > > > -- currently in PR https://github.com/apache/ > > > > incubator-mxnet/pull/11147/ > > > > > > > > > > Also additionally, I would like to get the fix for > > > > > https://github.com/apache/incubator-mxnet/issues/10436 - > > currently > > > > another > > > > > contributor Andrew is working on it. > > > > > > > > > > -Naveen > > > > > > > > > > On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A > > > > wrote: > > > > > > > > > > > Thanks for bringing this up, Da! > > > > > > > > > > > > It would be great if we can have these fixes into 1.2.1 patch > > > > release, > > > > > > especially for https://github.com/apache/ > > > > incubator-mxnet/pull/10651, it > > > > > > has fixed > > https://github.com/apache/incubator-mxnet/issues/11028 > > > . > > > > > > > > > > > > What I want to add are: > > > > > > 1. https://github.com/apache/incubator-mxnet/pull/10810 > which > > > > fixed > > > > > > https://github.com/apache/incubator-mxnet/issues/10809 . > > > > > > 2. https://github.com/apache/incubator-mxnet/pull/10613 for > > doc > > > > > > improvement. > > > > > > > > > > > > I don't quite understand the criteria for choosing patch PRs > > and > > > > what's > > > > > > the timeline of 1.2.1 patch release. If it's possible, I also > > > want > > > > to > > > > > have > > > > > > below PRs. But it depends the progress of review and merging. > > > > > > 1. bug fix: > > https://github.com/apache/incubator-mxnet/pull/11095 > > > > (under > > > > > > review) > > > > > > 2. perf improvement: https://github.com/apache/ > > > > > incubator-mxnet/pull/11047 > > > > > > (approved) > > > > > > 3. doc improvement: https://github.com/apache/ > > > > incubator-mxnet/pull/11049 > > > > > > (under review) > > > > > > > > > > > > BR, > > > > > > -tao > > > > > > > > > > > > -Original Message- > > > > > > From: Zheng, Da [mailto:dzz...@amazon.com] > > > > > > Sent: Thursday, June 7, 2018 8:55 AM > > > > > > To: dev@mxnet.incubator.apache.org > > > > > > Cc: Emani, Ashok ; Lv, Tao A < > > > > tao.a...@intel.com > > > > > >; > > > > > > Zhao, Patric ; Zai, Alexander < > > > > alex...@amazon.com > > > > > > > > > > > > Subject: Re: Regarding 1.2.1 patch release > > > > > > > > > > > > Hello Anirudh, > &g
Re: Regarding 1.2.1 patch release
> > > in > > > time. > > > > > > Anirudh > > > > > > > > > > > > On Thu, Jun 7, 2018 at 2:27 PM, Naveen Swamy > > > wrote: > > > > > > > Hi Anirudh, > > > > > > > > I would like to get the fixes that was made to publish to Maven > > into > > > 1.2.1 > > > > -- currently in PR https://github.com/apache/ > > > incubator-mxnet/pull/11147/ > > > > > > > > Also additionally, I would like to get the fix for > > > > https://github.com/apache/incubator-mxnet/issues/10436 - > currently > > > another > > > > contributor Andrew is working on it. > > > > > > > > -Naveen > > > > > > > > On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A > > > wrote: > > > > > > > > > Thanks for bringing this up, Da! > > > > > > > > > > It would be great if we can have these fixes into 1.2.1 patch > > > release, > > > > > especially for https://github.com/apache/ > > > incubator-mxnet/pull/10651, it > > > > > has fixed > https://github.com/apache/incubator-mxnet/issues/11028 > > . > > > > > > > > > > What I want to add are: > > > > > 1. https://github.com/apache/incubator-mxnet/pull/10810 which > > > fixed > > > > > https://github.com/apache/incubator-mxnet/issues/10809 . > > > > > 2. https://github.com/apache/incubator-mxnet/pull/10613 for > doc > > > > > improvement. > > > > > > > > > > I don't quite understand the criteria for choosing patch PRs > and > > > what's > > > > > the timeline of 1.2.1 patch release. If it's possible, I also > > want > > > to > > > > have > > > > > below PRs. But it depends the progress of review and merging. > > > > > 1. bug fix: > https://github.com/apache/incubator-mxnet/pull/11095 > > > (under > > > > > review) > > > > > 2. perf improvement: https://github.com/apache/ > > > > incubator-mxnet/pull/11047 > > > > > (approved) > > > > > 3. doc improvement: https://github.com/apache/ > > > incubator-mxnet/pull/11049 > > > > > (under review) > > > > > > > > > > BR, > > > > > -tao > > > > > > > > > > -Original Message- > > > > > From: Zheng, Da [mailto:dzz...@amazon.com] > > > > > Sent: Thursday, June 7, 2018 8:55 AM > > > > > To: dev@mxnet.incubator.apache.org > > > > > Cc: Emani, Ashok ; Lv, Tao A < > > > tao.a...@intel.com > > > > >; > > > > > Zhao, Patric ; Zai, Alexander < > > > alex...@amazon.com > > > > > > > > > > Subject: Re: Regarding 1.2.1 patch release > > > > > > > > > > Hello Anirudh, > > > > > > > > > > Could you merge the bugs below? Each of the bug fixes below > come > > > with a > > > > > set of tests and many of them are critical for Gluon. > > > > > MKLDNN: > > > > > https://github.com/apache/incubator-mxnet/pull/10979 > > > > > https://github.com/apache/incubator-mxnet/pull/10731 > > > > > https://github.com/apache/incubator-mxnet/pull/10706 > > > > > https://github.com/apache/incubator-mxnet/pull/10651 > > > > > https://github.com/apache/incubator-mxnet/pull/10624 > > > > > https://github.com/apache/incubator-mxnet/pull/10619 > > > > > https://github.com/apache/incubator-mxnet/pull/10616 > > > > > > > > > > Others: > > > > > https://github.com/apache/incubator-mxnet/pull/10918 > > > > > > > > > > @Ashok @Tao @Patric @Alex, do you have other important MKLDNN > bug > > > fixes > > > > > that should be merged? > > > > > > > > > > Best, > > > > > Da > > > > > > > > > > On 6/6/18, 5:23 PM, "Anirudh" > > > > anirudh2...@gmail.com>> wrote: > > > > > > > > > > Hi, > > > > > > > > > > I wanted to bring up some MKLDNN fixes that went into > master > > > but not > > > > > into > > > > > 1.2. > > > > > Should these changes be going to the patch release ? We had > > > kept some > > > > > changes from going into 1.2 branch since we were waiting > for > > > the test > > > > > suite > > > > > for MKLDNN. > > > > > Is this test suite planned for the next major or minor > > > release? Also, > > > > > are > > > > > there any critical MKLDNN bug fixes which are in master and > > > well > > > > > tested and > > > > > can go into the patch release ? > > > > > > > > > > Anirudh > > > > > > > > > > > > > > > On Wed, Jun 6, 2018 at 1:48 PM, Anirudh < > > anirudh2...@gmail.com > > > > > > > > anirudh2...@gmail.com>> wrote: > > > > > > > > > > > Hi all, > > > > > > > > > > > > As you may be aware, 1.2 has an undocumented backwards > > > incompatible > > > > > change > > > > > > relating to saving and loading params. Please see: > > > > > https://github.com/ > > > > > > apache/incubator-mxnet/issues/11091. > > > > > > > > > > > > More details about the fix will be tracked here: > > > > > https://issues.apache. > > > > > > org/jira/browse/MXNET-518 > > > > > > > > > > > > The above fix will go as part of the 1.2.1 patch release > > > which will > > > > > be > > > > > > coming out soon. > > > > > > > > > > > > In addition to this, we will also be including: > > > > https://github.com/ > > > > > > apache/incubator-mxnet/pull/11142 > > > > > > > > > > > > I request the community to point out other bug fixes that > > are > > > > > critical and > > > > > > should go as part of 1.2.1 patch release. > > > > > > > > > > > > Anirudh > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
Re: Regarding 1.2.1 patch release
; On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A > > wrote: > > > > > > > Thanks for bringing this up, Da! > > > > > > > > It would be great if we can have these fixes into 1.2.1 patch > > release, > > > > especially for https://github.com/apache/ > > incubator-mxnet/pull/10651, it > > > > has fixed https://github.com/apache/incubator-mxnet/issues/11028 > . > > > > > > > > What I want to add are: > > > > 1. https://github.com/apache/incubator-mxnet/pull/10810 which > > fixed > > > > https://github.com/apache/incubator-mxnet/issues/10809 . > > > > 2. https://github.com/apache/incubator-mxnet/pull/10613 for doc > > > > improvement. > > > > > > > > I don't quite understand the criteria for choosing patch PRs and > > what's > > > > the timeline of 1.2.1 patch release. If it's possible, I also > want > > to > > > have > > > > below PRs. But it depends the progress of review and merging. > > > > 1. bug fix: https://github.com/apache/incubator-mxnet/pull/11095 > > (under > > > > review) > > > > 2. perf improvement: https://github.com/apache/ > > > incubator-mxnet/pull/11047 > > > > (approved) > > > > 3. doc improvement: https://github.com/apache/ > > incubator-mxnet/pull/11049 > > > > (under review) > > > > > > > > BR, > > > > -tao > > > > > > > > -Original Message- > > > > From: Zheng, Da [mailto:dzz...@amazon.com] > > > > Sent: Thursday, June 7, 2018 8:55 AM > > > > To: dev@mxnet.incubator.apache.org > > > > Cc: Emani, Ashok ; Lv, Tao A < > > tao.a...@intel.com > > > >; > > > > Zhao, Patric ; Zai, Alexander < > > alex...@amazon.com > > > > > > > > Subject: Re: Regarding 1.2.1 patch release > > > > > > > > Hello Anirudh, > > > > > > > > Could you merge the bugs below? Each of the bug fixes below come > > with a > > > > set of tests and many of them are critical for Gluon. > > > > MKLDNN: > > > > https://github.com/apache/incubator-mxnet/pull/10979 > > > > https://github.com/apache/incubator-mxnet/pull/10731 > > > > https://github.com/apache/incubator-mxnet/pull/10706 > > > > https://github.com/apache/incubator-mxnet/pull/10651 > > > > https://github.com/apache/incubator-mxnet/pull/10624 > > > > https://github.com/apache/incubator-mxnet/pull/10619 > > > > https://github.com/apache/incubator-mxnet/pull/10616 > > > > > > > > Others: > > > > https://github.com/apache/incubator-mxnet/pull/10918 > > > > > > > > @Ashok @Tao @Patric @Alex, do you have other important MKLDNN bug > > fixes > > > > that should be merged? > > > > > > > > Best, > > > > Da > > > > > > > > On 6/6/18, 5:23 PM, "Anirudh" > > > anirudh2...@gmail.com>> wrote: > > > > > > > > Hi, > > > > > > > > I wanted to bring up some MKLDNN fixes that went into master > > but not > > > > into > > > > 1.2. > > > > Should these changes be going to the patch release ? We had > > kept some > > > > changes from going into 1.2 branch since we were waiting for > > the test > > > > suite > > > > for MKLDNN. > > > > Is this test suite planned for the next major or minor > > release? Also, > > > > are > > > > there any critical MKLDNN bug fixes which are in master and > > well > > > > tested and > > > > can go into the patch release ? > > > > > > > > Anirudh > > > > > > > > > > > > On Wed, Jun 6, 2018 at 1:48 PM, Anirudh < > anirudh2...@gmail.com > > > > > > anirudh2...@gmail.com>> wrote: > > > > > > > > > Hi all, > > > > > > > > > > As you may be aware, 1.2 has an undocumented backwards > > incompatible > > > > change > > > > > relating to saving and loading params. Please see: > > > > https://github.com/ > > > > > apache/incubator-mxnet/issues/11091. > > > > > > > > > > More details about the fix will be tracked here: > > > > https://issues.apache. > > > > > org/jira/browse/MXNET-518 > > > > > > > > > > The above fix will go as part of the 1.2.1 patch release > > which will > > > > be > > > > > coming out soon. > > > > > > > > > > In addition to this, we will also be including: > > > https://github.com/ > > > > > apache/incubator-mxnet/pull/11142 > > > > > > > > > > I request the community to point out other bug fixes that > are > > > > critical and > > > > > should go as part of 1.2.1 patch release. > > > > > > > > > > Anirudh > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
Re: Regarding 1.2.1 patch release
Hello Anirudh, There is a test (test_hybrid_multi_context) for https://github.com/apache/incubator-mxnet/pull/10706 It's also tested by the C++ unit tests in https://github.com/apache/incubator-mxnet/pull/10979 https://github.com/apache/incubator-mxnet/pull/10979/files#diff-8118d4fd8d897a9177f48257a466ea13R435 Best, Da On 6/7/18, 3:37 PM, "Anirudh" wrote: Hi Da, Can you please open a PR to the 1.2 branch with the following PRs mentioned by you and Tao cherry picked onto release branch. https://github.com/apache/incubator-mxnet/pull/10979 https://github.com/apache/incubator-mxnet/pull/10731 https://github.com/apache/incubator-mxnet/pull/10651 https://github.com/apache/incubator-mxnet/pull/10624 https://github.com/apache/incubator-mxnet/pull/10619 https://github.com/apache/incubator-mxnet/pull/10616 https://github.com/apache/incubator-mxnet/pull/10918 https://github.com/apache/incubator-mxnet/pull/10613 I am a little concerned about the below two PRs since they don't have enough tests: https://github.com/apache/incubator-mxnet/pull/10706 https://github.com/apache/incubator-mxnet/pull/10810 <https://github.com/apache/incubator-mxnet/pull/10810> Can you please talk about the test coverage of these two PRs. Hi Tao, To answer your question about the criteria for choosing PRs for patch release: I think we haven't done patch release many times before and we don't have a clear set of criteria on what can go into the patch release. The main intention of doing patch release is to fix the undocumented backwards incompatible change from 1.1. Along with this critical fixes should also be pushed out. AFAIK, The "critical" here is not clearly defined by the community yet and we should use our best judgement here. According to me, everything which has potential to impact a large number of MXNet users can be considered critical. The timeline for the patch release is "as soon as possible". https://github.com/apache/incubator-mxnet/pull/11049 is not critical and will show up in mxnet.io docs in master when it is merged. I would be little hesitant about https://github.com/apache/incubator-mxnet/pull/11095 since it lacks test currently. We can consider https://github.com/apache/incubator-mxnet/pull/11047 if it is merged in time. Anirudh On Thu, Jun 7, 2018 at 2:27 PM, Naveen Swamy wrote: > Hi Anirudh, > > I would like to get the fixes that was made to publish to Maven into 1.2.1 > -- currently in PR https://github.com/apache/incubator-mxnet/pull/11147/ > > Also additionally, I would like to get the fix for > https://github.com/apache/incubator-mxnet/issues/10436 - currently another > contributor Andrew is working on it. > > -Naveen > > On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A wrote: > > > Thanks for bringing this up, Da! > > > > It would be great if we can have these fixes into 1.2.1 patch release, > > especially for https://github.com/apache/incubator-mxnet/pull/10651, it > > has fixed https://github.com/apache/incubator-mxnet/issues/11028 . > > > > What I want to add are: > > 1. https://github.com/apache/incubator-mxnet/pull/10810 which fixed > > https://github.com/apache/incubator-mxnet/issues/10809 . > > 2. https://github.com/apache/incubator-mxnet/pull/10613 for doc > > improvement. > > > > I don't quite understand the criteria for choosing patch PRs and what's > > the timeline of 1.2.1 patch release. If it's possible, I also want to > have > > below PRs. But it depends the progress of review and merging. > > 1. bug fix: https://github.com/apache/incubator-mxnet/pull/11095 (under > > review) > > 2. perf improvement: https://github.com/apache/ > incubator-mxnet/pull/11047 > > (approved) > > 3. doc improvement: https://github.com/apache/incubator-mxnet/pull/11049 > > (under review) > > > > BR, > > -tao > > > > -Original Message- > > From: Zheng, Da [mailto:dzz...@amazon.com] > > Sent: Thursday, June 7, 2018 8:55 AM > > To: dev@mxnet.incubator.apache.org > > Cc: Emani, Ashok ; Lv, Tao A >; > > Zhao, Patric ; Zai, Alexander > > > Subject: Re: Regarding 1.2.1 patch release > > > > Hello Anirudh, > > > > Could you merge the bugs below? Each of the bug fixes below come with a > > set of tests and many of them are critical for Gluon. > > MKLDNN: > > https://github.com/apache/incu
Re: Regarding 1.2.1 patch release
Hi Naveen, What is the timeline that you are looking at to fix this issue: https://github.com/apache/incubator-mxnet/issues/10436 Anirudh On Thu, Jun 7, 2018 at 3:36 PM, Anirudh wrote: > Hi Da, > > Can you please open a PR to the 1.2 branch with the following PRs > mentioned by you and Tao cherry picked onto release branch. > > https://github.com/apache/incubator-mxnet/pull/10979 > https://github.com/apache/incubator-mxnet/pull/10731 > https://github.com/apache/incubator-mxnet/pull/10651 > https://github.com/apache/incubator-mxnet/pull/10624 > https://github.com/apache/incubator-mxnet/pull/10619 > https://github.com/apache/incubator-mxnet/pull/10616 > https://github.com/apache/incubator-mxnet/pull/10918 > https://github.com/apache/incubator-mxnet/pull/10613 > > I am a little concerned about the below two PRs since they don't have > enough tests: > https://github.com/apache/incubator-mxnet/pull/10706 > https://github.com/apache/incubator-mxnet/pull/10810 > > <https://github.com/apache/incubator-mxnet/pull/10810> > Can you please talk about the test coverage of these two PRs. > > Hi Tao, > > To answer your question about the criteria for choosing PRs for patch > release: I think we haven't done patch release many times before and we > don't have a clear set of criteria on what can go into the patch release. > The main intention of doing patch release is to fix the undocumented > backwards incompatible change from 1.1. Along with this critical fixes > should also be pushed out. AFAIK, The "critical" here is not clearly > defined by the community yet and we should use our best judgement here. > According to me, everything which has potential to impact a large number > of MXNet users can be considered critical. > > The timeline for the patch release is "as soon as possible". > https://github.com/apache/incubator-mxnet/pull/11049 is not critical and > will show up in mxnet.io docs in master when it is merged. I would be > little hesitant about https://github.com/apache/incubator-mxnet/pull/11095 > since it lacks test currently. We can consider https://github.com/ > apache/incubator-mxnet/pull/11047 if it is merged in time. > > Anirudh > > > > On Thu, Jun 7, 2018 at 2:27 PM, Naveen Swamy wrote: > >> Hi Anirudh, >> >> I would like to get the fixes that was made to publish to Maven into 1.2.1 >> -- currently in PR https://github.com/apache/incubator-mxnet/pull/11147/ >> >> Also additionally, I would like to get the fix for >> https://github.com/apache/incubator-mxnet/issues/10436 - currently >> another >> contributor Andrew is working on it. >> >> -Naveen >> >> On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A wrote: >> >> > Thanks for bringing this up, Da! >> > >> > It would be great if we can have these fixes into 1.2.1 patch release, >> > especially for https://github.com/apache/incubator-mxnet/pull/10651, it >> > has fixed https://github.com/apache/incubator-mxnet/issues/11028 . >> > >> > What I want to add are: >> > 1. https://github.com/apache/incubator-mxnet/pull/10810 which fixed >> > https://github.com/apache/incubator-mxnet/issues/10809 . >> > 2. https://github.com/apache/incubator-mxnet/pull/10613 for doc >> > improvement. >> > >> > I don't quite understand the criteria for choosing patch PRs and what's >> > the timeline of 1.2.1 patch release. If it's possible, I also want to >> have >> > below PRs. But it depends the progress of review and merging. >> > 1. bug fix: https://github.com/apache/incubator-mxnet/pull/11095 (under >> > review) >> > 2. perf improvement: https://github.com/apache/incu >> bator-mxnet/pull/11047 >> > (approved) >> > 3. doc improvement: https://github.com/apache/incu >> bator-mxnet/pull/11049 >> > (under review) >> > >> > BR, >> > -tao >> > >> > -Original Message- >> > From: Zheng, Da [mailto:dzz...@amazon.com] >> > Sent: Thursday, June 7, 2018 8:55 AM >> > To: dev@mxnet.incubator.apache.org >> > Cc: Emani, Ashok ; Lv, Tao A > >; >> > Zhao, Patric ; Zai, Alexander < >> alex...@amazon.com> >> > Subject: Re: Regarding 1.2.1 patch release >> > >> > Hello Anirudh, >> > >> > Could you merge the bugs below? Each of the bug fixes below come with a >> > set of tests and many of them are critical for Gluon. >> > MKLDNN: >> > https://github.com/apache/incubator-mxnet/pull/10979 >> > https://github.com/apache/incubator-mxnet/pull/10731 >>
Re: Regarding 1.2.1 patch release
Hi Da, Can you please open a PR to the 1.2 branch with the following PRs mentioned by you and Tao cherry picked onto release branch. https://github.com/apache/incubator-mxnet/pull/10979 https://github.com/apache/incubator-mxnet/pull/10731 https://github.com/apache/incubator-mxnet/pull/10651 https://github.com/apache/incubator-mxnet/pull/10624 https://github.com/apache/incubator-mxnet/pull/10619 https://github.com/apache/incubator-mxnet/pull/10616 https://github.com/apache/incubator-mxnet/pull/10918 https://github.com/apache/incubator-mxnet/pull/10613 I am a little concerned about the below two PRs since they don't have enough tests: https://github.com/apache/incubator-mxnet/pull/10706 https://github.com/apache/incubator-mxnet/pull/10810 <https://github.com/apache/incubator-mxnet/pull/10810> Can you please talk about the test coverage of these two PRs. Hi Tao, To answer your question about the criteria for choosing PRs for patch release: I think we haven't done patch release many times before and we don't have a clear set of criteria on what can go into the patch release. The main intention of doing patch release is to fix the undocumented backwards incompatible change from 1.1. Along with this critical fixes should also be pushed out. AFAIK, The "critical" here is not clearly defined by the community yet and we should use our best judgement here. According to me, everything which has potential to impact a large number of MXNet users can be considered critical. The timeline for the patch release is "as soon as possible". https://github.com/apache/incubator-mxnet/pull/11049 is not critical and will show up in mxnet.io docs in master when it is merged. I would be little hesitant about https://github.com/apache/incubator-mxnet/pull/11095 since it lacks test currently. We can consider https://github.com/apache/incubator-mxnet/pull/11047 if it is merged in time. Anirudh On Thu, Jun 7, 2018 at 2:27 PM, Naveen Swamy wrote: > Hi Anirudh, > > I would like to get the fixes that was made to publish to Maven into 1.2.1 > -- currently in PR https://github.com/apache/incubator-mxnet/pull/11147/ > > Also additionally, I would like to get the fix for > https://github.com/apache/incubator-mxnet/issues/10436 - currently another > contributor Andrew is working on it. > > -Naveen > > On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A wrote: > > > Thanks for bringing this up, Da! > > > > It would be great if we can have these fixes into 1.2.1 patch release, > > especially for https://github.com/apache/incubator-mxnet/pull/10651, it > > has fixed https://github.com/apache/incubator-mxnet/issues/11028 . > > > > What I want to add are: > > 1. https://github.com/apache/incubator-mxnet/pull/10810 which fixed > > https://github.com/apache/incubator-mxnet/issues/10809 . > > 2. https://github.com/apache/incubator-mxnet/pull/10613 for doc > > improvement. > > > > I don't quite understand the criteria for choosing patch PRs and what's > > the timeline of 1.2.1 patch release. If it's possible, I also want to > have > > below PRs. But it depends the progress of review and merging. > > 1. bug fix: https://github.com/apache/incubator-mxnet/pull/11095 (under > > review) > > 2. perf improvement: https://github.com/apache/ > incubator-mxnet/pull/11047 > > (approved) > > 3. doc improvement: https://github.com/apache/incubator-mxnet/pull/11049 > > (under review) > > > > BR, > > -tao > > > > -Original Message- > > From: Zheng, Da [mailto:dzz...@amazon.com] > > Sent: Thursday, June 7, 2018 8:55 AM > > To: dev@mxnet.incubator.apache.org > > Cc: Emani, Ashok ; Lv, Tao A >; > > Zhao, Patric ; Zai, Alexander > > > Subject: Re: Regarding 1.2.1 patch release > > > > Hello Anirudh, > > > > Could you merge the bugs below? Each of the bug fixes below come with a > > set of tests and many of them are critical for Gluon. > > MKLDNN: > > https://github.com/apache/incubator-mxnet/pull/10979 > > https://github.com/apache/incubator-mxnet/pull/10731 > > https://github.com/apache/incubator-mxnet/pull/10706 > > https://github.com/apache/incubator-mxnet/pull/10651 > > https://github.com/apache/incubator-mxnet/pull/10624 > > https://github.com/apache/incubator-mxnet/pull/10619 > > https://github.com/apache/incubator-mxnet/pull/10616 > > > > Others: > > https://github.com/apache/incubator-mxnet/pull/10918 > > > > @Ashok @Tao @Patric @Alex, do you have other important MKLDNN bug fixes > > that should be merged? > > > > Best, > > Da > > > > On 6/6/18, 5:23 PM, "Anirudh" > anirudh2...@gmail.com>> wrote: > > > >
Re: Regarding 1.2.1 patch release
Hi Anirudh, I would like to get the fixes that was made to publish to Maven into 1.2.1 -- currently in PR https://github.com/apache/incubator-mxnet/pull/11147/ Also additionally, I would like to get the fix for https://github.com/apache/incubator-mxnet/issues/10436 - currently another contributor Andrew is working on it. -Naveen On Thu, Jun 7, 2018 at 8:33 AM, Lv, Tao A wrote: > Thanks for bringing this up, Da! > > It would be great if we can have these fixes into 1.2.1 patch release, > especially for https://github.com/apache/incubator-mxnet/pull/10651, it > has fixed https://github.com/apache/incubator-mxnet/issues/11028 . > > What I want to add are: > 1. https://github.com/apache/incubator-mxnet/pull/10810 which fixed > https://github.com/apache/incubator-mxnet/issues/10809 . > 2. https://github.com/apache/incubator-mxnet/pull/10613 for doc > improvement. > > I don't quite understand the criteria for choosing patch PRs and what's > the timeline of 1.2.1 patch release. If it's possible, I also want to have > below PRs. But it depends the progress of review and merging. > 1. bug fix: https://github.com/apache/incubator-mxnet/pull/11095 (under > review) > 2. perf improvement: https://github.com/apache/incubator-mxnet/pull/11047 > (approved) > 3. doc improvement: https://github.com/apache/incubator-mxnet/pull/11049 > (under review) > > BR, > -tao > > -Original Message- > From: Zheng, Da [mailto:dzz...@amazon.com] > Sent: Thursday, June 7, 2018 8:55 AM > To: dev@mxnet.incubator.apache.org > Cc: Emani, Ashok ; Lv, Tao A ; > Zhao, Patric ; Zai, Alexander > Subject: Re: Regarding 1.2.1 patch release > > Hello Anirudh, > > Could you merge the bugs below? Each of the bug fixes below come with a > set of tests and many of them are critical for Gluon. > MKLDNN: > https://github.com/apache/incubator-mxnet/pull/10979 > https://github.com/apache/incubator-mxnet/pull/10731 > https://github.com/apache/incubator-mxnet/pull/10706 > https://github.com/apache/incubator-mxnet/pull/10651 > https://github.com/apache/incubator-mxnet/pull/10624 > https://github.com/apache/incubator-mxnet/pull/10619 > https://github.com/apache/incubator-mxnet/pull/10616 > > Others: > https://github.com/apache/incubator-mxnet/pull/10918 > > @Ashok @Tao @Patric @Alex, do you have other important MKLDNN bug fixes > that should be merged? > > Best, > Da > > On 6/6/18, 5:23 PM, "Anirudh" anirudh2...@gmail.com>> wrote: > > Hi, > > I wanted to bring up some MKLDNN fixes that went into master but not > into > 1.2. > Should these changes be going to the patch release ? We had kept some > changes from going into 1.2 branch since we were waiting for the test > suite > for MKLDNN. > Is this test suite planned for the next major or minor release? Also, > are > there any critical MKLDNN bug fixes which are in master and well > tested and > can go into the patch release ? > > Anirudh > > > On Wed, Jun 6, 2018 at 1:48 PM, Anirudh anirudh2...@gmail.com>> wrote: > > > Hi all, > > > > As you may be aware, 1.2 has an undocumented backwards incompatible > change > > relating to saving and loading params. Please see: > https://github.com/ > > apache/incubator-mxnet/issues/11091. > > > > More details about the fix will be tracked here: > https://issues.apache. > > org/jira/browse/MXNET-518 > > > > The above fix will go as part of the 1.2.1 patch release which will > be > > coming out soon. > > > > In addition to this, we will also be including: https://github.com/ > > apache/incubator-mxnet/pull/11142 > > > > I request the community to point out other bug fixes that are > critical and > > should go as part of 1.2.1 patch release. > > > > Anirudh > > > > > >
Re: Regarding 1.2.1 patch release
Hi, I wanted to bring up some MKLDNN fixes that went into master but not into 1.2. Should these changes be going to the patch release ? We had kept some changes from going into 1.2 branch since we were waiting for the test suite for MKLDNN. Is this test suite planned for the next major or minor release? Also, are there any critical MKLDNN bug fixes which are in master and well tested and can go into the patch release ? Anirudh On Wed, Jun 6, 2018 at 1:48 PM, Anirudh wrote: > Hi all, > > As you may be aware, 1.2 has an undocumented backwards incompatible change > relating to saving and loading params. Please see: https://github.com/ > apache/incubator-mxnet/issues/11091. > > More details about the fix will be tracked here: https://issues.apache. > org/jira/browse/MXNET-518 > > The above fix will go as part of the 1.2.1 patch release which will be > coming out soon. > > In addition to this, we will also be including: https://github.com/ > apache/incubator-mxnet/pull/11142 > > I request the community to point out other bug fixes that are critical and > should go as part of 1.2.1 patch release. > > Anirudh >
Regarding 1.2.1 patch release
Hi all, As you may be aware, 1.2 has an undocumented backwards incompatible change relating to saving and loading params. Please see: https://github.com/apache/incubator-mxnet/issues/11091. More details about the fix will be tracked here: https://issues.apache.org/jira/browse/MXNET-518 The above fix will go as part of the 1.2.1 patch release which will be coming out soon. In addition to this, we will also be including: https://github.com/apache/incubator-mxnet/pull/11142 I request the community to point out other bug fixes that are critical and should go as part of 1.2.1 patch release. Anirudh
