Re: Unit tests removed

> CoreOpExecutor. > > > This > > > > > code compiles the first test. > > > > > > > > > > See notes in the PR description: > > > > > > > > > > https://github.com/cjolivier01/mxnet/pull/2 > > > > > > > > &g

Re: Unit tests removed

> > > > > > > > https://github.com/cjolivier01/mxnet/pull/2 > > > > > > > > On Wed, Jan 31, 2018 at 9:47 PM, Zhao, Patric <patric.z...@intel.com > > > > > > wrote: > > > > > > > > > Thanks, Chris, I agree

Re: Unit tests removed

will try to enable these cases ASAP. > > > > > > > > ---Patric > > > > > > > > > -Original Message- > > > > > From: Chris Olivier [mailto:cjolivie...@gmail.com] > > > > > Sent: Thursday, February 1, 2018 1:04 PM > >

Re: Unit tests removed

, Jan 31, 2018 at 9:47 PM, Zhao, Patric <patric.z...@intel.com> > > > wrote: > > > > > > > Thanks, Chris, I agree the quality is the most important thing. > > > > > > > > We will try to enable these cases ASAP. > > > > > &g

Re: Unit tests removed

> > wrote: > > > > > Thanks, Chris, I agree the quality is the most important thing. > > > > > > We will try to enable these cases ASAP. > > > > > > ---Patric > > > > > > > -Original Message- > > >

Re: Unit tests removed

agree the quality is the most important thing. > > > > > > We will try to enable these cases ASAP. > > > > > > ---Patric > > > > > > > -Original Message- > > > > From: Chris Olivier [mailto:cjolivie...@gmail.com] > > > > Sen

Re: Unit tests removed

t; > > From: Chris Olivier [mailto:cjolivie...@gmail.com] > > > Sent: Thursday, February 1, 2018 1:04 PM > > > To: dev@mxnet.incubator.apache.org > > > Subject: Re: Unit tests removed > > > > > > C++ Unit tests test correctness of output as well

Re: Unit tests removed

C++ Unit tests test correctness of output as well as consistency of *all inputs and outputs* between different implementations (mkl, cpu, gpu, cudnn, etc.) C++ Unit tests also test that varying channel axes produce the expected numeric distributions. In addition, *batch norm tests in

Re: Unit tests removed

Good catch. In general, I agree that tests are not supposed to removed, although CI is not running any of these cpp tests just yet. Usually unit tests in python for individual operators should be sufficient to test the correctness of operators (although I don't know how/if python tests can run on

Re: Unit tests removed

Here's a link: https://github.com/apache/incubator-mxnet/pull/8302#discussion_r165204667 -Marco 2018-01-31 15:23 GMT-08:00 Marco de Abreu : > Hi Chris, > > considering the size of that PR, could you provide a direct link to the > changes you're addressing? > >

Re: Unit tests removed

Hi Chris, considering the size of that PR, could you provide a direct link to the changes you're addressing? -Marco 2018-01-31 13:39 GMT-08:00 Chris Olivier : > This PR was just merged that removed some 30 or so C++ unit tests for batch > norm operator. > >

Unit tests removed

This PR was just merged that removed some 30 or so C++ unit tests for batch norm operator. https://github.com/apache/incubator-mxnet/pull/8302 Is this ok?