Re: duplicated nnvm code

2019-04-11 Thread Junru Shao
We should remove 3rdparty/tvm/nnvm/gradient.cc.o imo On Thu, Apr 11, 2019 at 6:44 PM Pedro Larroy wrote: > Hi > > I found that src/nnvm and 3rdparty/tvm/nnvm/src/pass/ has duplicated > code that we are linking in: > > ./CMakeFiles/mxnet_static.dir/3rdparty/tvm/nnvm/src/pass/gradient.cc.o >

duplicated nnvm code

2019-04-11 Thread Pedro Larroy
Hi I found that src/nnvm and 3rdparty/tvm/nnvm/src/pass/ has duplicated code that we are linking in: ./CMakeFiles/mxnet_static.dir/3rdparty/tvm/nnvm/src/pass/gradient.cc.o ./CMakeFiles/mxnet_static.dir/src/nnvm/gradient.cc.o This can potentially cause problems when linking. The symbol that