Re: [maven] We need to make a decision

2006-01-17 Thread Bernd Bohmann
You can call it what ever, I expect we removed it later :-) Bernd Sean Schofield schrieb: Bernd, I'm ok to compromise and call the poms project. So tomahawk-project, sandbox-project, etc. What about the master pom? Do you prefer a separate myfaces-project just for the pom? Or do we keep

[jira] Commented: (MYFACES-582) SelectOneCountry needs to support an empty selection

2006-01-17 Thread Martin Marinschek (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-582?page=comments#action_12362943 ] Martin Marinschek commented on MYFACES-582: --- as an attribute? emptySelection=N/A or so? regards, Martin SelectOneCountry needs to support an empty selection

[jira] Created: (MYFACES-1033) 'empty' EL keyword

2006-01-17 Thread Thomas Timbul (JIRA)
'empty' EL keyword -- Key: MYFACES-1033 URL: http://issues.apache.org/jira/browse/MYFACES-1033 Project: MyFaces Type: Improvement Versions: 1.1.1 Reporter: Thomas Timbul Priority: Minor This probably violates the spec and may not

[jira] Created: (MYFACES-1034) Allow customisable AddResource implementations

2006-01-17 Thread Peter Mahoney (JIRA)
Allow customisable AddResource implementations -- Key: MYFACES-1034 URL: http://issues.apache.org/jira/browse/MYFACES-1034 Project: MyFaces Type: Improvement Components: Tomahawk Versions: Nightly Reporter:

[jira] Commented: (MYFACES-1034) Allow customisable AddResource implementations

2006-01-17 Thread Mathias Broekelmann (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1034?page=comments#action_12362953 ] Mathias Broekelmann commented on MYFACES-1034: -- sounds nice to me. Allow customisable AddResource implementations

Re: [maven] We need to make a decision

2006-01-17 Thread Manfred Geiler
2006/1/17, Sean Schofield [EMAIL PROTECTED]: Hmm..good point. If myfaces-commons is deployed at the container level, but a new version of tomahawk wants a later myfaces-commons that's a problem. It's very bad style to require a container's libs to be upgraded in order to deploy a webapp,

[jira] Erstellt: (MYFACES-1035) Schedule month view mode, shown interval

2006-01-17 Thread Joerg Saedtler (JIRA)
Schedule month view mode, shown interval Key: MYFACES-1035 URL: http://issues.apache.org/jira/browse/MYFACES-1035 Project: MyFaces Type: Improvement Components: Sandbox Reporter: Joerg Saedtler Priority: Minor

[maven] Major update to SVN (Again)

2006-01-17 Thread Sean Schofield
I think we're finished with the major updates to the SVN structure. I reorganized things to try to accomodate as many of the community preferences as possible. Here are the results: 1.) (Bernd) Api and impl have been consolidated into a single core dir. Since both will always be released

Re: [maven] Major update to SVN (Again)

2006-01-17 Thread Martin Marinschek
Thanks Sean for your hard work! Build ran through pretty well today. regards, Martin On 1/17/06, Sean Schofield [EMAIL PROTECTED] wrote: I think we're finished with the major updates to the SVN structure. I reorganized things to try to accomodate as many of the community preferences as

Re: Maven Build (Ongoing Work Thread)

2006-01-17 Thread Martin Marinschek
@Sean, Bruno: actually, I pretty much liked what Bruno did with the page design - I'm not too keen on changing the myfaces core logo itself, I think it should remain the drawn face, but I very much liked the easter island figures with their faces as a page banner... Plus: I liked the color

Re: [maven] Major update to SVN (Again)

2006-01-17 Thread Sean Schofield
Thanks also to Bernd and Bruno for their pom work and to John and Wendy for their suggestions. Sean On 1/17/06, Martin Marinschek [EMAIL PROTECTED] wrote: Thanks Sean for your hard work! Build ran through pretty well today. regards, Martin On 1/17/06, Sean Schofield [EMAIL PROTECTED]

Re: Maven Build (Ongoing Work Thread)

2006-01-17 Thread Sean Schofield
I have the exact opposite impression about the website but that is a matter of taste. Can we consider a mutually agreeable color scheme before voting? As for the easter island graphic - I'm -1 on it. I think the Apache Feather and the current ascii logo are fine. Also I like the look of a

Re: Maven Build (Ongoing Work Thread)

2006-01-17 Thread Martin Marinschek
Well, the design, as Bruno has implemented it is both more modern and more visually appealing IMHO. Anyway, I'd definitely say that in design issues, we should go with a majority vote, and not try to please every single person, be it you or me. I think nobody has looked on Bruno's design so far,

Re: Maven Build (Ongoing Work Thread)

2006-01-17 Thread Sean Schofield
I agree not everyone will be pleased with the ultimate choice. I also agree that the final decision should be a vote. I'm just saying that we should experiment with some color choices before having a vote. We can probably build the biggest consensus that way. We should try to achieve as much

Re: Maven Build (Ongoing Work Thread)

2006-01-17 Thread Martin Marinschek
Absolutely d'accord. regards, Martin On 1/17/06, Sean Schofield [EMAIL PROTECTED] wrote: I agree not everyone will be pleased with the ultimate choice. I also agree that the final decision should be a vote. I'm just saying that we should experiment with some color choices before having a

[jira] Created: (MYFACES-1036) HtmlMessageRenderer's replacement of input ID with input label fails when label is not escaped

2006-01-17 Thread Ken Weiner (JIRA)
HtmlMessageRenderer's replacement of input ID with input label fails when label is not escaped -- Key: MYFACES-1036 URL: http://issues.apache.org/jira/browse/MYFACES-1036 Project:

[jira] Created: (MYFACES-1037) ScheduleUtil.truncate does not truncate dates properly

2006-01-17 Thread Steven Cooke (JIRA)
ScheduleUtil.truncate does not truncate dates properly -- Key: MYFACES-1037 URL: http://issues.apache.org/jira/browse/MYFACES-1037 Project: MyFaces Type: Bug Components: Sandbox Environment: All Reporter:

Myfaces new site design

2006-01-17 Thread Bruno Aranda
Hi there, We have now two different proposals about the web design. None of them are definitive and we could get the best of both. So, as Martin has proposed in another thread let's start a discussion. I've captured two design snapshots of the two sites: - Proposal A Classic -

[jira] Commented: (MYFACES-1037) ScheduleUtil.truncate does not truncate dates properly

2006-01-17 Thread Steven Cooke (JIRA)
[ http://issues.apache.org/jira/browse/MYFACES-1037?page=comments#action_12363020 ] Steven Cooke commented on MYFACES-1037: --- Correction -- it is apparent only when *the input date* is in the afternoon ScheduleUtil.truncate does not truncate dates

Re: Myfaces new site design

2006-01-17 Thread Matthias Wessendorf
Bruno, thanks for your work! I like the color scheme of Proposal A (aka classic) but also like to see a nice image (that easter faces taken from proposal B (aka easter )). So, you are the designer. Can you *mix* them? Proposal C (aka mixture) :-) -Matthias On 1/17/06, Bruno Aranda [EMAIL

Re: Myfaces new site design

2006-01-17 Thread Sean Schofield
#1 Whether to use an image (as other mavenized apache sites do), independantly of the ascii-face logo, or not #2 In case of using an image, decide if the easter faces are ok. For the image on the RHS I was thinking that we create images for each module. Basically a simple text label image:

Re: Myfaces new site design

2006-01-17 Thread Sean Schofield
I like the icon of B on the upper-left side (feather + logo). +1 on this btw.

Re: Myfaces new site design

2006-01-17 Thread Martin Marinschek
I like option B, apart from that the lower part is not as easily readable as text on option A, so a change in color scheme is appropriate. And I really love the easter-island faces. regards, Martin On 1/17/06, Sean Schofield [EMAIL PROTECTED] wrote: I like the icon of B on the upper-left

Re: Myfaces new site design

2006-01-17 Thread Bruno Aranda
Ok, proposal C could be something like this Proposal C (aka mixture): http://people.apache.org/~baranda/myfaces-mix.png Although, banner colours should be readjusted, but it is an idea. Bruno 2006/1/17, Matthias Wessendorf [EMAIL PROTECTED]: Bruno, thanks for your work! I like the color

Re: Myfaces new site design

2006-01-17 Thread Bruno Aranda
+1 Do you mean something like the maven site, right? I like that too, Bruno 2006/1/17, Sean Schofield [EMAIL PROTECTED]: #1 Whether to use an image (as other mavenized apache sites do), independantly of the ascii-face logo, or not #2 In case of using an image, decide if the easter faces

Re: Myfaces new site design

2006-01-17 Thread Sean Schofield
+1 Do you mean something like the maven site, right? I like that too, Yes like the maven site but without the banner image. More like the Struts site (except they do not currently change it for each subproject.) Sorry but I do not like the Easter Island graphic. Its too much (too busy) IMO

Re: Myfaces new site design

2006-01-17 Thread Sean Schofield
The mixture is better. I'll try and play around with possible color schemes later tonight. Also, we should see if Chris Barlow has any ideas. He's good with artwork and helped up come up with the current myfaces feather logo. What do you think about the other style changes I made? I like the

Re: svn commit: r369884 - /myfaces/commons/trunk/pom.xml

2006-01-17 Thread Sean Schofield
Bernd, Do we still need this exclusion? The tests seemed to be running ok (no errors). Sean On 1/17/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: bommel Date: Tue Jan 17 11:26:42 2006 New Revision: 369884 URL: http://svn.apache.org/viewcvs?rev=369884view=rev Log: exclude the

Re: [maven] We need to make a decision

2006-01-17 Thread John Fallows
In reality, the code in the public myfaces-commons codebase is nowhere close to being locked down in the same way as the various Apache Commons public APIs. For example, it contains code in many identical packages to myfaces-tomahawk, that needs to be fixed before this API could be considered

Re: [maven] TLD generation messed up again

2006-01-17 Thread Martin Marinschek
hmmm... I was doing a clean install today - and we checked for the tld's being generated, right after you checked in your changes. regards, Martin On 1/17/06, Sean Schofield [EMAIL PROTECTED] wrote: The TLD files are failing again (if you do a clean install.) I thought we fixed this issue

Re: [maven] TLD generation messed up again

2006-01-17 Thread Sean Schofield
Well I'm at work now ... so something is different. Perhaps I don't have the correct xslt plugin version installed locally. I tried rebuilding the xslt plugin from the latest source but that fails also. (Maybe they should eat their own dog food on the codehaus project and use continuum to check

Re: [maven] TLD generation messed up again

2006-01-17 Thread Sean Schofield
FYI I filed a bug with codehaus[1] about not being able to recompile the xslt plugin. I guess we can forgvie them since its still sandbox :-) [1] http://jira.codehaus.org/browse/MOJO-247 On 1/17/06, Sean Schofield [EMAIL PROTECTED] wrote: Well I'm at work now ... so something is different.

Re: Myfaces new site design

2006-01-17 Thread Mario Ivankovits
Bruno Aranda schrieb: Ok, proposal C could be something like this Proposal C (aka mixture): http://people.apache.org/~baranda/myfaces-mix.png Not binding, but definitely +1. Ciao, Mario

In JspStateManagerImpl line 209

2006-01-17 Thread Danner, Russ
In JspStateManagerImpl line 209 Maybe would should check before the cast SerializedView serializedView = null; Object vExternalContext = externalContext.getRequestMap().get(SERIALIZED_VIEW_REQUEST_ATTR); if(vExternalContext!=null) { if(vExternalContext instanceof

Build instructions on the site

2006-01-17 Thread Danner, Russ
Guys, The build instructions on the site seem to be out of date or are incomprehensible to a dullard such as myself. It looks like they are pre-maven? Could be just me not properly RTFM (I'm a little tired) but if they are wrong... you should know about it. -R