Re: [VOTE] Release of MyFaces Core 4.0.0-RC3

2022-12-24 Thread Melloware Inc
Ok now Quarkus support is fully working ready for 4.0RC3 whenever you guys are!  Thanks to the team for helping me fix all the issues!!!Melloware@melloware on GitHubOn Dec 23, 2022, at 4:09 PM, Bernd Bohmann wrote:Here is my +1RegardsBerndThomas Andraschko schrieb

[GitHub] [myfaces] melloware commented on pull request #462: build: quarkus extension showcase groupId should be a myfaces groupid…

2022-12-24 Thread GitBox
melloware commented on PR #462: URL: https://github.com/apache/myfaces/pull/462#issuecomment-1364553066 Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [myfaces] melloware merged pull request #462: build: quarkus extension showcase groupId should be a myfaces groupid…

2022-12-24 Thread GitBox
melloware merged PR #462: URL: https://github.com/apache/myfaces/pull/462 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] bohmber opened a new pull request, #462: build: quarkus extension showcase groupId should be a myfaces groupid…

2022-12-24 Thread GitBox
bohmber opened a new pull request, #462: URL: https://github.com/apache/myfaces/pull/462 … and logs should be created in target directory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [myfaces] bohmber merged pull request #461: RAT fixes

2022-12-24 Thread GitBox
bohmber merged PR #461: URL: https://github.com/apache/myfaces/pull/461 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] bohmber commented on pull request #461: RAT fixes

2022-12-24 Thread GitBox
bohmber commented on PR #461: URL: https://github.com/apache/myfaces/pull/461#issuecomment-1364548545 @melloware It's ok I will take a look later or tomorrow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [myfaces] melloware commented on pull request #461: RAT fixes

2022-12-24 Thread GitBox
melloware commented on PR #461: URL: https://github.com/apache/myfaces/pull/461#issuecomment-1364548041 @bohmber stumped on this again. RAT is saying "debug.log" does not have a license and I have tried everything to exlcude *.log from looking at licenses but I have no idea what I am

[GitHub] [myfaces] melloware commented on pull request #459: Quarkus 3 support

2022-12-24 Thread GitBox
melloware commented on PR #459: URL: https://github.com/apache/myfaces/pull/459#issuecomment-1364537646 got it. let me fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [myfaces] bohmber commented on pull request #459: Quarkus 3 support

2022-12-24 Thread GitBox
bohmber commented on PR #459: URL: https://github.com/apache/myfaces/pull/459#issuecomment-1364537566 > @bohmber I dont understand the Apache RAT build failure? @melloware Most of the time apache rat plugin is not configured in the pom or configured via parent poms. I think it's

[GitHub] [myfaces] melloware merged pull request #460: Quarkus Remove unnecesary depenedcies

2022-12-24 Thread GitBox
melloware merged PR #460: URL: https://github.com/apache/myfaces/pull/460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] melloware commented on pull request #459: Quarkus 3 support

2022-12-24 Thread GitBox
melloware commented on PR #459: URL: https://github.com/apache/myfaces/pull/459#issuecomment-1364531083 @bohmber I dont understand the Apache RAT build failure? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [myfaces] tandraschko merged pull request #459: Quarkus 3 support

2022-12-24 Thread GitBox
tandraschko merged PR #459: URL: https://github.com/apache/myfaces/pull/459 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [myfaces] melloware commented on a diff in pull request #459: Quarkus 3 support

2022-12-24 Thread GitBox
melloware commented on code in PR #459: URL: https://github.com/apache/myfaces/pull/459#discussion_r1056822418 ## extensions/quarkus/showcase/src/test/java/org/apache/myfaces/core/extensions/quarkus/showcase/QuarkusMyFacesShowcaseTest.java: ## @@ -69,7 +69,7 @@ public void

[GitHub] [myfaces] melloware opened a new pull request, #459: Quarkus 3 support

2022-12-24 Thread GitBox
melloware opened a new pull request, #459: URL: https://github.com/apache/myfaces/pull/459 @tandraschko I got it all working! Quarkus did not like the ViewScopedEventListener.Bridge being an inner scoped Application scoped static bean. I moved it into its own normal class and then

[GitHub] [myfaces] melloware commented on pull request #458: Quarkus 3 Preview

2022-12-24 Thread GitBox
melloware commented on PR #458: URL: https://github.com/apache/myfaces/pull/458#issuecomment-1364525541 OK here is the class the BeanManager can't find: ![image](https://user-images.githubusercontent.com/4399574/209436992-6a7c0cd3-bb0e-4778-be53-7e34e4b5afca.png) I am wondering