Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-11-06 Thread via GitHub
werpu commented on PR #638: URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796991675 I will have a deeper look into this tomorrow, I need to debug this out properly, the issue simply is there are possibilities where an array of values can come in over checkbox fields over

Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-11-06 Thread via GitHub
volosied commented on PR #638: URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796973598 Thanks for looking. I hoped it would work, too, but it doesn't, unfortunately. Problem looks to be here: getFormData:function () { var formDataDecorator =

Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-11-06 Thread via GitHub
werpu commented on PR #638: URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796524136 Mhh I have to check that let me check that tomorrow! There needs to be a check that the value of the same element is not attached twice. It is getting late here, so I will check that

Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-11-06 Thread via GitHub
volosied commented on PR #638: URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796428426 I'm seeing it's caused by ajaxUtils.encodeSubmittableFields(ret, form, null);

Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-11-06 Thread via GitHub
volosied commented on PR #638: URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796413956 Yep, it's fixed now. Thanks! However, I'm still seeing the an array sent for the issuing element?

Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-11-06 Thread via GitHub
werpu commented on PR #638: URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796399710 Fixed it, sorry for the issue, I guess I have to recheck my integration tests apparently this code was not triggered by them! (the 4.x codebase has a dedicated unit test so it is covered

Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-11-06 Thread via GitHub
werpu commented on PR #638: URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796387031 mhh let me check quickly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-11-06 Thread via GitHub
volosied commented on PR #638: URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796385353 @werpu I'm getting the following error in my test case: ``` Error Message: (intermediate value).toLowerCase is not a function

Re: [PR] Follow up on https://issues.apache.org/jira/browse/MYFACES-4606 [myfaces]

2023-11-06 Thread via GitHub
werpu commented on PR #638: URL: https://github.com/apache/myfaces/pull/638#issuecomment-1796359752 does it work for you? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] build(deps-dev): bump junit-jupiter.version from 5.10.0 to 5.10.1 [myfaces-tobago]

2023-11-06 Thread via GitHub
dependabot[bot] opened a new pull request, #4457: URL: https://github.com/apache/myfaces-tobago/pull/4457 Bumps `junit-jupiter.version` from 5.10.0 to 5.10.1. Updates `org.junit.jupiter:junit-jupiter-engine` from 5.10.0 to 5.10.1 Release notes Sourced from

[PR] build(deps-dev): bump junit-jupiter.version from 5.10.0 to 5.10.1 [myfaces-tobago]

2023-11-06 Thread via GitHub
dependabot[bot] opened a new pull request, #4456: URL: https://github.com/apache/myfaces-tobago/pull/4456 Bumps `junit-jupiter.version` from 5.10.0 to 5.10.1. Updates `org.junit.jupiter:junit-jupiter-engine` from 5.10.0 to 5.10.1 Release notes Sourced from

Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]

2023-11-06 Thread via GitHub
volosied closed pull request #634: MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements URL: https://github.com/apache/myfaces/pull/634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] MYFACES-4606 Follow up: do not send values for unselected radio / checkbox elements [myfaces]

2023-11-06 Thread via GitHub
volosied commented on PR #634: URL: https://github.com/apache/myfaces/pull/634#issuecomment-1795347329 Closing in favor of #638. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[PR] build(deps-dev): bump junit-jupiter.version from 5.10.0 to 5.10.1 [myfaces-tobago]

2023-11-06 Thread via GitHub
dependabot[bot] opened a new pull request, #4455: URL: https://github.com/apache/myfaces-tobago/pull/4455 Bumps `junit-jupiter.version` from 5.10.0 to 5.10.1. Updates `org.junit.jupiter:junit-jupiter-engine` from 5.10.0 to 5.10.1 Release notes Sourced from

[PR] build(deps): bump org.codehaus.plexus:plexus-archiver from 4.8.0 to 4.9.0 [myfaces-tobago]

2023-11-06 Thread via GitHub
dependabot[bot] opened a new pull request, #4454: URL: https://github.com/apache/myfaces-tobago/pull/4454 Bumps [org.codehaus.plexus:plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 4.8.0 to 4.9.0. Release notes Sourced from

[VOTE] Release Tobago 6.0.0 and Tobago 5.8.0

2023-11-06 Thread Henning Nöth
Hello, we would like to release: * Tobago 6.0.0 * Tobago 5.8.0 The artifacts were deployed on nexus repository for binary and source packages: * Tobago 6.0.0 [1] * Tobago 5.8.0 [2] The release notes are in Jira: * Tobago 6.0.0 [3] * Tobago 5.8.0 [4] The artifacts are available at the staging

[jira] [Resolved] (TOBAGO-2244) Avoid NullpointerException in HtmlRendererUtils#writeDataAttributes with SegmentLayout and composite components and ajax

2023-11-06 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2244. -- Resolution: Fixed > Avoid NullpointerException in HtmlRendererUtils#writeDataAttributes with

[jira] [Resolved] (TOBAGO-2254) Selector All Checkbox is not synchronized with selector Checkbox in each row after ajax request

2023-11-06 Thread Jira
[ https://issues.apache.org/jira/browse/TOBAGO-2254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Henning Nöth resolved TOBAGO-2254. -- Fix Version/s: 5.8.0 6.0.0 Resolution: Fixed > Selector All

Re: [PR] fix(sheet): Selector All Checkbox is not synchronized with selector Checkbox in each row after ajax request [myfaces-tobago]

2023-11-06 Thread via GitHub
henningn merged PR #4453: URL: https://github.com/apache/myfaces-tobago/pull/4453 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[PR] fix(sheet): Selector All Checkbox is not synchronized with selector Checkbox in each row after ajax request [myfaces-tobago]

2023-11-06 Thread via GitHub
henningn opened a new pull request, #4453: URL: https://github.com/apache/myfaces-tobago/pull/4453 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To