Re: [PR] MYFACES-4660 4.1 view destroying fix + keeping track of user connection in multiple tabs [myfaces]

2024-04-24 Thread via GitHub
tandraschko commented on PR #705: URL: https://github.com/apache/myfaces/pull/705#issuecomment-2074927528 TBH i would some time for debugging and i dont have this maybe just the channelToken generation is wrong, dont know currently, sorry -- This is an automated message from the

Re: [PR] MYFACES-4660 4.1 view destroying fix + keeping track of user connection in multiple tabs [myfaces]

2024-04-24 Thread via GitHub
milansie commented on PR #705: URL: https://github.com/apache/myfaces/pull/705#issuecomment-2074902294 Yup, it seems so. If the channel is applicationScope, only one channelToken exists for the application. If the channel scope is session (and user is specified), there is same

Re: [PR] MYFACES-4660 4.1 view destroying fix + keeping track of user connection in multiple tabs [myfaces]

2024-04-24 Thread via GitHub
tandraschko commented on PR #705: URL: https://github.com/apache/myfaces/pull/705#issuecomment-2074843461 how are the channelTokens generated? i wonder that if you open index.xhtml in two different tabs, does it use the same channelToken? -- This is an automated message from the

Re: [PR] MYFACES-4660 4.1 view destroying fix + keeping track of user connection in multiple tabs [myfaces]

2024-04-21 Thread via GitHub
milansie commented on code in PR #705: URL: https://github.com/apache/myfaces/pull/705#discussion_r1573884876 ## impl/src/main/java/org/apache/myfaces/push/cdi/WebsocketScopeManager.java: ## @@ -161,26 +161,12 @@ public static class ViewScope extends AbstractUserScope

Re: [PR] MYFACES-4660 4.1 view destroying fix + keeping track of user connection in multiple tabs [myfaces]

2024-04-21 Thread via GitHub
milansie commented on code in PR #705: URL: https://github.com/apache/myfaces/pull/705#discussion_r1573742064 ## impl/src/main/java/org/apache/myfaces/push/cdi/WebsocketScopeManager.java: ## @@ -161,26 +161,12 @@ public static class ViewScope extends AbstractUserScope

Re: [PR] MYFACES-4660 4.1 view destroying fix + keeping track of user connection in multiple tabs [myfaces]

2024-04-21 Thread via GitHub
tandraschko commented on code in PR #705: URL: https://github.com/apache/myfaces/pull/705#discussion_r1573723120 ## impl/src/main/java/org/apache/myfaces/push/cdi/WebsocketScopeManager.java: ## @@ -161,26 +161,12 @@ public static class ViewScope extends AbstractUserScope

Re: [PR] MYFACES-4660 4.1 view destroying fix + keeping track of user connection in multiple tabs [myfaces]

2024-04-21 Thread via GitHub
tandraschko commented on code in PR #705: URL: https://github.com/apache/myfaces/pull/705#discussion_r1573723120 ## impl/src/main/java/org/apache/myfaces/push/cdi/WebsocketScopeManager.java: ## @@ -161,26 +161,12 @@ public static class ViewScope extends AbstractUserScope