[jira] Commented: (MYFACES-2161) MyFaces-API issue: getValue of UIInput

2009-03-10 Thread Leonardo Uribe (JIRA)
on UIInput: public Object getValue() { if (isLocalValueSet()) return super.getLocalValue(); return super.getValue(); } I have committed a test that reproduce this scenario too. MyFaces-API issue: getValue of UIInput -- Key

[jira] Resolved: (MYFACES-2161) MyFaces-API issue: getValue of UIInput

2009-03-10 Thread Leonardo Uribe (JIRA)
Uribe MyFaces-API issue: getValue of UIInput -- Key: MYFACES-2161 URL: https://issues.apache.org/jira/browse/MYFACES-2161 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects

[jira] Created: (MYFACES-2161) MyFaces-API issue: getValue of UIInput

2009-03-06 Thread Kaeri Johnson (JIRA)
MyFaces-API issue: getValue of UIInput -- Key: MYFACES-2161 URL: https://issues.apache.org/jira/browse/MYFACES-2161 Project: MyFaces Core Issue Type: Bug Components: JSR-252 Affects Versions

Re: MyFaces-API issue: getValue of UIInput

2007-03-03 Thread Martin Marinschek
I forwarded the thread to Ed, as neither Adam, Craig, Kito or Manfred had anything to say on this... or do they? There is an alternative workaround: I checked it in RendererUtils yesterday - for you to review. However, I think it makes the value lookup code in the renderer very complicated. It

[jira] Commented: (MYFACES-1549) MyFaces-API issue: getValue of UIInput

2007-03-02 Thread Martin Marinschek (JIRA)
://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java?view=diffrev=513319r1=513318r2=513319 regards, Martin MyFaces-API issue: getValue of UIInput -- Key: MYFACES-1549 URL: https

[jira] Commented: (MYFACES-1549) MyFaces-API issue: getValue of UIInput

2007-03-02 Thread Martin Marinschek (JIRA)
the other side as well: the code in RendererUtils has the same problem. http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java?view=diffrev=513799r1=513798r2=513799 regards, Martin MyFaces-API issue: getValue of UIInput

Re: MyFaces-API issue: getValue of UIInput

2007-03-02 Thread Cagatay Civici
Yeah, exactly. Did you read my mail from before? Plus my new issue-evaluation? No, I read your mail after sending a reply about the converter, anyway you're right about the bug Martin. In this case, I'd strongly recommend that you run this by the spec folks. If nothing else, we should get

MyFaces-API issue: getValue of UIInput

2007-03-01 Thread Martin Marinschek
Wanted to discuss a small thing with you: UIOutput currently has the following code: public Object getValue() { if (_value != null) return _value; ValueBinding vb = getValueBinding(value); return vb != null ? (Object)vb.getValue(getFacesContext()) : null;

Re: MyFaces-API issue: getValue of UIInput

2007-03-01 Thread Cagatay Civici
Hi Martin, I just tried the scenario but couldn't reproduce it. Shouldn't the second step be; 2) conversion and validation phase: -- setValue(); isLocalValueSet = true; setSubmittedValue(null); An empty string instead of null is set by setValue(), so the local value becomes , preventing the

Re: MyFaces-API issue: getValue of UIInput

2007-03-01 Thread Martin Marinschek
that entirely depends on the converter! If the converter sets a 'null' as the local-value (which is the only choice if the date-type is not a string), we are having a problem. regards, Martin On 3/1/07, Cagatay Civici [EMAIL PROTECTED] wrote: Hi Martin, I just tried the scenario but couldn't

[jira] Commented: (MYFACES-1549) MyFaces-API issue: getValue of UIInput

2007-03-01 Thread Martin Marinschek (JIRA)
/saveState-process - see: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java?view=diffrev=513253r1=513252r2=513253 regards, Martin MyFaces-API issue: getValue of UIInput -- Key: MYFACES-1549

[jira] Commented: (MYFACES-1549) MyFaces-API issue: getValue of UIInput

2007-03-01 Thread Martin Marinschek (JIRA)
is private and I couldn't access it from the UIInput. Link to commit log: http://svn.apache.org/viewvc/myfaces/core/trunk/api/src/main/java/javax/faces/component/UIInput.java?view=diffrev=513252r1=513251r2=513252 regards, Martin MyFaces-API issue: getValue of UIInput

[jira] Resolved: (MYFACES-1549) MyFaces-API issue: getValue of UIInput

2007-03-01 Thread Martin Marinschek (JIRA)
[ https://issues.apache.org/jira/browse/MYFACES-1549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Marinschek resolved MYFACES-1549. Resolution: Fixed MyFaces-API issue: getValue of UIInput

[jira] Created: (MYFACES-1549) MyFaces-API issue: getValue of UIInput

2007-03-01 Thread Martin Marinschek (JIRA)
MyFaces-API issue: getValue of UIInput -- Key: MYFACES-1549 URL: https://issues.apache.org/jira/browse/MYFACES-1549 Project: MyFaces Core Issue Type: Bug Components: JSR-127 Affects Versions

Re: MyFaces-API issue: getValue of UIInput

2007-03-01 Thread Cagatay Civici
I think using a converter can cause this issue, here's the code from UIInput public void validate(FacesContext context) { if (context == null) throw new NullPointerException(context); Object submittedValue = getSubmittedValue(); if (submittedValue == null) return;

Re: MyFaces-API issue: getValue of UIInput

2007-03-01 Thread Martin Marinschek
Yeah, exactly. Did you read my mail from before? Plus my new issue-evaluation? regards, Martin On 3/1/07, Cagatay Civici [EMAIL PROTECTED] wrote: I think using a converter can cause this issue, here's the code from UIInput public void validate(FacesContext context) { if (context

Re: MyFaces-API issue: getValue of UIInput

2007-03-01 Thread Mike Kienenberger
What's the spec say about UIInput's getValue()? If it's silent, I'd say your solution makes sense. On 3/1/07, Martin Marinschek [EMAIL PROTECTED] wrote: Wanted to discuss a small thing with you: UIOutput currently has the following code: public Object getValue() { if

Re: MyFaces-API issue: getValue of UIInput

2007-03-01 Thread Mike Kienenberger
In this case, I'd strongly recommend that you run this by the spec folks. If nothing else, we should get a clarification for the next revision. On 3/1/07, Martin Marinschek [EMAIL PROTECTED] wrote: I didn't find anything in the spec. JavaDoc of getValue in UIOutput says: Gets the value of