Re: code style for new commons modules?

2008-07-14 Thread Werner Punz
simon schrieb: Hi, Should the new commons modules use the traditional MyFaces code style, the Sun code style? Right now, it is a mix with some files in one style, and some files in another (probably about 65% Sun style). Regards, Simon +1 for the myfaces codestyle...

Re: code style for new commons modules?

2008-07-14 Thread Werner Punz
Guess i have to clarify things here we have a huge codebase, following the myfaces codestyle, it simply does not make sense to use the sun codestyle, in one project if all others follow the myfaces guidelines. Either codestyle can be enforced via code formatting settings. Werner Hazem Saleh

Re: code style for new commons modules?

2008-07-14 Thread Gerhard Petracek
+1 for using the same codestyle for all myfaces projects. regards, gerhard 2008/7/14 Werner Punz [EMAIL PROTECTED]: Guess i have to clarify things here we have a huge codebase, following the myfaces codestyle, it simply does not make sense to use the sun codestyle, in one project if all

Re: code style for new commons modules?

2008-07-14 Thread Volker Weber
Hi, +1 for the code style used in myfaces-tobago ;-) Can someone describe the differences between sun and myfaces code styles? Regards, Volker 2008/7/12 simon [EMAIL PROTECTED]: Hi, Should the new commons modules use the traditional MyFaces code style, the Sun code style? Right now,

Re: code style for new commons modules?

2008-07-14 Thread Bernd Bohmann
Hello, +1 for the myfaces-tobago code style. The the myfaces-tobago code style is primarily the sun code style. Some addtional requirements are: tabWith is 2, need Braces ... Regards Bernd Volker Weber schrieb: Hi, +1 for the code style used in myfaces-tobago ;-) Can someone describe

code style for new commons modules?

2008-07-12 Thread simon
Hi, Should the new commons modules use the traditional MyFaces code style, the Sun code style? Right now, it is a mix with some files in one style, and some files in another (probably about 65% Sun style). Regards, Simon