Re: required icon after label: How to best implement skinning?

2007-10-04 Thread Stephen Friedrich
Thanks Simon, implementation is done, please see https://issues.apache.org/jira/browse/TRINIDAD-755 I tried to to keep the code changes small, but failed. First, if the position of the required icon is skinnable, then the position of the message icon should sure be skinnable, too. Yet, now

required icon after label: How to best implement skinning?

2007-10-01 Thread Stephen Friedrich
I have just changed the OutputLabelRenderer to optionally render the required icon _after_ the label. How should I implement skinning for that? (Currently I check a system property, that I set in my test code.) What is the practical difference between defining a new skinning property vs. a

Re: required icon after label: How to best implement skinning?

2007-10-01 Thread Simon Lessard
Hello Stephen, This is definitely a skin property case, not per component. There's no strict rule though. About the name, maybe -tr-required-icon-position? ~ Simon On 10/1/07, Stephen Friedrich [EMAIL PROTECTED] wrote: I have just changed the OutputLabelRenderer to optionally render the