[
https://issues.apache.org/jira/browse/MYFACES-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698204#comment-17698204
]
Manuel K commented on MYFACES-4589:
---
Thank you for taking a look! After your first comment I thought
[
https://issues.apache.org/jira/browse/MYFACES-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volodymyr Siedlecki resolved MYFACES-4592.
--
Resolution: Invalid
We failed to export org.apache.myfaces.cdi.clientwindow
Yes we have been fighting chrome issues. I think it’s related to the grapheme driver as I use Selenium with the automatic driver downloading on other projects and have no issues. But yes it’s broken the MyFaces build multiple times in the last 2 months every time Chrome updates.
I did just come across this:
https://groups.google.com/g/chromedriver-users/c/xL5-13_qGaA
On Wed, Mar 8, 2023 at 8:51 PM Paul Nicolucci wrote:
> Is anyone else hitting issues with building the main branch? I pulled the
> latest this evening and initially, the build failed and told me I needed
Is anyone else hitting issues with building the main branch? I pulled the
latest this evening and initially, the build failed and told me I needed to
update to Chrome 111. I updated chrome and now I'm getting the following
error:
[ERROR] Errors:
> [ERROR] IntegrationTest.test ▒ Runtime Unable
[
https://issues.apache.org/jira/browse/MYFACES-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698103#comment-17698103
]
Volodymyr Siedlecki commented on MYFACES-4592:
--
Added more stack trace as I've found a
[
https://issues.apache.org/jira/browse/MYFACES-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698102#comment-17698102
]
Melloware commented on MYFACES-4590:
So this line is return NULL instead of the default MAX VALUE
[
https://issues.apache.org/jira/browse/MYFACES-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698101#comment-17698101
]
Melloware commented on MYFACES-4590:
OK if I change
{code:java}
{code}
To
{code:java}
{code}
it
[
https://issues.apache.org/jira/browse/MYFACES-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698100#comment-17698100
]
Melloware commented on MYFACES-4590:
I think its relate to this:
[
https://issues.apache.org/jira/browse/MYFACES-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698099#comment-17698099
]
Volodymyr Siedlecki commented on MYFACES-4592:
--
Then again, we can see:
{code:java}
final
[
https://issues.apache.org/jira/browse/MYFACES-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698093#comment-17698093
]
Volodymyr Siedlecki commented on MYFACES-4592:
--
If we take a look at the lambda created in
[
https://issues.apache.org/jira/browse/MYFACES-4592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17698089#comment-17698089
]
Volodymyr Siedlecki commented on MYFACES-4592:
--
Do we need to be explicit and cast these
Volodymyr Siedlecki created MYFACES-4592:
Summary: Lambda ClassCastException with Session Persistence
Key: MYFACES-4592
URL: https://issues.apache.org/jira/browse/MYFACES-4592
Project: MyFaces
melloware commented on PR #544:
URL: https://github.com/apache/myfaces/pull/544#issuecomment-1460799034
We use Felix 5.1.8 in PrimeFaces too and I don't think we have had issues so
this is strange.
--
This is an automated message from the Apache Git Service.
To respond to the message,
werpu commented on PR #546:
URL: https://github.com/apache/myfaces/pull/546#issuecomment-1460738188
Thanks for fixing it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
bohmber commented on PR #546:
URL: https://github.com/apache/myfaces/pull/546#issuecomment-1460666520
Build is running successful now with the correct chromeDriverVersion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
volosied commented on PR #544:
URL: https://github.com/apache/myfaces/pull/544#issuecomment-1460659391
I'll try to reach out to some more people.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/MYFACES-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697980#comment-17697980
]
Werner Punz commented on MYFACES-4584:
--
Ok I will aim for a merge in the remainder of the week. I
[
https://issues.apache.org/jira/browse/MYFACES-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697978#comment-17697978
]
Thomas Andraschko commented on MYFACES-4584:
+1 - refactorings and simplification is always
[
https://issues.apache.org/jira/browse/MYFACES-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697975#comment-17697975
]
Werner Punz commented on MYFACES-4584:
--
I would have most of my fixes for the codebase ready,
[
https://issues.apache.org/jira/browse/MYFACES-4584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697975#comment-17697975
]
Werner Punz edited comment on MYFACES-4584 at 3/8/23 3:54 PM:
--
I would
[
https://issues.apache.org/jira/browse/MYFACES-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697961#comment-17697961
]
Werner Punz edited comment on MYFACES-4588 at 3/8/23 3:34 PM:
--
resolved..
[
https://issues.apache.org/jira/browse/MYFACES-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697961#comment-17697961
]
Werner Punz edited comment on MYFACES-4588 at 3/8/23 3:32 PM:
--
resolved..
[
https://issues.apache.org/jira/browse/MYFACES-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697961#comment-17697961
]
Werner Punz commented on MYFACES-4588:
--
resolved.. melloware could confirm with a local test that
werpu merged PR #546:
URL: https://github.com/apache/myfaces/pull/546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
[
https://issues.apache.org/jira/browse/MYFACES-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Werner Punz resolved MYFACES-4588.
--
Resolution: Fixed
> faces.getClientWindow does not retrieve client id
>
werpu commented on PR #546:
URL: https://github.com/apache/myfaces/pull/546#issuecomment-1460337100
ci build still failing, but given this is unrelated to my fix and also on
the master branch, I guess we can merge now!
--
This is an automated message from the Apache Git Service.
To
werpu commented on code in PR #546:
URL: https://github.com/apache/myfaces/pull/546#discussion_r1129618027
##
api/src/client/typescript/faces/impl/AjaxImpl.ts:
##
@@ -54,7 +54,7 @@ import {
EMPTY_STR,
CTX_PARAM_MF_INTERNAL,
NAMED_VIEWROOT,
-
volosied commented on code in PR #546:
URL: https://github.com/apache/myfaces/pull/546#discussion_r1129614432
##
api/src/client/typescript/faces/impl/AjaxImpl.ts:
##
@@ -54,7 +54,7 @@ import {
EMPTY_STR,
CTX_PARAM_MF_INTERNAL,
NAMED_VIEWROOT,
-
volosied commented on PR #546:
URL: https://github.com/apache/myfaces/pull/546#issuecomment-1460328955
+1
Tested locally and the fix works! Thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
bohmber commented on PR #546:
URL: https://github.com/apache/myfaces/pull/546#issuecomment-1460321284
The version should be 110.0.5481.77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bohmber commented on PR #546:
URL: https://github.com/apache/myfaces/pull/546#issuecomment-1460312387
Unfortunately there is not better fix at the moment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
melloware commented on PR #546:
URL: https://github.com/apache/myfaces/pull/546#issuecomment-1460307472
I am attempting to fix it now with `-DchromeDriverVersion=110.0.5481.177`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
[
https://issues.apache.org/jira/browse/MYFACES-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697940#comment-17697940
]
Werner Punz edited comment on MYFACES-4588 at 3/8/23 2:57 PM:
--
fixed it,
[
https://issues.apache.org/jira/browse/MYFACES-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697941#comment-17697941
]
Thomas Andraschko commented on MYFACES-4589:
i tried to debug a bit but i think that would
[
https://issues.apache.org/jira/browse/MYFACES-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697940#comment-17697940
]
Werner Punz commented on MYFACES-4588:
--
fixed it, but withheld the merge, we have a chrome
werpu commented on PR #546:
URL: https://github.com/apache/myfaces/pull/546#issuecomment-1460277452
Seems like we have an integration test build issue, apparently the chrome
driver has a version mismatch with chrome version in the build system. Wont
merge until everything passes. But the
werpu opened a new pull request, #546:
URL: https://github.com/apache/myfaces/pull/546
Fixes the issue that getWindowId did not look into the document in the
correct order.
Also added tests for the case and added tests for the file upload given from
the Tobago guys (which I forgot to
[
https://issues.apache.org/jira/browse/MYFACES-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697931#comment-17697931
]
Volodymyr Siedlecki commented on MYFACES-4588:
--
I would prefer to keep c) to be consistent
[
https://issues.apache.org/jira/browse/MYFACES-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697876#comment-17697876
]
Werner Punz edited comment on MYFACES-4588 at 3/8/23 2:13 PM:
--
I will take
henningn opened a new pull request, #3851:
URL: https://github.com/apache/myfaces-tobago/pull/3851
Sometimes the title of Intro.xhtml is not set. This behavior is only for
docker integration-tests in tomcat. Also, it's a special issue for the demo. A
reload should fix this.
--
This is
henningn merged PR #3852:
URL: https://github.com/apache/myfaces-tobago/pull/3852
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
henningn merged PR #3851:
URL: https://github.com/apache/myfaces-tobago/pull/3851
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
henningn opened a new pull request, #3852:
URL: https://github.com/apache/myfaces-tobago/pull/3852
Sometimes the title of Intro.xhtml is not set. This behavior is only for
docker integration-tests in tomcat. Also, it's a special issue for the demo. A
reload should fix this.
--
This is
[
https://issues.apache.org/jira/browse/MYFACES-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697893#comment-17697893
]
Melloware commented on MYFACES-4590:
Yep I assigned myself!
> NullPointerException when PrimeFaces
[
https://issues.apache.org/jira/browse/MYFACES-4590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697880#comment-17697880
]
Thomas Andraschko commented on MYFACES-4590:
[~melloware] looks like a PF thing for me, can
[
https://issues.apache.org/jira/browse/MYFACES-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697876#comment-17697876
]
Werner Punz edited comment on MYFACES-4588 at 3/8/23 12:52 PM:
---
I will
[
https://issues.apache.org/jira/browse/MYFACES-4588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697876#comment-17697876
]
Werner Punz commented on MYFACES-4588:
--
I will take care of it!
> faces.getClientWindow does
[
https://issues.apache.org/jira/browse/MYFACES-4591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Thomas Andraschko resolved MYFACES-4591.
Assignee: Thomas Andraschko
Resolution: Fixed
> [perf] remove duplicated
Thomas Andraschko created MYFACES-4591:
--
Summary: [perf] remove duplicated CDI ELResolver
Key: MYFACES-4591
URL: https://issues.apache.org/jira/browse/MYFACES-4591
Project: MyFaces Core
[
https://issues.apache.org/jira/browse/MYFACES-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697830#comment-17697830
]
Thomas Andraschko edited comment on MYFACES-4589 at 3/8/23 10:35 AM:
[
https://issues.apache.org/jira/browse/MYFACES-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697830#comment-17697830
]
Thomas Andraschko commented on MYFACES-4589:
i now optimized the ELResolver (and removed
[
https://issues.apache.org/jira/browse/MYFACES-4589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17697776#comment-17697776
]
Thomas Andraschko commented on MYFACES-4589:
it seems the default order of the ELResolver
Manuel K created MYFACES-4590:
-
Summary: NullPointerException when PrimeFaces FileUpload used in
composite component
Key: MYFACES-4590
URL: https://issues.apache.org/jira/browse/MYFACES-4590
Project:
54 matches
Mail list logo
